mbox series

[v3,0/2] Add common RDP dtsi file for IPQ9574

Message ID 20230927-common-rdp-v3-0-3d07b3ff6d42@quicinc.com
Headers
Series Add common RDP dtsi file for IPQ9574 |

Message

Kathiravan Thirumoorthy Sept. 27, 2023, 6:43 a.m. UTC 
  Some interfaces are common across RDPs. Move the common nodes to
ipq9574-rdp-common.dtsi like how it is done for IPQ5332. Use rdp specific
dts file to include interfaces that vary across RDPs. For instance, IPQ9574
has 4 PCIE controllers. RDP417 enables PCIE0 and PCIE1 whereas RDP433
enables PCIE1, PCIE2 and PCIE3.

With the introduction of the common RDP DTSI,
	- RDP433 gains SPI NOR support
	- All the IPQ9574 RDPs gains USB2 and USB3 support

While at it, add support for WPS buttons.

Since Anusha's is busy and can't take up this series right now, I'm
stepping up to work on this series.

Changes in V3:
	- Reworded the cover letter to indicate the need and advantages
	  of common RDP DTSI
	- Change logs are in respective patches
	- V2: https://lore.kernel.org/linux-arm-msm/20230713105909.14209-1-quic_anusha@quicinc.com/

Changes in V2:
	- Detailed change logs are added to the respective patches.
	- V1: https://lore.kernel.org/linux-arm-msm/20230614085040.22071-1-quic_anusha@quicinc.com/

---
Anusha Rao (2):
      arm64: dts: qcom: ipq9574: Add common RDP dtsi file
      arm64: dts: qcom: ipq9574: Enable WPS buttons

 arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 147 +++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/ipq9574-rdp418.dts      |  63 +---------
 arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts      |  91 +-------------
 arch/arm64/boot/dts/qcom/ipq9574-rdp449.dts      |  65 +---------
 arch/arm64/boot/dts/qcom/ipq9574-rdp453.dts      |  65 +---------
 arch/arm64/boot/dts/qcom/ipq9574-rdp454.dts      |  66 +---------
 6 files changed, 152 insertions(+), 345 deletions(-)
---
base-commit: 18030226a48de1fbfabf4ae16aaa2695a484254f
change-id: 20230927-common-rdp-52f90fd0fd77

Best regards,

Comments

Kathiravan Thirumoorthy Oct. 11, 2023, 10:32 a.m. UTC | #1 
On 9/27/2023 12:13 PM, Kathiravan Thirumoorthy wrote:
> Some interfaces are common across RDPs. Move the common nodes to
> ipq9574-rdp-common.dtsi like how it is done for IPQ5332. Use rdp specific
> dts file to include interfaces that vary across RDPs. For instance, IPQ9574
> has 4 PCIE controllers. RDP417 enables PCIE0 and PCIE1 whereas RDP433
> enables PCIE1, PCIE2 and PCIE3.
>
> With the introduction of the common RDP DTSI,
> 	- RDP433 gains SPI NOR support
> 	- All the IPQ9574 RDPs gains USB2 and USB3 support
>
> While at it, add support for WPS buttons.
>
> Since Anusha's is busy and can't take up this series right now, I'm
> stepping up to work on this series.


Gentle Reminder...


>
> Changes in V3:
> 	- Reworded the cover letter to indicate the need and advantages
> 	  of common RDP DTSI
> 	- Change logs are in respective patches
> 	- V2: https://lore.kernel.org/linux-arm-msm/20230713105909.14209-1-quic_anusha@quicinc.com/
>
> Changes in V2:
> 	- Detailed change logs are added to the respective patches.
> 	- V1: https://lore.kernel.org/linux-arm-msm/20230614085040.22071-1-quic_anusha@quicinc.com/
>
> ---
> Anusha Rao (2):
>        arm64: dts: qcom: ipq9574: Add common RDP dtsi file
>        arm64: dts: qcom: ipq9574: Enable WPS buttons
>
>   arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi | 147 +++++++++++++++++++++++
>   arch/arm64/boot/dts/qcom/ipq9574-rdp418.dts      |  63 +---------
>   arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts      |  91 +-------------
>   arch/arm64/boot/dts/qcom/ipq9574-rdp449.dts      |  65 +---------
>   arch/arm64/boot/dts/qcom/ipq9574-rdp453.dts      |  65 +---------
>   arch/arm64/boot/dts/qcom/ipq9574-rdp454.dts      |  66 +---------
>   6 files changed, 152 insertions(+), 345 deletions(-)
> ---
> base-commit: 18030226a48de1fbfabf4ae16aaa2695a484254f
> change-id: 20230927-common-rdp-52f90fd0fd77
>
> Best regards,
Bjorn Andersson Oct. 16, 2023, 6:25 p.m. UTC | #2 
On Wed, 27 Sep 2023 12:13:17 +0530, Kathiravan Thirumoorthy wrote:
> Some interfaces are common across RDPs. Move the common nodes to
> ipq9574-rdp-common.dtsi like how it is done for IPQ5332. Use rdp specific
> dts file to include interfaces that vary across RDPs. For instance, IPQ9574
> has 4 PCIE controllers. RDP417 enables PCIE0 and PCIE1 whereas RDP433
> enables PCIE1, PCIE2 and PCIE3.
> 
> With the introduction of the common RDP DTSI,
> 	- RDP433 gains SPI NOR support
> 	- All the IPQ9574 RDPs gains USB2 and USB3 support
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: ipq9574: Add common RDP dtsi file
      commit: 0e8527d076cfb3fa55777a2ece735852fcf3e850
[2/2] arm64: dts: qcom: ipq9574: Enable WPS buttons
      commit: 0e2f2c506f01abcec412ccf91ed39ddfafbda60a

Best regards,