| Message ID | 20230923093037.961232-1-yangjihong1@huawei.com |
|---|---|
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:cae8:0:b0:403:3b70:6f57 with SMTP id r8csp76643vqu;
Sat, 23 Sep 2023 02:34:50 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IGP8OGvXFEzchrGtlh0w/WhnB9MNHSFfOnOwOQiQMl+GsC81qhGLV/FVJZoD29dmVbwdIja
X-Received: by 2002:a17:90a:f3d5:b0:276:696b:1dd9 with SMTP id
ha21-20020a17090af3d500b00276696b1dd9mr7320360pjb.15.1695461690067;
Sat, 23 Sep 2023 02:34:50 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1695461690; cv=none;
d=google.com; s=arc-20160816;
b=eWAQsypIPfxDdwWHnpIVjTYzF2jk2Dp3FJiVcVlp2J6bT9lxc0PFSOZF3+VAbPI6bl
DaL8H4zRnDifvxqZFuHVIZZo+IkXD9AQ7hGC0zZWAfuzwS/fkf3+/NyJ2BfUro9XWzBO
mQsWUXUKEKQibaSuWRfs7pg5ylr4rbVR6yuVTOMChfyV5li6BU/RytSZE/usbozlDTBf
1hmH4APkReKsFO5w6EfEogchLFfRor6VTnNl9dr+J7Wafa+eIQLAZJYX8GQ8Ey5DJnLS
2F6Wc1AiLeliYxmsNefD1PrZSllRD4aPGbG7hUqLEKSZxvhl26nAdcbbH5saWGh5Ppp5
wGYA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=sKlrFnpbL0ehwnMZgJkgIQ8qrV6Ye371VmPSQHFlCA8=;
fh=JXx1mv1fB650HoTkc5GIgpDQ5Ey550GcDyaNZ/s6bYc=;
b=rv3AlrVg85OJTN7sebWPirsIameZ7tnIp7kPJvzYFXpOTGT9hMfZ15KxO0wSy2ogu9
Gpsm05CmtgsQknDmeVmza2GnoqI8jkamWCqcDO6qtVlCtFG16fAoNnPIj7IATNYQWgvj
Hq1bxDfQ6w8kfBgpuAQUo+0yxR9H0GbALRWGv3bn/IAd8ZZpul9+w7iHaT/AuVdwsYL5
TipP2SMHcE7bzai3MzLPdeEU5nAInui0RotrZ9WwBSvZnv1j7Dbtnaxt2Pug/sja9ylR
z44IlAsA6QFzDjdYNLIHT1R8I7obPOF3Pz7w5ahW+9U3B9ewe8hFRgX+1Og7FuqwyGP9
KuHA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:6 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com
Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6])
by mx.google.com with ESMTPS id
w67-20020a636246000000b00565f7784bc9si2735186pgb.186.2023.09.23.02.34.49
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 23 Sep 2023 02:34:50 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:6 as permitted sender)
client-ip=2620:137:e000::3:6;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:6 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by pete.vger.email (Postfix) with ESMTP id 4B3A18029B86;
Sat, 23 Sep 2023 02:32:26 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231258AbjIWJcR (ORCPT <rfc822;chrisfriedt@gmail.com>
+ 29 others); Sat, 23 Sep 2023 05:32:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50088 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230523AbjIWJcQ (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 23 Sep 2023 05:32:16 -0400
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F863C2;
Sat, 23 Sep 2023 02:32:09 -0700 (PDT)
Received: from kwepemm000003.china.huawei.com (unknown [172.30.72.55])
by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Rt3hz2cCgzNng1;
Sat, 23 Sep 2023 17:28:19 +0800 (CST)
Received: from ubuntu2204.huawei.com (10.67.174.22) by
kwepemm000003.china.huawei.com (7.193.23.66) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.31; Sat, 23 Sep 2023 17:32:06 +0800
From: Yang Jihong <yangjihong1@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<mark.rutland@arm.com>, <alexander.shishkin@linux.intel.com>,
<jolsa@kernel.org>, <namhyung@kernel.org>, <irogers@google.com>,
<adrian.hunter@intel.com>, <linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
CC: <yangjihong1@huawei.com>
Subject: [PATCH 0/4] perf bench messaging: Kill child processes when exit
abnormally in process mode
Date: Sat, 23 Sep 2023 09:30:33 +0000
Message-ID: <20230923093037.961232-1-yangjihong1@huawei.com>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=US-ASCII
X-Originating-IP: [10.67.174.22]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
kwepemm000003.china.huawei.com (7.193.23.66)
X-CFilter-Loop: Reflected
X-Spam-Status: No, score=2.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]);
Sat, 23 Sep 2023 02:32:26 -0700 (PDT)
X-Spam-Level: **
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1777820367667259273
X-GMAIL-MSGID: 1777820437277202541
|
| Series |
perf bench messaging: Kill child processes when exit abnormally in process mode
|
|
Message
Yang Jihong
Sept. 23, 2023, 9:30 a.m. UTC
If perf bench messaging in process mode exits abnormally, the forked child
processes does not exit.
The test result is as follows:
# perf bench sched messaging -l 1000000 -g 1 &
[4] 553
# Running 'sched/messaging' benchmark:
# kill -15 533
# ps -ef | grep perf
root 425 371 0 09:11 pts/0 00:00:00 perf bench sched messaging -l 1000000 -g 1
root 426 425 17 09:11 pts/0 00:01:56 perf bench sched messaging -l 1000000 -g 1
root 427 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 428 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 429 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 430 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 431 425 17 09:11 pts/0 00:01:56 perf bench sched messaging -l 1000000 -g 1
root 432 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 433 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 434 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 435 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 436 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 437 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 438 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 439 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 440 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 441 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 442 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 443 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 444 425 17 09:11 pts/0 00:01:54 perf bench sched messaging -l 1000000 -g 1
root 445 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1
root 446 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1
root 447 425 16 09:11 pts/0 00:01:49 perf bench sched messaging -l 1000000 -g 1
root 448 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1
root 449 425 16 09:11 pts/0 00:01:49 perf bench sched messaging -l 1000000 -g 1
root 450 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1
root 451 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1
root 452 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1
root 453 425 16 09:11 pts/0 00:01:49 perf bench sched messaging -l 1000000 -g 1
root 454 425 16 09:11 pts/0 00:01:49 perf bench sched messaging -l 1000000 -g 1
<SNIP>
Capture signals SIGINT and SIGTERM to kill child processes in signal handler
Yang Jihong (4):
perf bench messaging: Fix coding style issues for sched-messaging
perf bench messaging: Factor out create_worker()
perf bench messaging: Store chlid process pid when creating worker for
process mode
perf bench messaging: Kill child processes when exit abnormally in
process mode
tools/perf/bench/sched-messaging.c | 102 ++++++++++++++++++-----------
1 file changed, 64 insertions(+), 38 deletions(-)
Comments
On Sat, Sep 23, 2023 at 2:32 AM Yang Jihong <yangjihong1@huawei.com> wrote: > > If perf bench messaging in process mode exits abnormally, the forked child > processes does not exit. > > The test result is as follows: > > # perf bench sched messaging -l 1000000 -g 1 & > [4] 553 > # Running 'sched/messaging' benchmark: > # kill -15 533 > # ps -ef | grep perf > root 425 371 0 09:11 pts/0 00:00:00 perf bench sched messaging -l 1000000 -g 1 > root 426 425 17 09:11 pts/0 00:01:56 perf bench sched messaging -l 1000000 -g 1 > root 427 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 428 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 429 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 430 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 431 425 17 09:11 pts/0 00:01:56 perf bench sched messaging -l 1000000 -g 1 > root 432 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 433 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 434 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 435 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 436 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 437 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 438 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 439 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 440 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 441 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 442 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 443 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 444 425 17 09:11 pts/0 00:01:54 perf bench sched messaging -l 1000000 -g 1 > root 445 425 17 09:11 pts/0 00:01:55 perf bench sched messaging -l 1000000 -g 1 > root 446 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1 > root 447 425 16 09:11 pts/0 00:01:49 perf bench sched messaging -l 1000000 -g 1 > root 448 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1 > root 449 425 16 09:11 pts/0 00:01:49 perf bench sched messaging -l 1000000 -g 1 > root 450 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1 > root 451 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1 > root 452 425 16 09:11 pts/0 00:01:50 perf bench sched messaging -l 1000000 -g 1 > root 453 425 16 09:11 pts/0 00:01:49 perf bench sched messaging -l 1000000 -g 1 > root 454 425 16 09:11 pts/0 00:01:49 perf bench sched messaging -l 1000000 -g 1 > <SNIP> > > Capture signals SIGINT and SIGTERM to kill child processes in signal handler > > Yang Jihong (4): > perf bench messaging: Fix coding style issues for sched-messaging > perf bench messaging: Factor out create_worker() > perf bench messaging: Store chlid process pid when creating worker for > process mode > perf bench messaging: Kill child processes when exit abnormally in > process mode Applied to perf-tools-next, thanks!