From patchwork Fri Sep 22 14:59:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 14420 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:910f:0:b0:403:3b70:6f57 with SMTP id r15csp44620vqg; Fri, 22 Sep 2023 19:38:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/UhKUh/++KfkdzpfciJcfYr6tSmC9e2rWsNTP5b4fSNxhVslBYOIhZ36mmUMIAEBB6bKU X-Received: by 2002:a25:cc08:0:b0:d80:11df:65f7 with SMTP id l8-20020a25cc08000000b00d8011df65f7mr1128758ybf.7.1695436686371; Fri, 22 Sep 2023 19:38:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695436686; cv=none; d=google.com; s=arc-20160816; b=bAbQhAWaF0pZ5iQccnhQqLJdXCHBQqRL04nYS/V23nOFAyg8YPU9AHRljpO4bhUoNa 9d0dBilyE860jwKqupygymQKt6uiKVjsYtUrF6pCy/L8Tki0HkM7+up8NhNbGNMAnh+2 F7IAjO4jX+F7pRzxFst3KMF0MrrqHxbvexBjb3yBUx/qqy7bV841JnONLetfMNpvEj6m 8q+i/wpS8RDVaOeNRtlngAFk89oP86LF8+z053E8oqv0ifYeP2bnhQrAWw2v/WAojwUa +NhRHA884MuOEp/QXG7AoKAE2lZMCLmiFsVewdCKULsjjeD0rRmvAmyhdWaUpgxvMcZe blBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=veyuo/TIb+MJoFHcP9P3h4NJnq8iJPlYSXkc4ngQJJ0=; fh=0aWa75l3ggud5DfKnSMkPbHWchQ8NS3SOm4/A8cHGl4=; b=RjG7dkHilAIW8apI6RnbVdfaw/6A8lzxqpQm7/kTtKzU8tiqT1dVZYXXTSDq35gbbI ESAZUEQTalGRcaNu0JSvTBQ9mMKvZGP4C9bTLS/IBfAh1VH3ffIN2M7E3irQgdaTfEzO ZqHchDwm77xlEmIlPJv+BIEvHsiPzCXVwLuGau055tniikjbCp1P6+eb4hBPoPgaRKe9 db2m6gRhG5lpZ9Sno6jNa9+RKhpHgNHGzRdeOo3ZwoJbJqjFNBJU7DCl3i77xONTycgv bERh73z3zRjy+cnpkGWs0zUb+KvYdrAj14Tv7dnnGpxHRfAP2ASj2EugoL1+Bmx3T5uR wNnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@xen.org header.s=20200302mail header.b=c5+N52Cy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id v189-20020a6389c6000000b0056a1a149034si4937265pgd.650.2023.09.22.19.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Sep 2023 19:38:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@xen.org header.s=20200302mail header.b=c5+N52Cy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CE3F18343509; Fri, 22 Sep 2023 08:00:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232201AbjIVPAg (ORCPT + 29 others); Fri, 22 Sep 2023 11:00:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232129AbjIVPAe (ORCPT ); Fri, 22 Sep 2023 11:00:34 -0400 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4232E192; Fri, 22 Sep 2023 08:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=veyuo/TIb+MJoFHcP9P3h4NJnq8iJPlYSXkc4ngQJJ0=; b=c5+N52 CyYGcHSGOmitfNtvJwqlwSRLYP5KWFJy05PPN9qKzVeDBlbRFTBggvJzOGxoIpCk8ojaRSltbyz+i Ag0DdZ/7WXEle4e0bpNZUrnKAYs/MBGaiwNahNnZ7a15+/fZs6UqAsHcIrk7sO613i+TzjxwLM8bZ 9Y8yvahNOY0=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qjhdl-00044Z-CN; Fri, 22 Sep 2023 15:00:21 +0000 Received: from ec2-63-33-11-17.eu-west-1.compute.amazonaws.com ([63.33.11.17] helo=REM-PW02S00X.ant.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjhdl-0005y2-3R; Fri, 22 Sep 2023 15:00:21 +0000 From: Paul Durrant To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Paul Durrant , "H. Peter Anvin" , Borislav Petkov , Dave Hansen , David Woodhouse , Ingo Molnar , Paolo Bonzini , Sean Christopherson , Thomas Gleixner , x86@kernel.org Subject: [PATCH v5 00/10] KVM: xen: update shared_info and vcpu_info handling Date: Fri, 22 Sep 2023 14:59:59 +0000 Message-Id: <20230922150009.3319-1-paul@xen.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 22 Sep 2023 08:00:35 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777762983726713800 X-GMAIL-MSGID: 1777794218584510054 From: Paul Durrant The following part of the original cover letter still applies... "Currently we treat the shared_info page as guest memory and the VMM informs KVM of its location using a GFN. However it is not guest memory as such; it's an overlay page. So we pointlessly invalidate and re-cache a mapping to the *same page* of memory every time the guest requests that shared_info be mapped into its address space. Let's avoid doing that by modifying the pfncache code to allow activation using a fixed userspace HVA as well as a GPA." However, this version of the series has dropped the other changes to try to handle the default vcpu_info location directly in KVM. With all the corner cases, it was getting sufficiently complex the functionality is better off staying in the VMM. So, instead of that code, two new patches have been added: "xen: allow vcpu_info to be mapped by fixed HVA" is analogous to the "xen: allow shared_info to be mapped by fixed HVA" patch that has been present from the original version of the series and simply provides an attribute to that vcpu_info can be mapped using a fixed userspace HVA, which is desirable when using one embedded in the shared_info page (since we similarly avoid pointless cache invalidations). "selftests / xen: re-map vcpu_info using HVA rather than GPA" is just a small addition to the 'xen_shinfo_test' selftest to swizzle the vcpu_info mapping to show that there's no functional change. Paul Durrant (10): KVM: pfncache: add a map helper function KVM: pfncache: add a mark-dirty helper KVM: pfncache: add a helper to get the gpa KVM: pfncache: base offset check on khva rather than gpa KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA KVM: xen: allow shared_info to be mapped by fixed HVA KVM: xen: allow vcpu_info to be mapped by fixed HVA KVM: selftests / xen: map shared_info using HVA rather than GFN KVM: selftests / xen: re-map vcpu_info using HVA rather than GPA KVM: xen: advertize the KVM_XEN_HVM_CONFIG_SHARED_INFO_HVA capability Documentation/virt/kvm/api.rst | 53 +++++-- arch/x86/kvm/x86.c | 5 +- arch/x86/kvm/xen.c | 89 ++++++++---- include/linux/kvm_host.h | 43 ++++++ include/linux/kvm_types.h | 3 +- include/uapi/linux/kvm.h | 9 +- .../selftests/kvm/x86_64/xen_shinfo_test.c | 59 ++++++-- virt/kvm/pfncache.c | 129 +++++++++++++----- 8 files changed, 302 insertions(+), 88 deletions(-) --- Cc: "H. Peter Anvin" Cc: Borislav Petkov Cc: Dave Hansen Cc: David Woodhouse Cc: Ingo Molnar Cc: Paolo Bonzini Cc: Sean Christopherson Cc: Thomas Gleixner Cc: x86@kernel.org