From patchwork Wed Sep 20 12:57:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 14267 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp4123923vqi; Wed, 20 Sep 2023 06:05:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBcrpxzvXCbKF9owfBoeOqI1f3FnGmMWl3NnL5KXeK4GcpPQAuof9vBV4jDU4lNwvhW3VO X-Received: by 2002:a05:6a00:1508:b0:68b:e710:ee9c with SMTP id q8-20020a056a00150800b0068be710ee9cmr2550611pfu.19.1695215125775; Wed, 20 Sep 2023 06:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695215125; cv=none; d=google.com; s=arc-20160816; b=NhVRrJmyMINNsbcMSJVtWYehPLdgHsqDMGWm34DUp/D5RwkJe9rqYtAkJpHqzJV/mF 9M1RlTTRDU+57+FGn5TFKYihGrOdpTjrDH2iw3U8KbdbhSkST4x5u8n419PiK9ACX83v g0BoWvqQllSYEKzwuHxK1utofNIqKhRWZzLb6QbG3ujAgFdJy9EXu5T23UoArnSeYVCi JrjvH/A4etxQJeit5DyxjAM92BUFJn/zlK8CwFg3b0ojKoyWHBekuUSSoaSWWq0JJoUr /Be1KhUAcjgVAneOCTBPoU6sa96lqEeZHB+pkYERozBdc79E9QtScDXWWEtiopiCavXC 0eYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=waPXtv/mMX/PlWblC+Wn3kx340P9XKItZy5cQ42cpsM=; fh=TqpoHLAFbloQC5AcWAfLNmB7dsfdfrc+PKhB5PoJGI0=; b=Ar/7NiCK0FYur8y/gfcm/Zfi7eC7tf5bQ2juqEe58ZdksVxuepQtbNis9jWR+oK8QP nLLe9xwWYpKXLeLbs6TCD4VIZ5u/HCh6pmnBu2YjttXLvsqzl4llWLIgXlHwSweB8O7x HocegMQD0L9TCjQqXrT6TzIW/UpoK1ELdSF7Vy/lCOhjsVisJLbZsmNTJCwSdhPP3l28 Q9U08imlk8/cBeotYGvKmaG6XqjEOMsfxqh0FxL3X3x1NPw2HXBRMc8DHw2Wq4lW5MNS i4IlrGN5hqaRpqwvr//LQ1eyI8RPXnwRzMGhLHEaxpssjeoM5L53R9kPP70HR5LqNPDu re9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=fvHJLS0E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id w62-20020a638241000000b00578af6072a6si3604241pgd.462.2023.09.20.06.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 06:05:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=fvHJLS0E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 6F75A82E2947; Wed, 20 Sep 2023 05:58:27 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234769AbjITM6Y (ORCPT + 26 others); Wed, 20 Sep 2023 08:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234794AbjITM6W (ORCPT ); Wed, 20 Sep 2023 08:58:22 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23C24D9 for ; Wed, 20 Sep 2023 05:58:15 -0700 (PDT) Received: from [127.0.1.1] (91-154-35-171.elisa-laajakaista.fi [91.154.35.171]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 553688C1; Wed, 20 Sep 2023 14:56:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1695214595; bh=5q1owDkQaoGqwq0Zdzsk/qGzGO+Yc+ytGxQsqq2luVY=; h=From:Subject:Date:To:Cc:From; b=fvHJLS0E0Tqy1a71xDBQADRFgiE56um5w0FsplxpmiwA9aQtv0r581E1VmcerxWpT aBBlRL3KHCJ4Dh3noO11AECSfCbeKFERfBUtRrlQ7IxYGhENwSBFyTt/A67cOWzcWz S0hNaLx2A+3kd1jr7PeZTpPGqO3TaWPAxeixb5EQ= From: Tomi Valkeinen Subject: [PATCH 0/2] drm: Revert dma-fence annotations from omapdrm and tidss Date: Wed, 20 Sep 2023 15:57:15 +0300 Message-Id: <20230920-dma-fence-annotation-revert-v1-0-7ebf6f7f5bf6@ideasonboard.com> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIACvsCmUC/x3MQQrCMBBG4auUWTuQphCqVxEXY/PHzsKpJEEKp Xd3cPkW3zuooSoa3YaDKr7adDOP8TLQsoq9wJq9KYY4hWsMnN/CBbaAxWzr0h2wS9TOY0o5oMh zSjP54VNRdP/f74/z/AHJjfhKbQAAAA== To: Daniel Vetter Cc: Jyri Sarha , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Francesco Dolcini , Aradhya Bhatia , Tomi Valkeinen X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1203; i=tomi.valkeinen@ideasonboard.com; h=from:subject:message-id; bh=5q1owDkQaoGqwq0Zdzsk/qGzGO+Yc+ytGxQsqq2luVY=; b=owEBbQKS/ZANAwAIAfo9qoy8lh71AcsmYgBlCuxfkEWU98ub7pHgA8iAQXohfVqLaobnR488E eS3ra1zl9OJAjMEAAEIAB0WIQTEOAw+ll79gQef86f6PaqMvJYe9QUCZQrsXwAKCRD6PaqMvJYe 9TlNEACild+chY2IvxEVyN5tomstOEsOd07E3ec8Br5CcX0PdSlXgqiEi4+jlxmX95THoNIKZa0 6c+p4SWHTzNXxXuqHcOhvajCy1L9GRmZUhNLzRBhEAtq9Q8cL7tU34y43kSWK5ab5skSWMFIwZf nGmdRI5CpP9C2DzrwAHeUCF0bIGZyE+ukBb/mJtPIIRtJyBLvG8KorxFVVfh5E/yciWc2r4rFVA yS9k112OunuD/q2AMOBJ2ohujJggc/bgGXv24YJpQrTeSh/yJx2JQJVHtDe0zBY4ZiQjzvW/IsX vzKmFQzWfEI6J6icWv5CIRIMI9v9nGcPeFpKgtM3z5TjikG8z1TBWXy4mcwaIVS1dIwN0eT7uZ5 i9EwBgo9q3aVp8Kw1U6UnCTWAkmWun2htBhsbcnh7sP/T2YP1DNASJ9JnqzFCRi4JUMk9pEwkOo cY77uQ7O1NE7xQwj/rjuP3R7UFAbz/QM0fbtA1j4dizrBszjU10IaSiR6IEi8MyWnsrDNmtg8ZZ zMjYVB5m2OCXgZLACIwGbfiM+Q3zQZw8CSn6YM7Yk5Ohe1t9VI4jzVYaUc7rbySQN+o83uVavJ+ 7yZyOsp0IeA7YKm24+OoGvsJVPSMcvoFo0ufgmnjdgrgyTpXf8Yp977CcNl/oUfjYUa0udSpUGh 1NvShHSK3HZghmQ== X-Developer-Key: i=tomi.valkeinen@ideasonboard.com; a=openpgp; fpr=C4380C3E965EFD81079FF3A7FA3DAA8CBC961EF5 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 20 Sep 2023 05:58:27 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777561895869665033 X-GMAIL-MSGID: 1777561895869665033 Both omapdrm and tidss give quite similar lockdep warnings ever since the "Annotate dma-fence critical section in commit path" patches. I've tried to look at this, but I haven't gotten far with understanding all this, and I feel that I'd need to really dive deep into the details to understand all the locking dependencies relevant here. With some git-log digging, I noticed this: https://patchwork.freedesktop.org/patch/462170/ So maybe the "fix" is just to revert the patches. If yes, great, we can apply the patches here. If not, not so great, and I'll just have to start the diving =). Signed-off-by: Tomi Valkeinen --- Tomi Valkeinen (2): Revert "drm/tidss: Annotate dma-fence critical section in commit path" Revert "drm/omapdrm: Annotate dma-fence critical section in commit path" drivers/gpu/drm/omapdrm/omap_drv.c | 9 ++++----- drivers/gpu/drm/tidss/tidss_kms.c | 4 ---- 2 files changed, 4 insertions(+), 9 deletions(-) --- base-commit: 9fc75c40faa29df14ba16066be6bdfaea9f39ce4 change-id: 20230920-dma-fence-annotation-revert-166d0efab368 Best regards,