From patchwork Fri Sep 15 12:36:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 14045 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp1014981vqi; Fri, 15 Sep 2023 05:44:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmXwwhlwnCVLJZ88gfMhJPbltW3koexx2F1dBlJaDbsRUeSNeUczrV+H9qwCJ9RxAFdzDw X-Received: by 2002:a05:6870:d68f:b0:1d5:a4bd:6028 with SMTP id z15-20020a056870d68f00b001d5a4bd6028mr1533138oap.8.1694781894112; Fri, 15 Sep 2023 05:44:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694781894; cv=none; d=google.com; s=arc-20160816; b=enoLHlTGi6m6sxtlK1hYzA1rAfRXhRD4MPx6VPP9zrPNrHS9IfxJVwdKLbvQ0+y4Pp ZQyHOxpYxINFYmt6i1T67K01mUMhhysEs2bcq2D66w0ZVMu5cFwBDpdo1Ew6xE/ZDbXj 8IwVDg/a2hIKekpMEMG8sk+jL2IuNFJGcuKMlFuQIVumcHGtsRlG2hCngjl2ePbsWV5Y ES0rdPGKauU4raB5IHGKtcmdpZGxm9aa94Vj/0i0SK6KqZms2M3rQUAyclykWl9KGZlb tS/E7EoqMQlYcUx9IzxxKug3oTMinv1UO8EhOKviyVkKOOLK7ubVjegDb2sKeIc1846b bAYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=G3diEPiwWz0eV9RdBqT0QSDzfkViaJU91HAT2xGdv30=; fh=cAATQBhy3suvhTuuVVrdM7Ka/4SAGu7tDT9Mm2RT6ys=; b=HkoZW3mXQ4wLQ9W8xYRjx4MPvUB2L9EW3A8OHgbF8f6L1Dv+GkkLv1Tt4QHhMQVXmM gbRZj0EDENkHNP5gZJKkzQw0toY6qWRoRRSYP0rld/VboBgcN09hzwcMMrq3oJVBsCnI Wssc4ydNYi+zk+OA5C4DGDlcco1mRQ4Mo/maADgW2y/NCQrT5VaA9eIDaF0pcX2VrYpD oR9rxZ5IeXuziqSe8ps5Gwsbaxs7v0xtj0/eYF/eEJc2C2kPTsg7Cn5ed2mVHeQXLRc4 8tdaWiC12VCM+mzEHnex+VhauoEvQ1tZbM8lNuNHX6sJ/9kN0/LTE2l4/nz4CJTBKPmK MiZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id o66-20020a634145000000b00564514df64bsi3215023pga.897.2023.09.15.05.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 05:44:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id CCBF28313D00; Fri, 15 Sep 2023 05:37:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234888AbjIOMg6 (ORCPT + 32 others); Fri, 15 Sep 2023 08:36:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234900AbjIOMg4 (ORCPT ); Fri, 15 Sep 2023 08:36:56 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DA52196 for ; Fri, 15 Sep 2023 05:36:51 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RnD9r66mpzGpmW; Fri, 15 Sep 2023 20:33:04 +0800 (CST) Received: from huawei.com (10.90.53.73) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 15 Sep 2023 20:36:48 +0800 From: Jinjie Ruan To: , , , , , , CC: Subject: [PATCH v2 0/2] static_call: Fix two wild-memory-access bugs in static_call_del_module() Date: Fri, 15 Sep 2023 20:36:03 +0800 Message-ID: <20230915123605.3732345-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.90.53.73] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 15 Sep 2023 05:37:03 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777107619080508036 X-GMAIL-MSGID: 1777107619080508036 In __static_call_init(), any one of the kzalloc fails will cause wild-memory-access when traverse the site and subsequent sites in static_call_del_module(). Changes in v2: - Add a new patch which fix a a similar problem. - Update the commit message and simplify error stack for the first. Jinjie Ruan (2): static_call: Fix a wild-memory-access bug in static_call_del_module() static_call: Fix a wild-memory-access bug when static_call_key_sites(key) is true kernel/static_call_inline.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)