mbox series

[00/10] IFS support for GNR and SRF

Message ID 20230913183348.1349409-1-jithu.joseph@intel.com
Headers
Series IFS support for GNR and SRF |

Message

Jithu Joseph Sept. 13, 2023, 6:33 p.m. UTC 
  This series adds IFS support for newer CPUs like Granite Rapids(GNR)
and Sierra Forest(SRF).

There are changes in the IFS image loading and test flow to support
these new CPUs.

Note to reviewers:
 - patch 01/10 adds a bit definition to arch/x86/.../msr-index.h,
  hence x86 maintainers are cc-d.
 - patch 05/10 modifies an existing tracepoint, cc Steven Rostedt
 - Rest are localized to IFS driver

Jithu Joseph (10):
  platform/x86/intel/ifs: Store IFS generation number
  platform/x86/intel/ifs: Refactor image loading code
  platform/x86/intel/ifs: Image loading for new generations
  platform/x86/intel/ifs: Scan test for new generations
  trace: platform/x86/intel/ifs: Modify scan trace
  platform/x86/intel/ifs: Validate image size
  platform/x86/intel/ifs: Metadata validation for start_chunk
  platform/x86/intel/ifs: Add new CPU support
  platform/x86/intel/ifs: Add new error code
  platform/x86/intel/ifs: ARRAY BIST for Sierra Forest

 arch/x86/include/asm/msr-index.h         |   2 +
 drivers/platform/x86/intel/ifs/ifs.h     |  47 +++++++
 include/trace/events/intel_ifs.h         |  16 +--
 drivers/platform/x86/intel/ifs/core.c    |  14 +-
 drivers/platform/x86/intel/ifs/load.c    | 159 +++++++++++++++++++++--
 drivers/platform/x86/intel/ifs/runtest.c |  68 +++++++++-
 6 files changed, 273 insertions(+), 33 deletions(-)


base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d

Comments

Hans de Goede Sept. 18, 2023, 12:32 p.m. UTC | #1 
Hi Jithu,

On 9/13/23 20:33, Jithu Joseph wrote:
> This series adds IFS support for newer CPUs like Granite Rapids(GNR)
> and Sierra Forest(SRF).
> 
> There are changes in the IFS image loading and test flow to support
> these new CPUs.
> 
> Note to reviewers:
>  - patch 01/10 adds a bit definition to arch/x86/.../msr-index.h,
>   hence x86 maintainers are cc-d.
>  - patch 05/10 modifies an existing tracepoint, cc Steven Rostedt
>  - Rest are localized to IFS driver
> 
> Jithu Joseph (10):
>   platform/x86/intel/ifs: Store IFS generation number
>   platform/x86/intel/ifs: Refactor image loading code
>   platform/x86/intel/ifs: Image loading for new generations
>   platform/x86/intel/ifs: Scan test for new generations
>   trace: platform/x86/intel/ifs: Modify scan trace
>   platform/x86/intel/ifs: Validate image size
>   platform/x86/intel/ifs: Metadata validation for start_chunk
>   platform/x86/intel/ifs: Add new CPU support
>   platform/x86/intel/ifs: Add new error code
>   platform/x86/intel/ifs: ARRAY BIST for Sierra Forest
> 
>  arch/x86/include/asm/msr-index.h         |   2 +
>  drivers/platform/x86/intel/ifs/ifs.h     |  47 +++++++
>  include/trace/events/intel_ifs.h         |  16 +--
>  drivers/platform/x86/intel/ifs/core.c    |  14 +-
>  drivers/platform/x86/intel/ifs/load.c    | 159 +++++++++++++++++++++--
>  drivers/platform/x86/intel/ifs/runtest.c |  68 +++++++++-
>  6 files changed, 273 insertions(+), 33 deletions(-)
> 
> 
> base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d

Thank you for the patch series, please submit a new version addressing
the various review-remarks.

Regards,

Hans
Jithu Joseph Sept. 18, 2023, 4:53 p.m. UTC | #2 
On 9/18/2023 5:32 AM, Hans de Goede wrote:
> Hi Jithu,
> 
> On 9/13/23 20:33, Jithu Joseph wrote:
>> This series adds IFS support for newer CPUs like Granite Rapids(GNR)
>> and Sierra Forest(SRF).
>>
>> There are changes in the IFS image loading and test flow to support
>> these new CPUs.
>>
>> Note to reviewers:
>>  - patch 01/10 adds a bit definition to arch/x86/.../msr-index.h,
>>   hence x86 maintainers are cc-d.
>>  - patch 05/10 modifies an existing tracepoint, cc Steven Rostedt
>>  - Rest are localized to IFS driver
>>
>> Jithu Joseph (10):
>>   platform/x86/intel/ifs: Store IFS generation number
>>   platform/x86/intel/ifs: Refactor image loading code
>>   platform/x86/intel/ifs: Image loading for new generations
>>   platform/x86/intel/ifs: Scan test for new generations
>>   trace: platform/x86/intel/ifs: Modify scan trace
>>   platform/x86/intel/ifs: Validate image size
>>   platform/x86/intel/ifs: Metadata validation for start_chunk
>>   platform/x86/intel/ifs: Add new CPU support
>>   platform/x86/intel/ifs: Add new error code
>>   platform/x86/intel/ifs: ARRAY BIST for Sierra Forest
>>
>>  arch/x86/include/asm/msr-index.h         |   2 +
>>  drivers/platform/x86/intel/ifs/ifs.h     |  47 +++++++
>>  include/trace/events/intel_ifs.h         |  16 +--
>>  drivers/platform/x86/intel/ifs/core.c    |  14 +-
>>  drivers/platform/x86/intel/ifs/load.c    | 159 +++++++++++++++++++++--
>>  drivers/platform/x86/intel/ifs/runtest.c |  68 +++++++++-
>>  6 files changed, 273 insertions(+), 33 deletions(-)
>>
>>
>> base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
> 
> Thank you for the patch series, please submit a new version addressing
> the various review-remarks.
> 

Will do ... Thanks

Jithu