From patchwork Wed Sep 13 15:16:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chengming Zhou X-Patchwork-Id: 13918 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp1168650vqx; Wed, 13 Sep 2023 08:32:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExdWphCycQ+KFfU5W9Jwf0mccqX2CMthZUBxskZYcF+/jzdCXPK5mMYwvzGLUS5odusjZ8 X-Received: by 2002:a17:902:7293:b0:1bb:9f07:5e0 with SMTP id d19-20020a170902729300b001bb9f0705e0mr2627205pll.60.1694619154064; Wed, 13 Sep 2023 08:32:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694619154; cv=none; d=google.com; s=arc-20160816; b=W50LA5Sf8P+drClqe7oNIB4quqYNxbNLBDVBA2A6YCqAcucIrm8j0oXsHHRjFAfvwa cpdGQtfSsjVWFIJgFmF9uC7ccGb9Yo+/kj8+sTJ4ERsYYvsiGfaTvEAwJNRcGRE4d9DJ bGM0HLdFn9AzEKbIq+U+/7fy68K2rgcUoh4c3QHZgv4oMkC4cAewz8MLF7g6j3cW6UbU WzfO5xeIelHgr4oDZjV3HV9HX/uBsGyLr0O5CTbtWXQV1rjtKhjH3jkK65qd8V0wO3NU saY+auHJ9TKWEjnCbJ+hCr6NlDFfYmkzZbBzN3N6daoYg7RLGekgNUdmDFOgZ7K8g+xh I2Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Z8jXCZPukC62KzuUdS/5ci4fhw4YoBdcpJ7VcWMR4Nw=; fh=szS6nKOHqWqdmo+pDmdMHkpBM8bpzBlMJyKfLi9jRHY=; b=GSJGf8kgNyqwTGE5hwQCUrGfksIK8VGuKtEb4LxFsddTX0gkbKB4U8FQjYun0j6oD3 sGgZeiBxWImxurJIAQEBVXh6XZUT5M0t8js6cJubK65I81Ly6twyVa8n3Zk13cQ2THSF Nk42DMusa5m7TEY27xncA6gHiYkZbcM7y8wdaWBPU/z+rsqvG79ee3c9wPOnHExiVQGo j02oGdarRcwSSbpFgAHCJcQL8UYAH4SnqIwA7Rw71y1BedPvWyOuiQxIU+HU/Ij61GzA IPB/kWPjpz6D0wUYbxqAQh/CdQ91V+jIGkbCnvwmzA+kjaqKBerNL+ZEjQebPGcM8t5h JZdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=R6OB3Xsf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id h11-20020a170902f54b00b001b69de1eae1si189170plf.620.2023.09.13.08.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Sep 2023 08:32:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=R6OB3Xsf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 0A4D484A6C48; Wed, 13 Sep 2023 08:17:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241609AbjIMPRC (ORCPT + 36 others); Wed, 13 Sep 2023 11:17:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241634AbjIMPQf (ORCPT ); Wed, 13 Sep 2023 11:16:35 -0400 Received: from out-217.mta1.migadu.com (out-217.mta1.migadu.com [IPv6:2001:41d0:203:375::d9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 567C01BE for ; Wed, 13 Sep 2023 08:16:30 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1694618188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Z8jXCZPukC62KzuUdS/5ci4fhw4YoBdcpJ7VcWMR4Nw=; b=R6OB3Xsf2pprFdH7VzdzY8IkhbUPDPog74gB0aXDQyuHRt5dO8sJNIuWBcvxyL/jOL0Wcg JAJC4tat6BWfqPkW99yfZEBnhOWM3bxjHce+tXxgvyu/OAu/Q1daxg+ZZwcTgwSwfaS989 MTV/iwizyG9Ylw9TS1LLaH3I/VrsCPU= From: chengming.zhou@linux.dev To: axboe@kernel.dk, hch@lst.de, ming.lei@redhat.com, bvanassche@acm.org Cc: kbusch@kernel.org, mst@redhat.com, damien.lemoal@opensource.wdc.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, chengming.zhou@linux.dev, Chengming Zhou Subject: [PATCH v2 0/5] blk-mq: optimize queue_rqs() support Date: Wed, 13 Sep 2023 15:16:11 +0000 Message-Id: <20230913151616.3164338-1-chengming.zhou@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 13 Sep 2023 08:17:23 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776936974385943824 X-GMAIL-MSGID: 1776936974385943824 From: Chengming Zhou Changes in v2: - Drop the patch that fixes a potential race in request timeout from this series. - Rebased on the newest block/for-next branch. The current queue_rqs() support has limitation that it can't work on shared tags queue, which is resolved by patch 1-3. We move the account of active requests to where we really allocate the driver tag. This is clearer and matched with the unaccount side which now happen when we put the driver tag. And we can remove RQF_MQ_INFLIGHT, which was used to avoid double account problem of flush request. Another problem is that the driver that support queue_rqs() has to set inflight request table by itself, which is resolved in patch 4. The last patch add queue_rqs() support for null_blk, which showed 3.6% IOPS improvement in fio/t/io_uring benchmark on my test VM. And we also use it for testing queue_rqs() on shared tags queue. Thanks for review! Chengming Zhou (5): blk-mq: account active requests when get driver tag blk-mq: remove RQF_MQ_INFLIGHT blk-mq: support batched queue_rqs() on shared tags queue blk-mq: update driver tags request table when start request block/null_blk: add queue_rqs() support block/blk-flush.c | 11 ++----- block/blk-mq-debugfs.c | 1 - block/blk-mq.c | 45 +++++++++------------------ block/blk-mq.h | 57 ++++++++++++++++++++++++----------- drivers/block/null_blk/main.c | 20 ++++++++++++ drivers/block/virtio_blk.c | 2 -- drivers/nvme/host/pci.c | 1 - include/linux/blk-mq.h | 2 -- 8 files changed, 76 insertions(+), 63 deletions(-)