From patchwork Tue Sep 12 04:19:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Avichal Rakesh X-Patchwork-Id: 13829 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9ecd:0:b0:3f2:4152:657d with SMTP id t13csp190646vqx; Mon, 11 Sep 2023 22:38:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJN71NhGuPtvrS6pE5SD6Y0psZAVqihA4IZ15E0dJg7QoxVYH9nOZi97VhfGHIuIGHkvrt X-Received: by 2002:a05:6a21:7742:b0:14c:9b51:f1fc with SMTP id bc2-20020a056a21774200b0014c9b51f1fcmr9510946pzc.61.1694497096499; Mon, 11 Sep 2023 22:38:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1694497096; cv=none; d=google.com; s=arc-20160816; b=qxLMskEI62wzKkPnEUWaeUWgU4aifZCgCf0lUiM764B90BxrWNPMAa5PJsp93VOeHH s9FoaWZa+FDdgX/APKTG64RNrRhKf3MZss5vBnRb6npkQQCOX+ik5OabdHVrOhzXV7oK FqrvlrY6Uzg89WbwqPIH6NSQYKnBVmoNv4E0EfkgE8qYT67VEfFxFwabWhiEjLhnVqtH xBgwGxTqiCUyZIVeQZaRhbzDkxpSna12/SEg3Dio73VFMBJDCxNXT18IUyFNLi/WElai 5Ys1Z35XVSlGCDR2TRiz6d3U4Db+qJ6JcsempE1xpNjbperZZUXtAWTacedhXL2bCOKl vjzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=8bQIDDMeJOvnkHBSHpviPM53nQLzWxLl8V8lczrc7P4=; fh=QvX9MTmnaAE6jfh4r/Rtm06n4Sfej0NUOiMyXoms1KM=; b=dJlNWXAelYrEAo6XfOQDukR4eDv7e5ISgPk6QkZ5MABF7v7QxkUXVN5cm69FF6/0pf XY2XOGF9Bjz7RseUd4RQW4i8GzIH7iwPO51fd0gDT2zwIbFkfKEEF0xk4daC0bauNi2h HCrNgg4hR1O9eDAX39PcUrhXNRfUCARE5QvlJIKLn9vRuOqkR1+QhBcbapgnr2AXP+uy N+MKo8gtYimjUItZU7ei17zEfH51Sw9WcnAkMZtAaVKeXYsjKwqJmz0HsGrMzcQsl+hP vAXakvLB4C3yRlLswrDZ0Sym8SkTTh293J8BE/a9Oh1Mbilvlxm4+MnnVX/IucWz3w7q /Q6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=vcnTIcnQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id c5-20020a170902d48500b001b8698149fbsi7357069plg.477.2023.09.11.22.38.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Sep 2023 22:38:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=vcnTIcnQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 1789980CCD0F; Mon, 11 Sep 2023 21:50:54 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231847AbjILETi (ORCPT + 40 others); Tue, 12 Sep 2023 00:19:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231672AbjILETf (ORCPT ); Tue, 12 Sep 2023 00:19:35 -0400 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C53CD1BE for ; Mon, 11 Sep 2023 21:19:30 -0700 (PDT) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d78452de9cbso4816975276.2 for ; Mon, 11 Sep 2023 21:19:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694492369; x=1695097169; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=8bQIDDMeJOvnkHBSHpviPM53nQLzWxLl8V8lczrc7P4=; b=vcnTIcnQs09CNgXh4Yr6/iN9kRK7a4j413YEvYescMwBWS9B3hAvMO+CFtRe4v+9l2 z7WqqwAV+bvOU96/UrJUHerBWEEGwU4BpFON14UL1cpNe48hpa9I/0wVa+VKamDTpqW7 M8dAakBs4mbXcSniTkb+WzxqfH6jMVMRzui2umdP2I27/CGN9LWM80eY1wSRkPXo507N YxlTv2J+jMS6XbSMBDv/aESh9Ch6PAqC8RBhBT/IxHPDvDk7AiEMzZLspa+KSQI4aPSx G+rkcJgANtRBeCu4mYPSP2vmXo3xnK4Q5MIxnsYFUpSRZQsqMEF3er9vK1XtbXECEhbx p3XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694492369; x=1695097169; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=8bQIDDMeJOvnkHBSHpviPM53nQLzWxLl8V8lczrc7P4=; b=Xx/jcACaN5RYSZDOrTXYlhxfxMhgkFVGcR4fSjsvCA0MVvkZBqKR2SsqO3wkXWZtc+ wmuuGycSzrdwfxKWtk6NiOSHtA5PW53VXFnGemkHwjJ4bB4mVbG/bAafLJ9UmOXsUMEc Gi/MKRJ4Hh02P1B/xl4micJppTEghdM8DSddqMDMB5BRrc7hL9kIVzQY7p3+SE/50mTp kf116DeucEuLMKVkHuY5aFmY9j1PRc48cEFywHPfGw1pbxi4+48TAPHMciWP1jLORdjq iO6CmtqvngeUVRCE849vU/2gYYRaB+i5cQd3fiKk0KjpVe/WNK4DNxJlrh9GoiRzNdZj 0GVg== X-Gm-Message-State: AOJu0YwZxtW63G6DrmoxNmMTpDkjd4pccX2BeuHni6Hy6VqxTowj68Hs t/Ey3iHnou0yr9mLvI6IOIzJbbR8uJUQ X-Received: from hi-h2o-specialist.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:3cef]) (user=arakesh job=sendgmr) by 2002:a5b:1cb:0:b0:d77:ff06:b58b with SMTP id f11-20020a5b01cb000000b00d77ff06b58bmr258526ybp.10.1694492369636; Mon, 11 Sep 2023 21:19:29 -0700 (PDT) Date: Mon, 11 Sep 2023 21:19:08 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.283.g2d96d420d3-goog Message-ID: <20230912041910.726442-1-arakesh@google.com> Subject: [PATCH v1 0/2] usb: gadget: uvc: stability fixes when stopping streams From: Avichal Rakesh To: Laurent Pinchart , Daniel Scally , Greg Kroah-Hartman , Michael Grzeschik Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Avichal Rakesh Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 11 Sep 2023 21:50:54 -0700 (PDT) X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776808987254092157 X-GMAIL-MSGID: 1776808987254092157 We have been seeing two main bugs when stopping stream: 1. attempting to queue usb_requests on a disabled usb endpoint, and 2. use-after-free problems for inflight requests Avichal Rakesh (2): usb: gadget: uvc: prevent use of disabled endpoint usb: gadget: uvc: prevent de-allocating inflight usb_requests drivers/usb/gadget/function/f_uvc.c | 11 ++++---- drivers/usb/gadget/function/f_uvc.h | 2 +- drivers/usb/gadget/function/uvc.h | 5 +++- drivers/usb/gadget/function/uvc_v4l2.c | 21 ++++++++++++--- drivers/usb/gadget/function/uvc_video.c | 34 +++++++++++++++++++++++-- 5 files changed, 60 insertions(+), 13 deletions(-) --- 2.42.0.283.g2d96d420d3-goog