From patchwork Thu Aug 31 15:29:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 13770 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c792:0:b0:3f2:4152:657d with SMTP id b18csp461745vqu; Thu, 31 Aug 2023 12:48:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEV83GXlkCmeOzpC0dXv8bv+4XY5XlD+uWaEQyH4Ikc3pEcmo/T25jMGfHp8glZyjtYddHN X-Received: by 2002:a05:6a00:1397:b0:67a:9208:87a with SMTP id t23-20020a056a00139700b0067a9208087amr660438pfg.23.1693511313353; Thu, 31 Aug 2023 12:48:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1693511313; cv=none; d=google.com; s=arc-20160816; b=AbgmXFiucsc591aYMQ3XRa4+h8IZrceHAGwhwv+mlCQexsgBGnBUbhGO/pWpczzTev b/Px1UcPwrciKMKK8u/gq8ZUglf77ix88ilAiYQiSQKPDpOOONadg+WjR0lB3odbNcA2 hLlkZMqkUHwL3ytJbXYGhrux6dfXwgpxny1O12POAr8OPXXf/odAJlkWjj3KFJcwmYBz R6FgGAbSOyTxKYYX9RzYhUfz4CjJmJqRFYkhDHUhLqvcB/QUeAsWh0yulsAAxrHuH0LO x8lRF3226c8ZlkG0j+UGav0UD2b1UqHrk7GGknJpehFjfCr129P/Ofoy2FLtgZj83eFF I56g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=e9nWEhKopxHLZLMm7KOqmsXmgPnL12b6rc9qP+CbPJE=; fh=KUGLwWO1A75Jlv1C0BRtPTlRlsdZfeW4F3lkujEsvO4=; b=zWBiIjgGJy5Ol7o3GohC3AUS/hCvTdOsbhYPQkKuEz/Ymt+i6pbiCvOEx0dEAypqJD /LQld30rywHqcv1vMiJk/NyRJzLmHqYro+nXYPYN31Gk/B5vlpSNV41u+R0TnUezEs+m YfpEYZA8eimZGQ46Sw5zNafT8GozUNFUd5L6HWEl6hv+5bQMqdbEr//ky7XBpbvBPvnP LuM3A5qXsiJjrSJfM3EGY8E5bxR2giuKL/yDgZ6H8YT+8dtxpGm9RdN3H8/vdk/4IyXD FtHAgHvTzZucpsU+hhO3aESRg0fGAV43GweSaNqgQ3Wfja6g+1F5/W2MWi4jqZebR4HU XdBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=j39Ra7An; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ch13-20020a056a00288d00b0068a4b8c4ea4si1627525pfb.113.2023.08.31.12.48.17; Thu, 31 Aug 2023 12:48:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=j39Ra7An; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346600AbjHaP3S (ORCPT + 99 others); Thu, 31 Aug 2023 11:29:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345699AbjHaP3R (ORCPT ); Thu, 31 Aug 2023 11:29:17 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25798E4C for ; Thu, 31 Aug 2023 08:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=e9nWEhKopxHLZLMm7KOqmsXmgPnL12b6rc9qP+CbPJE=; b=j39Ra7AnnhQJeTbi0Utj7IBM1P tMkrUWKvF23YcFd/5nm+te4asEQOiSjzsjlMuQS86GIZGNPH6le0sfUdOuAUIcKTx+02umfmqr+uU /B6ukx1r/xljQClCZlh2rhNHTEtACjKDKY/9NfL9C6Rgsyj7VjQP1aujrtrwffyMmPxrD2c+JN3aM gJHoOORy2rbqls6HbySLj5Gxnh9oA73EEA+DGnC3gqUTBK8UM/EnXiy172TWfXCpPpNjRtakf/xFz ft1Y2wcmxLPhwB/nwtUNqVC7aauzuFBSki51Wz7s+nazimOTUWUsA1KpCVxoHlr7Ta0ozOZxUeR46 RrpdueEg==; Received: from [191.193.15.45] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1qbjba-000VNg-3F; Thu, 31 Aug 2023 17:29:10 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, pierre-eric.pelloux-prayer@amd.com, =?utf-8?b?J01hcmVrIE9sxaHDoWsn?= , =?utf-8?q?Andr=C3=A9_A?= =?utf-8?q?lmeida?= Subject: [PATCH v3 0/2] Merge all debug module parameters Date: Thu, 31 Aug 2023 12:29:01 -0300 Message-ID: <20230831152903.521404-1-andrealmeid@igalia.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775775318470628920 X-GMAIL-MSGID: 1775775318470628920 As suggested by Christian at [0], this patchset merges all debug modules parameters and creates a new one for disabling soft recovery: > Maybe we can overload the amdgpu_gpu_recovery module option with this. > Or even better merge all the developer module parameter into a > amdgpu_debug option. This way it should be pretty obvious that this > isn't meant to be used by someone who doesn't know how to use it. [0] https://lore.kernel.org/dri-devel/55f69184-1aa2-55d6-4a10-1560d75c7324@amd.com/ Changelog: - move enum from include/amd_shared.h to amdgpu/amdgpu_drv.c v2: https://lore.kernel.org/lkml/20230830220808.421935-1-andrealmeid@igalia.com/ - drop old module params - use BIT() macros - replace global var with adev-> vars v1: https://lore.kernel.org/lkml/20230824162505.173399-1-andrealmeid@igalia.com/ André Almeida (2): drm/amdgpu: Merge debug module parameters drm/amdgpu: Create an option to disable soft recovery drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 63 ++++++++++++++++-------- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 2 +- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 6 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 2 +- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- 8 files changed, 58 insertions(+), 26 deletions(-)