From patchwork Tue Aug 15 15:56:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andre Przywara X-Patchwork-Id: 13637 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:3f2:4152:657d with SMTP id x8csp544988vqo; Tue, 15 Aug 2023 09:28:12 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHU1ZR9IKi3Xj9t675XurhYIVzIiuFn8idnxib6rNx93Oy4bj+ZSJEwaQVwLWR8pf8nkfIS X-Received: by 2002:a05:6a00:1516:b0:661:4a00:1ea5 with SMTP id q22-20020a056a00151600b006614a001ea5mr13110751pfu.20.1692116892164; Tue, 15 Aug 2023 09:28:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692116892; cv=none; d=google.com; s=arc-20160816; b=IWug6HyWwvbAkmyVaQrQqsW6F7nb6pU321iiz8d0Tdnxdag/LZpO/lVuoLWnLNxwuh 4gN/Stbd20S3Xln55FX7x+Ess6O39eZM9Q+iqNGhiYm+B9okmXPfYp1otb7GOUSq7Os+ ojwMgH0MR6JFXlhTQaxwd64Blkw2m4ynXZjBiMfQkrInA2DHLcG99CmyvM7HCcTVsTJg S2IdVdxDeJiqIbYAZg39JBF5UU/tLqFMZOeObwnEOaYDsI0NUGPxX80FuB9utCxptVGu AOYo8emCwYeLXpuZIKrjnR4XMwo3XtS298nDxSwUTBVECDHsn9qRGmkG6aCj9UzDTtWL 9kLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=GMvkEZgwhhmv4VQRxsAkFb8OppYzF3rA+AfaL3F7fgc=; fh=UBrbDth7y5oMgl8brvefl9eZ6RQ3QXA6llOLfOqxpDM=; b=I9WdscOZby+mWV6DdzL6E2eVvrlKkbiePewEBq1MWxeTRV3eRR5znDrFVB6TsDF5PG Tdmr+Kctj2BbQFRPa+0OSx9V4vS7S6l3J9NHI0GuzT3lol6QzFu+Vp8QZtqL0WrHzsvB +xHb4i8sImC5aJL9gqoV0S72S5OD56gShuvzOdC/pA3WJwuqZv5y696lJGaqzUMIRxAt 812rtr52JcJmNl5dh3Q2ZS0LFZR4AU/z2Jg4GDdXItPU8n93lT+szi2puh+96+t+9ob2 VLk1x4ezC7I5tNQxbzOpQV7BUhPsXZ2WPsTFFQ7VEbDqT+K7vosxFvnebo90N5uk9ePH DpCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y18-20020a056a00191200b006724753efe8si9936178pfi.192.2023.08.15.09.27.55; Tue, 15 Aug 2023 09:28:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238377AbjHOP5F (ORCPT + 99 others); Tue, 15 Aug 2023 11:57:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238374AbjHOP4d (ORCPT ); Tue, 15 Aug 2023 11:56:33 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 38E15172A; Tue, 15 Aug 2023 08:56:30 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 231801063; Tue, 15 Aug 2023 08:57:12 -0700 (PDT) Received: from donnerap.arm.com (donnerap.manchester.arm.com [10.32.100.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C6E533F6C4; Tue, 15 Aug 2023 08:56:28 -0700 (PDT) From: Andre Przywara To: Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] selftests: cachestat: fix build and run on older kernels Date: Tue, 15 Aug 2023 16:56:09 +0100 Message-Id: <20230815155612.2535947-1-andre.przywara@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774313161789770834 X-GMAIL-MSGID: 1774313161789770834 I ran all kernel selftests on some test machine, and stumbled upon cachestat failing (among others). Those patches fix the cachestat test compilation and run on older kernels. Also I found that the but-last test (on a normal file) fails when run on a tmpfs mounted directory, as it happens on an initramfs-only system, or when the current directory happens to be /dev/shm or /tmp: # Create/open tmpfilecachestat # Cachestat call returned 0 # Using cachestat: Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recently Evicted: 0 # Cachestat call (after fsync) returned 0 # Using cachestat: Cached: 4, Dirty: 4, Writeback: 0, Evicted: 0, Recently Evicted: 0 # Number of dirty should be zero after fsync. not ok 6 cachestat fails with normal file That same test binary succeeds on the same machine right afterwards if the current directory is changed to an ext4 filesystem. I don't really know if this is expected, and whether we should try to figure out if the test file lives on a tmpfs filesystem, or whether the test itself is not strict enough, and requires more "flushing" (drop_caches?) to cover tmpfs directories as well. Any ideas how to fix this would be appreciated. Cheers, Andre Andre Przywara (3): selftests: cachestat: properly link in librt selftests: cachestat: use proper syscall number macro selftests: cachestat: test for cachestat availability tools/testing/selftests/cachestat/Makefile | 2 +- .../selftests/cachestat/test_cachestat.c | 29 +++++++++++++++---- 2 files changed, 25 insertions(+), 6 deletions(-)