From patchwork Tue Aug 15 01:41:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 13634 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a888:0:b0:3f2:4152:657d with SMTP id x8csp295316vqo; Tue, 15 Aug 2023 01:53:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHk/qe5mtEzhGD2bsS4gEL814UxxhNdqRiDc9lEDdjt/jLAwflagmGgj2JZFTxl9eLe8piF X-Received: by 2002:a17:906:9c1:b0:99d:acdb:bad6 with SMTP id r1-20020a17090609c100b0099dacdbbad6mr3398166eje.77.1692089623416; Tue, 15 Aug 2023 01:53:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692089623; cv=none; d=google.com; s=arc-20160816; b=Ffn4nuKF+fDtZLZSI/EyN8a2HeR4ijDzq9g3I3tiICkuE1xHLc9L7NjsVa9bFshR9U 5MU0uUwQbaRhXIcs5g3L8RdsCmEL98GWrIZL18kFwB4FFl5Ld/n1w5Rp+iJyfXl+XwHe +aly2Cw4DDVv2IP9SY9uhyo4M3RapVwn011Drh5aXSrEZF+6iTc6A6862u8zT4vmlC1I YOFkELIbZ9LyvezyorQucX93PDVt8tIcgl8ZYrL2JAb5Jcqc0DBSkA9hjQrCi4K6qFVp boDwRh20xoWdpqSxr6xGly00m2ddOtopNy3Xlj7qp1EZje+ZUPjuPNbXJgeTosisv/kf btqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ofN3Ahs01bm5TnK+GT1fB1zzoCIbQloiC8QqC634RZw=; fh=wTguGu9iHUye/+4XPiOZzVDD/C/LKyDnbGOrb/C9kEo=; b=U9pa81R5WbGmjlwBm+lJ2yRtbhcTg2MHZQ0CUVfZQR4o0IGLbUPWLsnhOFVXrQ6DNt B36fePMHfAFngn1lIWH6UEkptTzHyuKf9nM1+6+BIRBmSj8akyXSCM2cUcBNcBQzMRhT sJSZVzt3MX/l9fDzh57h0ViB+YHBKts0IGglT7AeSBo6564AoR+MFe3gStoaOKB2nQ1K waxMeTVwR60Uz4b/Xlwilhme+9Nbd3FdH/vOTlgikUYUea5j3n87ZI+g3Vq/l2dYrn+r O2fT+2bwDiJeCbOTWzxu/zGRamG3DAFDLn6QPCwdRGVrsFLwAkLu9L/nahpVo+5vS6Jb ZESg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m13-20020a170906234d00b00993a68a3af6si8924767eja.511.2023.08.15.01.53.17; Tue, 15 Aug 2023 01:53:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234001AbjHOBpe (ORCPT + 99 others); Mon, 14 Aug 2023 21:45:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233956AbjHOBpE (ORCPT ); Mon, 14 Aug 2023 21:45:04 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC455170B; Mon, 14 Aug 2023 18:45:03 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RPvGN4lC6z4f3mWL; Tue, 15 Aug 2023 09:45:00 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgA3x6mb2NpkdnTyAg--.15945S4; Tue, 15 Aug 2023 09:45:00 +0800 (CST) From: Yu Kuai To: tj@kernel.org, josef@toxicpanda.com, axboe@kernel.dk, yukuai3@huawei.com, mkoutny@suse.com Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH -next 0/4] cleanup and fixes for 'carryover_ios/bytes' Date: Tue, 15 Aug 2023 09:41:19 +0800 Message-Id: <20230815014123.368929-1-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CM-TRANSID: gCh0CgA3x6mb2NpkdnTyAg--.15945S4 X-Coremail-Antispam: 1UD129KBjvdXoW7GFWrKry5ZFWfWw4kGF4xXrb_yoWfJwb_uF ykta48CF1UJa4IyFWxAry3A34rWw4jqw1qg3WqkFW7Zr9rZrn8Jr1fJF4qqFsxua1DCrs7 trs8Xr4xAr1aqjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_tr0E3s1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFyl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rWUJVWrZr1UMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0J UdHUDUUUUU= X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774284568686014572 X-GMAIL-MSGID: 1774284568686014572 From: Yu Kuai Patch 1 print signed value for 'carryover_ios/bytes' to user. Patch 2 fix that comparation ”unsigned value < negative value“ will pass, causing that io won't be throttled in the silce. Patch 3,4 fix that 'carryover_ios/bytes' is not cleared while 'io/bytes_disp' is cleared, causing that throttle is not accurate. Yu Kuai (4): blk-throttle: print signed value 'carryover_bytes/ios' for user blk-throttle: fix wrong comparation while 'carryover_ios/bytes' is negative blk-throttle: use calculate_io/bytes_allowed() for throtl_trim_slice() blk-throttle: consider 'carryover_ios/bytes' in throtl_trim_slice() block/blk-throttle.c | 105 +++++++++++++++++++++---------------------- block/blk-throttle.h | 4 +- 2 files changed, 54 insertions(+), 55 deletions(-)