From patchwork Thu Aug 10 19:23:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 13476 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b824:0:b0:3f2:4152:657d with SMTP id z4csp638526vqi; Thu, 10 Aug 2023 12:30:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEItME9hbDBnoOVt2E4NwCYs6fqal8P24afYIN7dgzTgn98yO37akvZV0mS/Tn5SN5sK+4x X-Received: by 2002:a17:906:9bc8:b0:977:ecff:3367 with SMTP id de8-20020a1709069bc800b00977ecff3367mr3206505ejc.40.1691695843509; Thu, 10 Aug 2023 12:30:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691695843; cv=none; d=google.com; s=arc-20160816; b=mQEnlDZgYR9yprfVNre0toabcElH9rjS1BOGiyrok2Fie+0AR97TzIwWkGkcLsMLbP squkHBjh6ZGRjvPQF0nrfZdTdIWwrjqWSTxOhN+OG1RIKGVEhZ+/tUEKqK39CH/QJrKS qJVXTscec8ls9KpBje2TR7Ys9l79EAMippCMe1aSa0nLFC71vuyo9KH3sqS7jwDJAHjp 8Q326pOhHIbkEQznY2e6OXRJ6twpuIPOS62pfV08P6JfWiTrAKdqWN+U3UGqpqj/BOSq mRBO753wAfu3YXzJ2qfTPY+3FM+OEy6MdOWRWeF6wwmItdQm+6zOSFgBTvgae5Ak3hGy SiIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=X3u49tpdY4rOV9dSlCIkVQr0V84jvH6SM3HD26dSfQE=; fh=4drWZfXh6M/zU5TbzJpAHkpGJffjB2tpWVKmXKr8SAQ=; b=TNlGieL773YWGJ7p0GDtVM6QkMZVdFxMw5vCG5KpXUfqAu6I8b8e6LURLwKPyV7FEG x8NX/PCF6T6OglGg9RLAFn/RCrk4jqiqC++VBszlpSLfmJaFJKJk2OfzmA+t1A5GZxrh rWFgqwzJykDnjBCUtWqmZy9m2nfPGj+wdAt6DvL9MgCPI6Icet5zyePaBdm1b8kFV+Z9 yBURCaX71niLGstGdlx26PJnGYx74ZzYqMg3u9Rmf/d/dGw4DEN5VxY0QQRRcbDfhWsU c+WjRa0JAm8539UWKUYsfaoV5ZRrHgT+waSEjDf6kTzfl7Yu7CtMlcN18arT2WAVORIA zm6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=i6dJSdfy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i18-20020a170906115200b0099cb00485b0si2009205eja.498.2023.08.10.12.30.18; Thu, 10 Aug 2023 12:30:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=i6dJSdfy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235938AbjHJTXm (ORCPT + 99 others); Thu, 10 Aug 2023 15:23:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235633AbjHJTXl (ORCPT ); Thu, 10 Aug 2023 15:23:41 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F342690 for ; Thu, 10 Aug 2023 12:23:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=X3u49tpdY4rOV9dSlCIkVQr0V84jvH6SM3HD26dSfQE=; b=i6dJSdfyzBQV0GLzrx6TLIHktO yH/lzXsJ9dHB4QtkdbIToajfZC7vYNv50Raj5ns+p76LlJN8vsuJyDx/GlGBiZULzS2HXTzcO/++I UfLfnQDMEj5nfyjl6Iw2LtgRpCRBcas91egZHoeAZW9V3SG7UQzx3wX4orjiW3SHYryvvT8SOtN6E P3M6514cINffFmFrlMSUltzN4w20ig6Bzods0zg6Wy0espZ4+Ua+OTljQxk0hbsNPPSog/2UFwo53 3MzlApL7HEGBbB8Y6gLmgyPnWJ0/G8dWDuL1Ux4DUCpML6NQkLLWc2+vErC+x8GRiIEPs8uNFy4im GItUkjWw==; Received: from [191.193.179.209] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1qUBFv-00Gp5H-C4; Thu, 10 Aug 2023 21:23:35 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, pierre-eric.pelloux-prayer@amd.com, =?utf-8?b?J01hcmVrIE9sxaHDoWsn?= , Samuel Pitoiset , Bas Nieuwenhuizen , =?utf-8?q?Timur_Krist=C3=B3f?= , =?utf-8?q?Andr?= =?utf-8?q?=C3=A9_Almeida?= Subject: [RESEND v3 0/5] drm/amdgpu: Add new reset option and rework coredump Date: Thu, 10 Aug 2023 16:23:25 -0300 Message-ID: <20230810192330.198326-1-andrealmeid@igalia.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773871660720924705 X-GMAIL-MSGID: 1773871660720924705 Hi, The goal of this patchset is to improve debugging device resets on amdgpu. The first patch creates a new module parameter to disable soft recoveries, ensuring every recovery go through the full device reset, making easier to generate resets from userspace tools like [0] and [1]. This is important to validate how the stack behaves on resets, from end-to-end. The last patches are a rework to alloc devcoredump dynamically and to move it to a better source file. I have dropped the patches that add more information to devcoredump for now, until I figure out a better way to do so, like storing the IB address in the fence. Thanks, André [0] https://gitlab.freedesktop.org/andrealmeid/gpu-timeout [1] https://github.com/andrealmeid/vulkan-triangle-v1 Changelog: v2: https://lore.kernel.org/dri-devel/20230713213242.680944-1-andrealmeid@igalia.com/ - Drop the IB and ring patch - Drop patch that limited information from kernel threads - Add patch to move coredump to amdgpu_reset v1: https://lore.kernel.org/dri-devel/20230711213501.526237-1-andrealmeid@igalia.com/ - Drop "Mark contexts guilty for causing soft recoveries" patch - Use GFP_NOWAIT for devcoredump allocation André Almeida (5): drm/amdgpu: Create a module param to disable soft recovery drm/amdgpu: Allocate coredump memory in a nonblocking way drm/amdgpu: Rework coredump to use memory dynamically drm/amdgpu: Move coredump code to amdgpu_reset file drm/amdgpu: Create version number for coredumps drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 67 +----------------- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 9 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 79 ++++++++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 14 ++++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 6 +- 6 files changed, 111 insertions(+), 70 deletions(-)