mbox series

[v3,0/3] arm64: dts: ti: k3-j784s4: Add bootph-all property

Message ID 20230810184302.3097829-1-a-nandan@ti.com
Headers
Series arm64: dts: ti: k3-j784s4: Add bootph-all property |

Message

Apurva Nandan Aug. 10, 2023, 6:42 p.m. UTC 
  bootph-all phase tag was added to dt-schema (dtschema/schemas/bootph.yaml)
to overcome u-boot dts challenges.

Add bootph-all property for all the nodes that are used in the SPL stage
along with later boot stages.

This series will be ported to the u-boot k3-j784s4 support patch series
for syncing, and was requested in its review process:
https://lore.kernel.org/u-boot/20230321155227.GV8135@bill-the-cat/

v3: Changelog:
1) Changed all the bootph-pre-ram to bootph-all, as only
   secure_proxy_mcu and secure_proxy_sa3 are exclusively used by R5 SPL.
   Rest of the nodes are also used by later boot stages.
2) Merged SoC dtsi changes in single patch.
3) Moved cbass_main and cbass_mcu_wkup bootph-all to k3-j784s4.dtsi

Link to v2: 
https://lore.kernel.org/lkml/20230807185645.128751-1-a-nandan@ti.com/#t

v2 Changelog :
1) Added k3-am69-sk.dts bootph-pre-ram patch
2) Added bootph-pre-ram for wkup_pmx0 and ospi0
3) Added bootph-pre-ram for mcu_timer1

Link to v1:
https://lore.kernel.org/linux-arm-kernel/20230806164838.18088-1-a-nandan@ti.com/

Apurva Nandan (3):
  arm64: dts: ti: k3-j784s4: Add bootph-all property
  arm64: dts: ti: k3-j784s4-evm: Add bootph-all property
  arm64: dts: ti: k3-am69-sk: Add bootph-all property

 arch/arm64/boot/dts/ti/k3-am69-sk.dts         | 13 ++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts      | 25 +++++++++++++++++++
 arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi    |  2 ++
 .../boot/dts/ti/k3-j784s4-mcu-wakeup.dtsi     |  9 +++++++
 arch/arm64/boot/dts/ti/k3-j784s4.dtsi         |  2 ++
 5 files changed, 51 insertions(+)

Comments

Nishanth Menon Aug. 10, 2023, 6:52 p.m. UTC | #1 
On 00:12-20230811, Apurva Nandan wrote:
> bootph-all phase tag was added to dt-schema (dtschema/schemas/bootph.yaml)
> to overcome u-boot dts challenges.
> 
> Add bootph-all property for all the nodes that are used in the SPL stage
> along with later boot stages.
> 
> This series will be ported to the u-boot k3-j784s4 support patch series
> for syncing, and was requested in its review process:
> https://lore.kernel.org/u-boot/20230321155227.GV8135@bill-the-cat/
> 
> v3: Changelog:
> 1) Changed all the bootph-pre-ram to bootph-all, as only
>    secure_proxy_mcu and secure_proxy_sa3 are exclusively used by R5 SPL.
>    Rest of the nodes are also used by later boot stages.
> 2) Merged SoC dtsi changes in single patch.
> 3) Moved cbass_main and cbass_mcu_wkup bootph-all to k3-j784s4.dtsi
[...]

> Apurva Nandan (3):
>   arm64: dts: ti: k3-j784s4: Add bootph-all property
>   arm64: dts: ti: k3-j784s4-evm: Add bootph-all property
>   arm64: dts: ti: k3-am69-sk: Add bootph-all property


Follow https://lore.kernel.org/all/48b554aef75d11e6ad2ef7d21f22accb35432112.1683034376.git.michal.simek@amd.com/
for example of proper commit message and subject line.

The patch content actually is easy to read since it is adding
bootph-all property - but we do have a few exceptions. Commit message
should explain the rational of the choices made. For example, you
probably need to use secure_proxy_sa3 to talk with tifs in-order to
boot and that is a pre-ram property and so on..

So, nice refresh in the right direction, but a bit more work to do.
Thanks for handling am69-sk :)..