mbox series

[v3,0/3] few fixes for synthetic trace events

Message ID 20230810060538.1350348-1-svens@linux.ibm.com
Headers
Series few fixes for synthetic trace events |

Message

Sven Schnelle Aug. 10, 2023, 6:05 a.m. UTC 
  Hi Steven,

I'm now sending these patches in one patchset, because the second patch
has a dependeny on the union vs. cast fix.

Changes in v3:
- remove superfluous struct around union trace_synth_field

Changes in v2:
- cosmetic changes
- add struct trace_dynamic_info to include/linux/trace_events.h

Sven Schnelle (3):
  tracing/synthetic: use union instead of casts
  tracing/synthetic: skip first entry for stack traces
  tracing/synthetic: allocate one additional element for size

 include/linux/trace_events.h      |  11 ++++
 kernel/trace/trace.h              |   8 +++
 kernel/trace/trace_events_synth.c | 103 ++++++++++++------------------
 3 files changed, 60 insertions(+), 62 deletions(-)

Comments

Steven Rostedt Aug. 16, 2023, 3:11 p.m. UTC | #1 
On Wed, 16 Aug 2023 11:08:52 +0200
Sven Schnelle <svens@linux.ibm.com> wrote:

> Sven Schnelle <svens@linux.ibm.com> writes:
> 
> > Hi Steven,
> >
> > I'm now sending these patches in one patchset, because the second patch
> > has a dependeny on the union vs. cast fix.
> >
> > Changes in v3:
> > - remove superfluous struct around union trace_synth_field
> >
> > Changes in v2:
> > - cosmetic changes
> > - add struct trace_dynamic_info to include/linux/trace_events.h
> >
> > Sven Schnelle (3):
> >   tracing/synthetic: use union instead of casts
> >   tracing/synthetic: skip first entry for stack traces
> >   tracing/synthetic: allocate one additional element for size
> >
> >  include/linux/trace_events.h      |  11 ++++
> >  kernel/trace/trace.h              |   8 +++
> >  kernel/trace/trace_events_synth.c | 103 ++++++++++++------------------
> >  3 files changed, 60 insertions(+), 62 deletions(-)  
> 
> Gentle ping? We're still seeing a lot of KASAN warnings.

Can you resend and include a Cc to linux-trace-kernel@vger.kernel.org. That
will put it into patchwork:

  https://patchwork.kernel.org/project/linux-trace-kernel/list/

Also, include everyone in the MAINTAINERS file too please.

That's what I use to know what to pull in for tracing. I have a personal
patchwork on my INBOX that this did go into, but that's always considered
lower priority.

-- Steve