From patchwork Mon Aug 7 13:45:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Menglong Dong X-Patchwork-Id: 13249 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp1526557vqr; Mon, 7 Aug 2023 08:26:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGDRXfjRvxFU5KDCMtRioQsTUQuFSnn/WKmJPKrZjT+lEkkLyyIUSnEcaqk+hV0JKA3BNsL X-Received: by 2002:a17:90b:fca:b0:268:46fb:df32 with SMTP id gd10-20020a17090b0fca00b0026846fbdf32mr9668952pjb.34.1691421944398; Mon, 07 Aug 2023 08:25:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691421944; cv=none; d=google.com; s=arc-20160816; b=0H4JYIzPBoLLRO6P1MIG52xcc1q/DXxUJt6ocijuifz8e/p3JZFd6ne2blTvW/qZ+O h2XV8DwAVB7vKuamAOPNuKHCsMt/B0wABLvpbeW94HdEZLrzi8VyvuylLWAph1nX6qcw 2EUZcem2di4491IHq7eNEaPO7iraM0AGBSL6zFJvDqFAilSDE0dDM0Rl0GpXtDEjz+Me pIdI1jDGGur1WaEfsEtzwV76ixSuIgtm7U3qjtJ7v1uDKWii9V8YO6pRmT6GLLu7zDWs sjmSkdZFBYB62/AuxtKn7He6FhrZI+0io2g6lop0w2HclKXHI+eJz6sIXMy7D8Lq6+tr MYTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nHjnjhn66GHqvmsQCnTfRAtBD+5kqcK4Ntmnuyxsalk=; fh=gMFH2stvrvmy061Sc0HEKF4vM70SocLRgs9YiwvSocI=; b=r0bMuDfYZrxERaFDFGA+G2cGZsD8BeSDPoMygS09DdWeJ8EW8OiB56p9Fiw0RqI+HK aC73AA0hx1ukOMskHTMeP6PkD0jcWrbiyEaq2HWrGEcJp2Ph7QEOnoc8rVh8i3d74Rht 1ALjjMOl5218aXXY7ZhndcDyAPEFdGuLv+HqRsFWH+lO70rowjC+4Bwg97Wtok8btTk/ ODRI3hbmKOYf/6QKK/ECd6F6LJWQNdtzaxIk6oTQTN3GTCo9I+S2aRG98ywea1WhN7el eiVtmrqHHrsCJJDA85fOJmwrF+TAlnhLskwW45pvynp3QDn9XoD4iyIPfy8NJKeiBSgb gZ6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ZrXwX111; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y10-20020a17090aa40a00b00262d9b8a137si9080089pjp.98.2023.08.07.08.25.31; Mon, 07 Aug 2023 08:25:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=ZrXwX111; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232427AbjHGNrP (ORCPT + 99 others); Mon, 7 Aug 2023 09:47:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231744AbjHGNrO (ORCPT ); Mon, 7 Aug 2023 09:47:14 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80758E54; Mon, 7 Aug 2023 06:47:12 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id d9443c01a7336-1bc65360648so13655445ad.1; Mon, 07 Aug 2023 06:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691416032; x=1692020832; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nHjnjhn66GHqvmsQCnTfRAtBD+5kqcK4Ntmnuyxsalk=; b=ZrXwX111qiLzoDQyeO5Rvds+3wNUtAglbuDiAhYUp8a8Fjyo9NpZ99p0Wd010QuWEy LLsrHOOyfd05K+Cd/4bPnAlm4CxhV9tEo8TsdUP5FIChQXO4KWDXlnLT4Nqt4p8bm2Zq 1ViDkc3VLCv6p1IOdIvuikHH1YXO473ONRvh6+z9Na9tjmfqgP88mCdYNqahufgcp3/N RyLwPxzWT67degtjoHXBI8E4HUCPvqRPSzwQZymQlHvSMNEZ0TaXukTO76Q6+YD+JptU erCu6Eee3l6FkBAjJRHO/1VsIMHtve5NuQuwiwfrSbXyTQLD1/aNipcQ0TfXFubxNODP /TZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691416032; x=1692020832; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nHjnjhn66GHqvmsQCnTfRAtBD+5kqcK4Ntmnuyxsalk=; b=CH8AjyRbHcjqTxnH5piVapMEqi1C4apC4Oc/4srcWyxx8bChEIO0PA53nbGO3gEbLp v5eTKbnrg0XcwSEShmItEeJgaWBl5z2GbtlFRdrKeAcIbE3BzOorPP5LpP9PLThAweSd 0D8Ak/L377ejWjRJPtrx9Uo3z3ceKR26vIk+HA3hrq5epkjf5rthn+R8ip8yD9rYeAEi uJRZyscA1nm95kKrBBR2MCvTrUw/+Asp7aVVSX5Yu5KFwhu4RDkC9wnqcV6sZ9qjJaJ9 V1jPsO+Dg0FFjocF0hwNXvLOz2fGWqzHdjpOZnli22OMVvSRU0Rjf6Okk6zwUORIwFkG 9QkQ== X-Gm-Message-State: AOJu0Yxm30Dzzv7gwLBX8+f8G6Piho2VX5151AX+vY4SMXFBIpOTkzVg DlWo0/St0qp3a1srTod1Nfg= X-Received: by 2002:a17:903:18c:b0:1bc:532f:1bf8 with SMTP id z12-20020a170903018c00b001bc532f1bf8mr9852432plg.45.1691416031727; Mon, 07 Aug 2023 06:47:11 -0700 (PDT) Received: from localhost.localdomain ([203.205.141.23]) by smtp.gmail.com with ESMTPSA id h2-20020a170902704200b001b54a88e4a6sm6912097plt.51.2023.08.07.06.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 06:47:11 -0700 (PDT) From: menglong8.dong@gmail.com X-Google-Original-From: imagedong@tencent.com To: edumazet@google.com, ncardwell@google.com Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, dsahern@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Menglong Dong Subject: [PATCH net-next v2 0/3]net: tcp: support probing OOM Date: Mon, 7 Aug 2023 21:45:44 +0800 Message-Id: <20230807134547.2782227-1-imagedong@tencent.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773584457060918007 X-GMAIL-MSGID: 1773584457060918007 From: Menglong Dong In this series, we make some small changes to make the tcp retransmission become zero-window probes if the receiver drops the skb because of memory pressure. In the 1st patch, we reply a zero-window ACK if the skb is dropped because out of memory, instead of dropping the skb silently. In the 2nd patch, we allow a zero-window ACK to update the window. In the 3rd patch, we check the timeout of a probing socket with '(u32)icsk->icsk_timeout', instead of 'tcp_jiffies32'. This is more like a bugfix. After these changes, the tcp can probe the OOM of the receiver forever. Changes since v1: - send 0 rwin ACK for the receive queue empty case when necessary in the 1st patch - send the ACK immediately by using the ICSK_ACK_NOW flag in the 1st patch - consider the case of the connection restart from idle, as Neal comment, in the 3rd patch Menglong Dong (3): net: tcp: send zero-window ACK when no memory net: tcp: allow zero-window ACK update the window net: tcp: fix unexcepted socket die when snd_wnd is 0 include/net/inet_connection_sock.h | 3 ++- net/ipv4/tcp_input.c | 16 ++++++++++++---- net/ipv4/tcp_output.c | 14 +++++++++++--- net/ipv4/tcp_timer.c | 10 +++++++++- 4 files changed, 34 insertions(+), 9 deletions(-)