mbox series

[0/2] kobject: Reasonably sanity check for kset->kobj.ktype

Message ID 20230805084114.1298-1-thunder.leizhen@huaweicloud.com
Headers
Series kobject: Reasonably sanity check for kset->kobj.ktype |

Message

Leizhen (ThunderTown) Aug. 5, 2023, 8:41 a.m. UTC 
  From: Zhen Lei <thunder.leizhen@huawei.com>

Currently, there are four API paths for adding or registering kobjects:
1. Call kobject_init() first then kobject_add()
2. kobject_init_and_add()
3. kset_register()
4. kset_create_and_add()

Except for kset_register(), the other three paths ensure that kobj.ktype cannot be NULL.

According to the description in Documentation/core-api/kobject.rst:
 - A ktype is the type of object that embeds a kobject.  Every structure
   that embeds a kobject needs a corresponding ktype.

Add sanity check for kset->kobj.ktype in kset_register(), make sure that it cannot be NULL,
then all added or registered kobj/kset.obj, its ktype is not NULL. We can safely remove all
statements that check whether kobj.ktype is NULL. They're redundant.


Zhen Lei (2):
  kobject: Add sanity check for kset->kobj.ktype in kset_register()
  kobject: Remove redundant checks for whether ktype is NULL

 lib/kobject.c | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)