mbox series

[0/2] soundwire: improve pm_runtime handling

Message ID 20230803065220.3823269-1-yung-chuan.liao@linux.intel.com
Headers
Series soundwire: improve pm_runtime handling |

Message

Bard Liao Aug. 3, 2023, 6:52 a.m. UTC 
  This patchset improves the pm_runtime behavior in rare corner cases
identified by the Intel CI in the last 6 months.

a) in stress-tests, it's not uncommon to see the following type of
warnings when the codec reports as ATTACHED

    "rt711 sdw:0:025d:0711:00: runtime PM trying to activate child device
    sdw:0:025d:0711:00 but parent (sdw-master-0) is not active"

This warning was not correlated with any functional issue, but it
exposed a design issue on when to enable pm_runtime. The recommended
practice in the pm_runtime documentation is to keep the devices in
'suspended' mode and mark them as 'active' when they are really
functional.

Pierre-Louis Bossart (2):
  soundwire: intel_auxdevice: enable pm_runtime earlier on startup
  soundWire: intel_auxdevice: resume 'sdw-master' on startup and system
    resume

 drivers/soundwire/intel_auxdevice.c | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

Comments

Vinod Koul Aug. 11, 2023, 7:06 a.m. UTC | #1 
On Thu, 03 Aug 2023 14:52:18 +0800, Bard Liao wrote:
> This patchset improves the pm_runtime behavior in rare corner cases
> identified by the Intel CI in the last 6 months.
> 
> a) in stress-tests, it's not uncommon to see the following type of
> warnings when the codec reports as ATTACHED
> 
>     "rt711 sdw:0:025d:0711:00: runtime PM trying to activate child device
>     sdw:0:025d:0711:00 but parent (sdw-master-0) is not active"
> 
> [...]

Applied, thanks!

[1/2] soundwire: intel_auxdevice: enable pm_runtime earlier on startup
      commit: 3d71f43f8a59a62c6ab832d4e73a69bae22e13b7
[2/2] soundWire: intel_auxdevice: resume 'sdw-master' on startup and system resume
      commit: f9031288110589c8f565683a182f194110338d65

Best regards,