From patchwork Wed Aug 2 13:09:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leizhen (ThunderTown)" X-Patchwork-Id: 13001 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp466514vqx; Wed, 2 Aug 2023 06:43:57 -0700 (PDT) X-Google-Smtp-Source: APBJJlHL93cFCrFqBr2TQvXwgfSN5VI4yvjnMf7rDETm50oOkczHre6G4UNYgDSoKb8g4JV9UcaS X-Received: by 2002:a05:6e02:dc8:b0:345:d58d:9ade with SMTP id l8-20020a056e020dc800b00345d58d9ademr12707236ilj.3.1690983837473; Wed, 02 Aug 2023 06:43:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690983837; cv=none; d=google.com; s=arc-20160816; b=KocWawBkswqrUdWOK6AVZNLSKItM6BgSXUvYKARxG9AxxNXQmV9dKdMlLmm2w0/KgK 4DgZma4+bTytjpJELzG0TxnQyrh3UPgjKiSqcnxve2RkAr6FG6UN8rJX97rEsIQbcWsA bN6mKf9o08RpwjZNbxQkmHS6XaLf99YvLBcQJpTEoixIgOI8GdfOU6Smz8AllTs8zYvv xQP9ddaDkkx5Uzl0UkvJ0Kw+uNh7vO1yEfij6ukeFAphQIWj0MyAHSO4rTAP0Mfgw0Ed ZK+KClGd5C0w4n1c4GqbNTTK2hWXgBzdUXJ0hEc3QiZSsGACVw6n2Ey2yWJd859NbwQD YFAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=YWeG5lQQJ7LAnQXkjgp4NhUimRLizyIWBSsijrzufrI=; fh=ixpq6thPVOOZuciljZRZ5gp6/ROsGXjbN7hNRM43S+c=; b=x+yIkkievmLIdhC4sooHZO9QD8avtZrpD+rfPmapxJf836OkLXnr+zrlt2PgqdIewF rPbW2/RdXPcz8DPaLyTZ7aFg6bQBOyPYHWbNm123WsATTTGDnxYjc1Fwb/2XuZ+s/KJr B1CD4xqS03oWgfyzo82b0mjBUZjMowBHbNfyIHgWZ4AAaUlyt5fIdhGmgNWSFgZ+NxiX p9E8mPaWnpHaryxv9kxwEI5K/m8DzYh00lduqHBOylpMkAv8Jbn/Z7jH664sI7U/ufMX 01XVfXbhtNbic6k2TnOg1oNWf7WN9KfsmXeGBALmWKMzwNL2f8NXObi1WPtcEnS0oB3W ip6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lk3-20020a17090308c300b001b9e29fe870si1273369plb.62.2023.08.02.06.43.42; Wed, 02 Aug 2023 06:43:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232148AbjHBNJh (ORCPT + 99 others); Wed, 2 Aug 2023 09:09:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231176AbjHBNJd (ORCPT ); Wed, 2 Aug 2023 09:09:33 -0400 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0527268E; Wed, 2 Aug 2023 06:09:30 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RGC431vmCz4f3nwj; Wed, 2 Aug 2023 21:09:23 +0800 (CST) Received: from huaweicloud.com (unknown [10.174.178.55]) by APP4 (Coremail) with SMTP id gCh0CgAHvbCBVcpkDKSVPQ--.59231S4; Wed, 02 Aug 2023 21:09:24 +0800 (CST) From: thunder.leizhen@huaweicloud.com To: Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, "Paul E . McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Zqiang , rcu@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Zhen Lei Subject: [PATCH v4 0/2] rcu: Dump memory object info if callback function is invalid Date: Wed, 2 Aug 2023 21:09:16 +0800 Message-Id: <20230802130918.1132-1-thunder.leizhen@huaweicloud.com> X-Mailer: git-send-email 2.37.3.windows.1 MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAHvbCBVcpkDKSVPQ--.59231S4 X-Coremail-Antispam: 1UD129KBjvJXoW7ZFWfXrW8KrWrCr4rXry8Grg_yoW8Gw13pw nxW3sxWr15Jry3CF13ZF1Ikry5Gay8KFsIk3ZxZws5Zw15Zr97uFykJr1IqF9xGF97K3W0 ya1YkF1jkr4DArDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6r1S6rWUM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7M4kE6xkI j40Ew7xC0wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_GFv_Wryl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x07 UKfO7UUUUU= X-CM-SenderInfo: hwkx0vthuozvpl2kv046kxt4xhlfz01xgou0bp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KHOP_HELO_FCRDNS, MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773088810889479563 X-GMAIL-MSGID: 1773125068308343380 From: Zhen Lei v3 --> v4: 1. Remove kmem_valid_obj() and convert kmem_dump_obj() to work the same way as vmalloc_dump_obj(). 2. In kernel/rcu/rcu.h -#include +#include v2 --> v3: 1. I made statistics about the source of 'rhp'. kmem_valid_obj() accounts for more than 97.5%, and vmalloc accounts for less than 1%. So change call mem_dump_obj() to call kmem_dump_obj() can meet debugging requirements and avoid the potential deadlock risk of vmalloc_dump_obj(). - mem_dump_obj(rhp); + if (kmem_valid_obj(rhp)) + kmem_dump_obj(rhp); The discussion about vmap_area_lock deadlock in v2: https://lkml.org/lkml/2022/11/11/493 2. Provide static inline empty functions for kmem_valid_obj() and kmem_dump_obj() when CONFIG_PRINTK=n. v1 --> v2: 1. Remove condition "(unsigned long)rhp->func & 0x3", it have problems on x86. 2. Paul E. McKenney helped me update the commit message, thanks. Zhen Lei (2): mm: Remove kmem_valid_obj() rcu: Dump memory object info if callback function is invalid include/linux/slab.h | 5 +++-- kernel/rcu/rcu.h | 7 +++++++ kernel/rcu/srcutiny.c | 1 + kernel/rcu/srcutree.c | 1 + kernel/rcu/tasks.h | 1 + kernel/rcu/tiny.c | 1 + kernel/rcu/tree.c | 1 + mm/slab_common.c | 41 +++++++++++------------------------------ mm/util.c | 4 +--- 9 files changed, 27 insertions(+), 35 deletions(-)