Message ID | 20230801212226.909249-1-aconole@redhat.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f41:0:b0:3e4:2afc:c1 with SMTP id v1csp31081vqx; Tue, 1 Aug 2023 14:46:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlFDybOO32h7yrCNJ1UWCsxT8rlGqu74fuzflLxHiniFcjSwS1xITYuSx+9g7UEQ9gwBSzwM X-Received: by 2002:a17:907:78c8:b0:992:ef60:aadd with SMTP id kv8-20020a17090778c800b00992ef60aaddmr4914233ejc.13.1690926415991; Tue, 01 Aug 2023 14:46:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690926415; cv=none; d=google.com; s=arc-20160816; b=pKFZmg2FX5XhqeVHEQecZOosWNJboIjXfQpVphdQhR4a038eJn4SgCPtSA9QjJVdGS Z5Kku8p4M9Pgivlu+ArmR7LYnRPaidGnyYsOS8b/jThJHItv26+k460CQeejGMqIaE6u IqHB6lyV13PYxm2lmbk0a+r4q3ZRL31+CF2X3vSdovMMy2MqQELUzgbIsW+YPAdwuKXQ DMMhXVUJ6QWrXtVu1F1hHXvFqG6lYOYeKiemsDKO+MVsWPmbGwxwc3vkOA7Dqn5f4ibx j57jEfd6iAPfM0riQwy00sDg1lnCGM5H7Q9TbJZCdttFJYeYZ02L9uSXlv9CZuUHttGj StoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=MzRC37yNjV65GcpWLeg5IaHGjHuuIxo3iyZAS/bTmpk=; fh=k0eI+qPQ0cSVpz/EwlUdTMgC8xQVS6ZAY48bRoDXck0=; b=rxfyUC+ef+d/KWFJKFe1a/SgOJzkyiVkiDPlP12jx5/CdTZsDxuiu4UuKFQwNIOXIX NyqR4FyJpK36qElyu/+eg7X7cQzUlXZ6knvSAfAN3kxqAygE5Nc0P3jzh22ap2OhMb8u DHRrg0bBdhF/UIMvA5NrUHSU2JDUnZ1QsxK03LSeI1H9FggP6ra0aNIsiOfgSnwwuABe tX6tMbk6PD/6Q1KpA6i4Rwrw4yrifn7Raw0coaGzQnOSMy8uVnfUXX2BgpV+Vp1qysZ/ xN3NoYsAk3lY9WntPLXFCruP2RsOfPG3xyMs+/lH6jsJkQeqxxW8gjxfbf8PoEPfzyj9 7DXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HIAPfTl+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020a170906858e00b0099298837776si9360751ejx.629.2023.08.01.14.46.31; Tue, 01 Aug 2023 14:46:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HIAPfTl+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231287AbjHAVXV (ORCPT <rfc822;dengxinlin2429@gmail.com> + 99 others); Tue, 1 Aug 2023 17:23:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230049AbjHAVXT (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 1 Aug 2023 17:23:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2945FF for <linux-kernel@vger.kernel.org>; Tue, 1 Aug 2023 14:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690924952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=MzRC37yNjV65GcpWLeg5IaHGjHuuIxo3iyZAS/bTmpk=; b=HIAPfTl+4/HBmhQqJvaPHFbHB3dhRfZqOU2EVpO51JWYQfPIEe6W+7Q9O+M9sJef7ynGMS peNm+DKUgUm8AUzhgo2RAndpB6wc6LM2PLveWf4KERsM40QbhohXqjjPuyug73rFZVT9uA b9RB/xm6DTSeRfjYHc0rIDX6L/NgPqE= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-122-Gam-80i0NfCuf3dA2ho7Eg-1; Tue, 01 Aug 2023 17:22:29 -0400 X-MC-Unique: Gam-80i0NfCuf3dA2ho7Eg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 499343C11A01; Tue, 1 Aug 2023 21:22:29 +0000 (UTC) Received: from RHTPC1VM0NT.redhat.com (unknown [10.22.8.217]) by smtp.corp.redhat.com (Postfix) with ESMTP id 59DA6F7855; Tue, 1 Aug 2023 21:22:27 +0000 (UTC) From: Aaron Conole <aconole@redhat.com> To: netdev@vger.kernel.org Cc: dev@openvswitch.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>, Eric Dumazet <edumazet@google.com>, "David S. Miller" <davem@davemloft.net>, Pravin B Shelar <pshelar@ovn.org>, Adrian Moreno <amorenoz@redhat.com>, Ilya Maximets <i.maximets@ovn.org> Subject: [PATCH v3 net-next 0/5] selftests: openvswitch: add flow programming cases Date: Tue, 1 Aug 2023 17:22:21 -0400 Message-Id: <20230801212226.909249-1-aconole@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773064857480692814 X-GMAIL-MSGID: 1773064857480692814 |
Series |
selftests: openvswitch: add flow programming cases
|
|
Message
Aaron Conole
Aug. 1, 2023, 9:22 p.m. UTC
The openvswitch selftests currently contain a few cases for managing the datapath, which includes creating datapath instances, adding interfaces, and doing some basic feature / upcall tests. This is useful to validate the control path. Add the ability to program some of the more common flows with actions. This can be improved overtime to include regression testing, etc. v2->v3: 1. Dropped support for ipv6 in nat() case 2. Fixed a spelling mistake in 2/5 commit message. v1->v2: 1. Fix issue when parsing ipv6 in the NAT action 2. Fix issue calculating length during ctact parsing 3. Fix error message when invalid bridge is passed 4. Fold in Adrian's patch to support key masks Aaron Conole (4): selftests: openvswitch: add an initial flow programming case selftests: openvswitch: add a test for ipv4 forwarding selftests: openvswitch: add basic ct test case parsing selftests: openvswitch: add ct-nat test case with ipv4 Adrian Moreno (1): selftests: openvswitch: support key masks .../selftests/net/openvswitch/openvswitch.sh | 223 +++++++ .../selftests/net/openvswitch/ovs-dpctl.py | 588 +++++++++++++++++- 2 files changed, 787 insertions(+), 24 deletions(-)
Comments
On Tue, Aug 01, 2023 at 05:22:21PM -0400, Aaron Conole wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic feature / upcall tests. This is useful to validate > the control path. > > Add the ability to program some of the more common flows with actions. This > can be improved overtime to include regression testing, etc. Thanks Aaron. For series, Reviewed-by: Simon Horman <horms@kernel.org>
On Tue, 2023-08-01 at 17:22 -0400, Aaron Conole wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic feature / upcall tests. This is useful to validate > the control path. > > Add the ability to program some of the more common flows with actions. This > can be improved overtime to include regression testing, etc. > > v2->v3: > 1. Dropped support for ipv6 in nat() case > 2. Fixed a spelling mistake in 2/5 commit message. > > v1->v2: > 1. Fix issue when parsing ipv6 in the NAT action > 2. Fix issue calculating length during ctact parsing > 3. Fix error message when invalid bridge is passed > 4. Fold in Adrian's patch to support key masks FTR, this apparently requires an [un?]fairly recent version of pyroute2. Perhaps you could explicitly check for a minimum working version and otherwise bail out (skip) the add-flow tests. Cheers, Paolo
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Tue, 1 Aug 2023 17:22:21 -0400 you wrote: > The openvswitch selftests currently contain a few cases for managing the > datapath, which includes creating datapath instances, adding interfaces, > and doing some basic feature / upcall tests. This is useful to validate > the control path. > > Add the ability to program some of the more common flows with actions. This > can be improved overtime to include regression testing, etc. > > [...] Here is the summary with links: - [v3,net-next,1/5] selftests: openvswitch: add an initial flow programming case https://git.kernel.org/netdev/net-next/c/918423fda910 - [v3,net-next,2/5] selftests: openvswitch: support key masks https://git.kernel.org/netdev/net-next/c/9f1179fbbd84 - [v3,net-next,3/5] selftests: openvswitch: add a test for ipv4 forwarding https://git.kernel.org/netdev/net-next/c/05398aa40953 - [v3,net-next,4/5] selftests: openvswitch: add basic ct test case parsing https://git.kernel.org/netdev/net-next/c/2893ba9c1d1a - [v3,net-next,5/5] selftests: openvswitch: add ct-nat test case with ipv4 https://git.kernel.org/netdev/net-next/c/60f10077eec6 You are awesome, thank you!
Paolo Abeni <pabeni@redhat.com> writes: > On Tue, 2023-08-01 at 17:22 -0400, Aaron Conole wrote: >> The openvswitch selftests currently contain a few cases for managing the >> datapath, which includes creating datapath instances, adding interfaces, >> and doing some basic feature / upcall tests. This is useful to validate >> the control path. >> >> Add the ability to program some of the more common flows with actions. This >> can be improved overtime to include regression testing, etc. >> >> v2->v3: >> 1. Dropped support for ipv6 in nat() case >> 2. Fixed a spelling mistake in 2/5 commit message. >> >> v1->v2: >> 1. Fix issue when parsing ipv6 in the NAT action >> 2. Fix issue calculating length during ctact parsing >> 3. Fix error message when invalid bridge is passed >> 4. Fold in Adrian's patch to support key masks > > FTR, this apparently requires an [un?]fairly recent version of > pyroute2. Perhaps you could explicitly check for a minimum working > version and otherwise bail out (skip) the add-flow tests. I'll make sure to get a follow up out ASAP that includes some check for supported version and will skip if not. I will try to also include some additional robustness checks. Thanks Paolo! > Cheers, > > Paolo