From patchwork Mon Jul 31 16:57:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 12901 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp2241157vqg; Mon, 31 Jul 2023 13:10:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlFJBYn5TrbWRne23aih7iN5WcEIUqi6JMhGqrU9G2vhodMd2nXFtR428Pdhc1FMuM1VgFcA X-Received: by 2002:a17:902:ec83:b0:1bb:cf4e:ccd with SMTP id x3-20020a170902ec8300b001bbcf4e0ccdmr13831233plg.28.1690834233683; Mon, 31 Jul 2023 13:10:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690834233; cv=none; d=google.com; s=arc-20160816; b=0uvxuln50PPXyuyjo78BSa1yPDmc2OiFYoXze/O/5cb9LsGNid3h5Q5ZquRqVk2orp RgaVtuwJM2UmSeqG1p9ZVK+2AzP3/tXNS/UaBStumTSoQHOlyA4dY39sQDFX30g7c9f1 zkq3fjUgiMYVM//Wu2DWHgfqG1JcIAYmwesyjM9C+wWJDwAdI6Gs8JMxaNea5JKlBuHs zYZa3RAodrcSAjVY8sbgMzXRbF4UB4MNrb3XRseKZJPt+wq7uawuOOoqdBopqU29vdJO myyjvvO8LCjCKzI78hKHvvVpwtGBZQaNF/mQ0ljJeXd7B9OKSNAS/jAqbKnLiEmHGEH2 oUcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=KNgSpTotHfWibFvb5ScGYc/joj31dYCwg4MR3+99vcw=; fh=LfQCrBMaKEgbD0siDAPrEFK33OeuzJ3zXGk+5eD9ICw=; b=Wmu8iJXG1hDY2vyQrtHMIw8yDjgi5hgY6DhkmfnPlG6JRziy+aIlOD7GdN1OKu41LH pEVZC5JxjUkqvvedEX4QFB2DYpS+qQ/s1OuVn1vc250gzYtZeB8gYnJ1xyjBc15ZcKaO 2MWRi0C+TOJW6lSYWGStm2dK3w0Ec3ul19yW+4qTMLTEmSxNIt/c+2k8esNgMtwXcNZL rsrjiyEHXE8qukSMtc4gjeK53GJhj9M9xD1vFAZui994GqKcd4fAeyoTKj54po4Gct4I SOcpwPHDepLuCtgY5smw93DZS3u79CP3TVaMJdfnC/a3IsM6OrA8ZyZDuTlZ0ZOawQax iQMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=IApEo06C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p9-20020a170902e74900b001b87bd2f7b0si8201773plf.402.2023.07.31.13.10.18; Mon, 31 Jul 2023 13:10:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=IApEo06C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233605AbjGaQ5b (ORCPT + 99 others); Mon, 31 Jul 2023 12:57:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233591AbjGaQ53 (ORCPT ); Mon, 31 Jul 2023 12:57:29 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A922E1729; Mon, 31 Jul 2023 09:57:28 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-210-008.ewe-ip-backbone.de [91.248.210.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 154256606FCD; Mon, 31 Jul 2023 17:57:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690822647; bh=6bj7q3XOaZvPQ3D5Rpuxi1xUU41U8fTcdodRo9gr6cE=; h=From:To:Cc:Subject:Date:From; b=IApEo06CLoOTI/+bDpJ3jlireiem32kItGql8+F4MK6pufskhhq3WdFUR8SmKvKPk s4QgT45kZvAvV984+0JWSFthWTHDx7HKAztaAE6Tbr6H8uZ6rJo/bwS3asLS8/i2/I A/MuaptY26x6o6KPihalOQc1wKOvDUnTZfALpdA+gq1lZQOlaSyC62hDr4KK9nYADm yT02J8Omgsbf/1G14+Yuo3BTfqB5GsGb5PJ1DCSSV2i6eBzSAXA2kfU4iHp0TnGCvf Uq2r2xTz9ohyZUVj5KtYjyBxawoSuTs9jjrAvsBWu+/RjHQ4hGgtxu7Op/B5EB1fGJ PkCDHhpXQH6eA== Received: by jupiter.universe (Postfix, from userid 1000) id 274C9480099; Mon, 31 Jul 2023 18:57:25 +0200 (CEST) From: Sebastian Reichel To: linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Serge Semin Cc: Jingoo Han , Gustavo Pimentel , Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Shawn Lin , Simon Xue , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Reichel , kernel@collabora.com Subject: [PATCH v4 0/5] RK3588 PCIe2 support Date: Mon, 31 Jul 2023 18:57:18 +0200 Message-Id: <20230731165723.53069-1-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772968197595691766 X-GMAIL-MSGID: 1772968197595691766 Hi, This adds PCIe v2 support for RK3588. The series has been tested with the onboard RTL8125 network card on Rockchip RK3588 EVB1 (&pcie2x1l1) and Radxa Rock 5B (&pcie2x1l2). Changes since v3: * https://lore.kernel.org/all/20230717172651.64324-1-sebastian.reichel@collabora.com/ * Remove unneeded quotes in patch 1 (msi handling) * Update patch description of patch 2 (interrupt names) adding information about Rockchip specific parts Changes since v2: * https://lore.kernel.org/all/20230713171851.73052-1-sebastian.reichel@collabora.com/ * Removed num-ib-windows/num-ob-windows/num-viewport from DT * Added patch making 'msi' irq optional, if 'msi-map' property is available * Updated binding according two discussion with Serge Semin, I provided two options by adding one extra patch that should be squashed into the main one or dropped depending on preferences from DT binding maintainers. * Collected Reviewed-by/Tested-by from Jagan Teki Changes since v1: * https://lore.kernel.org/all/20230616170022.76107-1-sebastian.reichel@collabora.com/ * Dropped patch adding 'RK3588' (queued by Rob) * Updated patch adding legacy-interrupt-controller according to comments from Rob and Serge - added missing additionalProperties: false - added all properties to new required property - removed useless quotes around interrupt-controller - added Rob's Reviewed-by * Updated patch adding the missing RK356x/RK3588 interrupt names, so that it provides more details about the interrupts * Updated the DT patch according to the comment from Jonas Karlman, so that the addresses are in 32 bit address space starting at 0x40000000 [0] https://lore.kernel.org/all/20230612171337.74576-1-sebastian.reichel@collabora.com/ Thanks, -- Sebastian Sebastian Reichel (5): dt-bindings: PCI: dwc: improve msi handling dt-bindings: PCI: dwc: rockchip: Fix interrupt-names issue dt-bindings: PCI: dwc: rockchip: Use generic binding dt-bindings: PCI: dwc: rockchip: Add missing legacy-interrupt-controller arm64: dts: rockchip: rk3588: add PCIe2 support .../bindings/pci/rockchip-dw-pcie.yaml | 70 ++++++++++++ .../devicetree/bindings/pci/snps,dw-pcie.yaml | 18 +++- arch/arm64/boot/dts/rockchip/rk3588.dtsi | 51 +++++++++ arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 102 ++++++++++++++++++ 4 files changed, 237 insertions(+), 4 deletions(-)