mbox series

[0/1] can: esd_usb: Add support for esd CAN-USB/3

Message ID 20230728150857.2374886-1-frank.jungclaus@esd.eu
Headers
Series can: esd_usb: Add support for esd CAN-USB/3 |

Message

Frank Jungclaus July 28, 2023, 3:08 p.m. UTC 
  After having applied a vast number of improvements to the existing
CAN-USB/2 driver here now is a new attempt to add support for the esd
CAN-USB/3 CAN FD interface.

Beside this patch there are the following to-do's left for follow-up
patches:

* In principle, the esd CAN-USB/3 supports Transmitter Delay
Compensation (TDC), but currently only the automatic TDC mode is
supported by this driver. An implementation for manual TDC
configuration will follow.

* Rework the code to no longer switch directly on the USB product IDs
to handle different device setting for each supported USB
device. Instead use the driver_info member within struct usb_device_id
to hold / point to specific properties for each supported device.

* Try to switch from synchronous send usb_bulk_msg() to asynchronous
communication by means of usb_submit_urb() where it is feasible.

Frank Jungclaus (1):
  can: esd_usb: Add support for esd CAN-USB/3

 drivers/net/can/usb/esd_usb.c | 275 ++++++++++++++++++++++++++++++----
 1 file changed, 244 insertions(+), 31 deletions(-)


base-commit: 68af900072c157c0cdce0256968edd15067e1e5a

Comments

Marc Kleine-Budde Aug. 3, 2023, 8:10 a.m. UTC | #1 
On 28.07.2023 17:08:56, Frank Jungclaus wrote:
> After having applied a vast number of improvements to the existing
> CAN-USB/2 driver here now is a new attempt to add support for the esd
> CAN-USB/3 CAN FD interface.
> 
> Beside this patch there are the following to-do's left for follow-up
> patches:
> 
> * In principle, the esd CAN-USB/3 supports Transmitter Delay
> Compensation (TDC), but currently only the automatic TDC mode is
> supported by this driver. An implementation for manual TDC
> configuration will follow.
> 
> * Rework the code to no longer switch directly on the USB product IDs
> to handle different device setting for each supported USB
> device. Instead use the driver_info member within struct usb_device_id
> to hold / point to specific properties for each supported device.
> 
> * Try to switch from synchronous send usb_bulk_msg() to asynchronous
> communication by means of usb_submit_urb() where it is feasible.

Added to linux-can-next/testing.

Thanks,
Marc