mbox series

[v2,0/4] i2c: thunderx: Marvell thunderx i2c changes

Message ID 20230728120004.19680-1-pmalgujar@marvell.com
Headers
Series i2c: thunderx: Marvell thunderx i2c changes |

Message

Piyush Malgujar July 28, 2023, noon UTC 
  The changes are for Marvell OcteonTX2 SOC family:

- Handling clock divisor logic using subsytem ID
- Support for high speed mode
- Handle watchdog timeout
- Added ioclk support

Changes since V1:
- Addressed comments, added defines as required
- Removed unnecessary code
- Added a patch to support ioclk if sclk not present in ACPI table

Piyush Malgujar (1):
  i2c: thunderx: Adding ioclk support

Suneel Garapati (3):
  i2c: thunderx: Clock divisor logic changes
  i2c: thunderx: Add support for High speed mode
  i2c: octeon: Handle watchdog timeout

 drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
 drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
 drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
 3 files changed, 115 insertions(+), 31 deletions(-)

Comments

Andi Shyti Aug. 5, 2023, 12:06 p.m. UTC | #1 
Hi Robert,

On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> The changes are for Marvell OcteonTX2 SOC family:
> 
> - Handling clock divisor logic using subsytem ID
> - Support for high speed mode
> - Handle watchdog timeout
> - Added ioclk support
> 
> Changes since V1:
> - Addressed comments, added defines as required
> - Removed unnecessary code
> - Added a patch to support ioclk if sclk not present in ACPI table
> 
> Piyush Malgujar (1):
>   i2c: thunderx: Adding ioclk support
> 
> Suneel Garapati (3):
>   i2c: thunderx: Clock divisor logic changes
>   i2c: thunderx: Add support for High speed mode
>   i2c: octeon: Handle watchdog timeout

any chance you could take a look at this series?

Thanks,
Andi
Andi Shyti Oct. 24, 2023, 8:14 p.m. UTC | #2 
Hi Piyush,

On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> The changes are for Marvell OcteonTX2 SOC family:
> 
> - Handling clock divisor logic using subsytem ID
> - Support for high speed mode
> - Handle watchdog timeout
> - Added ioclk support
> 
> Changes since V1:
> - Addressed comments, added defines as required
> - Removed unnecessary code
> - Added a patch to support ioclk if sclk not present in ACPI table
> 
> Piyush Malgujar (1):
>   i2c: thunderx: Adding ioclk support
> 
> Suneel Garapati (3):
>   i2c: thunderx: Clock divisor logic changes
>   i2c: thunderx: Add support for High speed mode
>   i2c: octeon: Handle watchdog timeout
> 
>  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
>  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
>  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
>  3 files changed, 115 insertions(+), 31 deletions(-)

I was going through the patches that failed to receive an answer,
is this series still valid? Do you still need a round of review
here?

Andi
Piyush Malgujar Oct. 26, 2023, 12:54 p.m. UTC | #3 
On Tue, Oct 24, 2023 at 10:14:40PM +0200, Andi Shyti wrote:
> Hi Piyush,
> 
> On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> > The changes are for Marvell OcteonTX2 SOC family:
> > 
> > - Handling clock divisor logic using subsytem ID
> > - Support for high speed mode
> > - Handle watchdog timeout
> > - Added ioclk support
> > 
> > Changes since V1:
> > - Addressed comments, added defines as required
> > - Removed unnecessary code
> > - Added a patch to support ioclk if sclk not present in ACPI table
> > 
> > Piyush Malgujar (1):
> >   i2c: thunderx: Adding ioclk support
> > 
> > Suneel Garapati (3):
> >   i2c: thunderx: Clock divisor logic changes
> >   i2c: thunderx: Add support for High speed mode
> >   i2c: octeon: Handle watchdog timeout
> > 
> >  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
> >  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
> >  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
> >  3 files changed, 115 insertions(+), 31 deletions(-)
> 
> I was going through the patches that failed to receive an answer,
> is this series still valid? Do you still need a round of review
> here?
> 
> Andi

Hi Andi,

Yes, these patches are still valid. These have been acked by you
and were waiting to get reply from Robert.
Please review the patches.

Thanks,
Piyush
Andi Shyti Jan. 4, 2024, 10:06 p.m. UTC | #4 
Hi Piyush,

On Thu, Oct 26, 2023 at 05:54:29AM -0700, Piyush Malgujar wrote:
> On Tue, Oct 24, 2023 at 10:14:40PM +0200, Andi Shyti wrote:
> > Hi Piyush,
> > 
> > On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> > > The changes are for Marvell OcteonTX2 SOC family:
> > > 
> > > - Handling clock divisor logic using subsytem ID
> > > - Support for high speed mode
> > > - Handle watchdog timeout
> > > - Added ioclk support
> > > 
> > > Changes since V1:
> > > - Addressed comments, added defines as required
> > > - Removed unnecessary code
> > > - Added a patch to support ioclk if sclk not present in ACPI table
> > > 
> > > Piyush Malgujar (1):
> > >   i2c: thunderx: Adding ioclk support
> > > 
> > > Suneel Garapati (3):
> > >   i2c: thunderx: Clock divisor logic changes
> > >   i2c: thunderx: Add support for High speed mode
> > >   i2c: octeon: Handle watchdog timeout
> > > 
> > >  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
> > >  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
> > >  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
> > >  3 files changed, 115 insertions(+), 31 deletions(-)
> > 
> > I was going through the patches that failed to receive an answer,
> > is this series still valid? Do you still need a round of review
> > here?
> > 
> > Andi
> 
> Hi Andi,
> 
> Yes, these patches are still valid. These have been acked by you
> and were waiting to get reply from Robert.
> Please review the patches.

sorry for the very late response... I guess we won't receive any
answer from Robert... do you mind respinning the series as this
doesn't apply anymore?

Thanks,
Andi
Robert Richter Jan. 5, 2024, 11:10 a.m. UTC | #5 
On 04.01.24 23:06:35, Andi Shyti wrote:
> On Thu, Oct 26, 2023 at 05:54:29AM -0700, Piyush Malgujar wrote:
> > On Tue, Oct 24, 2023 at 10:14:40PM +0200, Andi Shyti wrote:
> > > On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:

> > > >  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
> > > >  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
> > > >  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
> > > >  3 files changed, 115 insertions(+), 31 deletions(-)
> > > 
> > > I was going through the patches that failed to receive an answer,
> > > is this series still valid? Do you still need a round of review
> > > here?
> > > 
> > > Andi
> > 
> > Hi Andi,
> > 
> > Yes, these patches are still valid. These have been acked by you
> > and were waiting to get reply from Robert.
> > Please review the patches.
> 
> sorry for the very late response... I guess we won't receive any
> answer from Robert... do you mind respinning the series as this
> doesn't apply anymore?

I would prefer if someone from Marvell could take over maintainership
for those ThunderX drivers.

Thanks,

-Robert
Andi Shyti Feb. 8, 2024, 9:05 p.m. UTC | #6 
Hi Robert,

On Fri, Jan 05, 2024 at 12:10:14PM +0100, Robert Richter wrote:
> On 04.01.24 23:06:35, Andi Shyti wrote:
> > On Thu, Oct 26, 2023 at 05:54:29AM -0700, Piyush Malgujar wrote:
> > > On Tue, Oct 24, 2023 at 10:14:40PM +0200, Andi Shyti wrote:
> > > > On Fri, Jul 28, 2023 at 05:00:00AM -0700, Piyush Malgujar wrote:
> 
> > > > >  drivers/i2c/busses/i2c-octeon-core.c     | 96 ++++++++++++++++++------
> > > > >  drivers/i2c/busses/i2c-octeon-core.h     | 27 +++++++
> > > > >  drivers/i2c/busses/i2c-thunderx-pcidrv.c | 23 ++++--
> > > > >  3 files changed, 115 insertions(+), 31 deletions(-)
> > > > 
> > > > I was going through the patches that failed to receive an answer,
> > > > is this series still valid? Do you still need a round of review
> > > > here?
> > > > 
> > > > Andi
> > > 
> > > Hi Andi,
> > > 
> > > Yes, these patches are still valid. These have been acked by you
> > > and were waiting to get reply from Robert.
> > > Please review the patches.
> > 
> > sorry for the very late response... I guess we won't receive any
> > answer from Robert... do you mind respinning the series as this
> > doesn't apply anymore?
> 
> I would prefer if someone from Marvell could take over maintainership
> for those ThunderX drivers.

As long as it will be

CAVIUM I2C DRIVER
M:      Robert Richter <rric@kernel.org>
S:      Odd Fixes
W:      http://www.marvell.com
F:      drivers/i2c/busses/i2c-octeon*
F:      drivers/i2c/busses/i2c-thunderx*

people will refer to you about this driver. If you really don't
want to be referred to these patches you can consider removing
the entry or I can do it for you.

Meantime, I can accept candidates from Marvell/Cavium.

Andi