Message ID | 20230728100857.471984-1-dmitry.baryshkov@linaro.org |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp361888vqg; Fri, 28 Jul 2023 04:22:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlEUjWbnlfuMf3sNZOp42fuxHzhvRNCqD0+W7nRZiYJ6qO6OXaOVgDtK7k0LZzD3mKJqmGtS X-Received: by 2002:a05:6a00:2487:b0:666:8cbb:6e0f with SMTP id c7-20020a056a00248700b006668cbb6e0fmr1376139pfv.3.1690543371375; Fri, 28 Jul 2023 04:22:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690543371; cv=none; d=google.com; s=arc-20160816; b=xWOzdeVKWpQJjbVyfU775KmN3JMyEHrBx8K6DEca9VqQnvMx6an8mS226xI8Lh3zFR +gyBW9OO1HiCV9fGddGNMBHUFyj9f+4KjNn5yd7nct6TjkffoSYuUjqhtMng8Hel/070 STvVpTvOrX2db6PVRi3k6YuOovRHRjkuo6a+QzwYMu7h10tqs2cLz77OvHCiFok/zteu 0fhktXWz0MNJaWekcu7nsYRqonyMd0JAGcubp7NjwYRJ0DsJ92Mwz17rPi/8ZimH+a60 IFZSGkTxENvQXjW8dB/1D07MQcCHRrImBmJOWIwF7e/VQ7+LcNj+mb0sMbDrhAhlmlmD I6OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/yDS6GJ77QbFwTMN91XqQ7OJgmLRybRbCpy7Yu02w1A=; fh=e86DAimGadUEah4YsEZw9dwrhmQ4PbY0xaNPVeYNNKE=; b=Aq+BEK4pvbs79XQx7e+m1REBAQYatHj69kZTv7B/aI7/3A44yYfiIWiI1FygbE2aEH /4oSQ5BSbQC61rImnHy05nWHla6Vg6kXijnVMq+btk6MSsQanne/W1kOXrsL9fbrX/1E 33LfIHVsoaETtraY/2C1Q3aVyfs2+B10d41x3mwr/nNLnEeu0gkrky4ukjbakMu1fxhG ujCpNlkdmSalQC1r3HNeqohvF/WjPi8E3nI+IQXL+1FhRW/l4pS8xJ+54rgkD6gw/csx KDeR49j41K4mUeMzSc7UiojmjmognyQoWPTQQQ1wEpxSzx08W+3uVV9CPIsah2Ctq2LS uC/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rnjbWsI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b23-20020a63cf57000000b005538e9fb8cbsi2802954pgj.550.2023.07.28.04.22.15; Fri, 28 Jul 2023 04:22:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rnjbWsI0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235349AbjG1KJF (ORCPT <rfc822;hanasaki@gmail.com> + 99 others); Fri, 28 Jul 2023 06:09:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234952AbjG1KJD (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Jul 2023 06:09:03 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2295935BE for <linux-kernel@vger.kernel.org>; Fri, 28 Jul 2023 03:09:01 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fe0c566788so3377284e87.0 for <linux-kernel@vger.kernel.org>; Fri, 28 Jul 2023 03:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690538939; x=1691143739; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/yDS6GJ77QbFwTMN91XqQ7OJgmLRybRbCpy7Yu02w1A=; b=rnjbWsI0m+4cAh+BrLKko6ztdnDcbo7mrJ5bAdWuHOmjMQP3zgR4RfnGL+IAmSH5e3 vD4JeZLgtwUkGNM6jK6JZF2M80aobp085r75R0sKwvbRdo5YCeSK92XwTzlnCWdEun31 uRpOUOoWDJRFdpAj3aW2CFInGVhQVna+qsxHtmFV8FpZDeCvZpT9xTaDrdp4IxDnB0k0 o+tQfsXhgIj511GAqJY3usY+3fiMqgSYDCaVwuqb1KolBfNOvY4s+76AMDGkFzRDXoMd /ArrlEMXJYHBjy2nS5JQ6LuwJF7v9PPTeuObHmvsvoacJbENlJz+zfyNiH2HnHTGNCbR 5d9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690538939; x=1691143739; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/yDS6GJ77QbFwTMN91XqQ7OJgmLRybRbCpy7Yu02w1A=; b=d9D0CYZfVJjD2V4ju3zS6ReIFkH7pAtqO4otqvxaUAlq0TYLfB94PXBKL5pej0TolA tXHu+UfTtr/0zPbKcdMOmheedKSSm8cNq4+7AoEm9vyXVvYAYHGdVdH5vbmA/mOMinm5 pVcpKn3ED7ab8/DUZU24I6e9R90Vv/XnzU07Q8SdOB63Z4KxH+jmsQJtx2y/BiscvWZL 1sW2lLtg2Q1PZ3bQrDeOluOlHbePNzZyqU8omgLC10koPKCee8qCWoR7MA0QsFlkCBrB sykoLf1s2/IK5am+vu0Rheu/jTr2nw296Bbc97zveMVHJOf0YL8dTJQBTGCPPH76HJFU sncg== X-Gm-Message-State: ABy/qLaLNqgslOnZ4cVrAIRypNpo9N/oyIKYi3poB503joa6vqWt1+P2 ddslhNNkacTGbGKpwk4Dlj3EEA== X-Received: by 2002:a05:6512:2026:b0:4f8:5635:2cd8 with SMTP id s6-20020a056512202600b004f856352cd8mr1250200lfs.32.1690538939264; Fri, 28 Jul 2023 03:08:59 -0700 (PDT) Received: from lothlorien.lan (dzdqv0yyyyyyyyyyybm5y-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::ab2]) by smtp.gmail.com with ESMTPSA id h16-20020ac25970000000b004fe0de39fddsm741704lfp.290.2023.07.28.03.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 03:08:58 -0700 (PDT) From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Heikki Krogerus <heikki.krogerus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Bryan O'Donoghue <bryan.odonoghue@linaro.org>, Guenter Roeck <linux@roeck-us.net>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 0/2] usb: typec: qcom-pmic-typec: enable DP support Date: Fri, 28 Jul 2023 13:08:55 +0300 Message-Id: <20230728100857.471984-1-dmitry.baryshkov@linaro.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772662855371603603 X-GMAIL-MSGID: 1772663206572809667 |
Series |
usb: typec: qcom-pmic-typec: enable DP support
|
|
Message
Dmitry Baryshkov
July 28, 2023, 10:08 a.m. UTC
To enable DisplayPort on the platforms supported by qcom-pmic-typec driver, we need to register a corresponding drm_bridge for this device to be able to receive the OOB hotplug event sent to the corresponding DRM connector. Reception of the hotplug event is implemented by [1], but there is no direct dependency on that patchset. This series implements the remaining parts: registration of the drm_bridge and setting of the proper destination for the OOB hotplug event. [1] https://patchwork.freedesktop.org/series/120393/ Changes since v2: - Reworded commit message for the first patch to explicitly mention that the "displayport" OF property was rejected (Bjorn) - Removed several #ifdefs from the qcom-pmic-typec patch (Bryan, Konrad, Greg K-H) Changes since v1: - Properly handle CONFIG_DRM dependency. Disallow building DRM as a module if qcom-pmic-typec driver is built-in (Bryan). Dmitry Baryshkov (2): usb: typec: altmodes/displayport: add support for embedded DP cases usb: typec: qcom-pmic-typec: register drm_bridge drivers/usb/typec/altmodes/displayport.c | 5 ++- drivers/usb/typec/tcpm/Kconfig | 1 + drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 35 +++++++++++++++++++ 3 files changed, 40 insertions(+), 1 deletion(-)
Comments
On Fri, 28 Jul 2023 at 13:14, Guenter Roeck <linux@roeck-us.net> wrote: > > On 7/28/23 03:08, Dmitry Baryshkov wrote: > > To enable DisplayPort on the platforms supported by qcom-pmic-typec > > driver, we need to register a corresponding drm_bridge for this device > > to be able to receive the OOB hotplug event sent to the corresponding > > DRM connector. > > > > Reception of the hotplug event is implemented by [1], but there is no > > direct dependency on that patchset. This series implements the remaining > > parts: registration of the drm_bridge and setting of the proper > > destination for the OOB hotplug event. > > > > [1] https://patchwork.freedesktop.org/series/120393/ > > > > Changes since v2: > > - Reworded commit message for the first patch to explicitly mention that > > the "displayport" OF property was rejected (Bjorn) > > - Removed several #ifdefs from the qcom-pmic-typec patch (Bryan, Konrad, > > Greg K-H) > > > > Changes since v1: > > - Properly handle CONFIG_DRM dependency. Disallow building DRM as a > > module if qcom-pmic-typec driver is built-in (Bryan). > > config TYPEC_QCOM_PMIC > tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver" > depends on ARCH_QCOM || COMPILE_TEST > + depends on DRM || DRM=n > > This disallows building TYPEC_QCOM_PMIC into the kernel if DRM is built > as module, which is pretty much the opposite of what is claimed above. > It does not affect DRM at all. > > Not that it matters much, but I find it confusing if the change log > claims to do the opposite of what the code is doing. Ack. If there is a v4 I'll fix the changelog to invert the condition. > > Guenter > > > > > Dmitry Baryshkov (2): > > usb: typec: altmodes/displayport: add support for embedded DP cases > > usb: typec: qcom-pmic-typec: register drm_bridge > > > > drivers/usb/typec/altmodes/displayport.c | 5 ++- > > drivers/usb/typec/tcpm/Kconfig | 1 + > > drivers/usb/typec/tcpm/qcom/qcom_pmic_typec.c | 35 +++++++++++++++++++ > > 3 files changed, 40 insertions(+), 1 deletion(-) > > >
On Fri, Jul 28, 2023 at 01:19:36PM +0300, Dmitry Baryshkov wrote: > On Fri, 28 Jul 2023 at 13:14, Guenter Roeck <linux@roeck-us.net> wrote: > > > > On 7/28/23 03:08, Dmitry Baryshkov wrote: > > > To enable DisplayPort on the platforms supported by qcom-pmic-typec > > > driver, we need to register a corresponding drm_bridge for this device > > > to be able to receive the OOB hotplug event sent to the corresponding > > > DRM connector. > > > > > > Reception of the hotplug event is implemented by [1], but there is no > > > direct dependency on that patchset. This series implements the remaining > > > parts: registration of the drm_bridge and setting of the proper > > > destination for the OOB hotplug event. > > > > > > [1] https://patchwork.freedesktop.org/series/120393/ > > > > > > Changes since v2: > > > - Reworded commit message for the first patch to explicitly mention that > > > the "displayport" OF property was rejected (Bjorn) > > > - Removed several #ifdefs from the qcom-pmic-typec patch (Bryan, Konrad, > > > Greg K-H) > > > > > > Changes since v1: > > > - Properly handle CONFIG_DRM dependency. Disallow building DRM as a > > > module if qcom-pmic-typec driver is built-in (Bryan). > > > > config TYPEC_QCOM_PMIC > > tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver" > > depends on ARCH_QCOM || COMPILE_TEST > > + depends on DRM || DRM=n > > > > This disallows building TYPEC_QCOM_PMIC into the kernel if DRM is built > > as module, which is pretty much the opposite of what is claimed above. > > It does not affect DRM at all. > > > > Not that it matters much, but I find it confusing if the change log > > claims to do the opposite of what the code is doing. > > Ack. If there is a v4 I'll fix the changelog to invert the condition. Please fix. thanks, greg k-h