mbox series

[v3,0/5] Staging: rtl8192e: Function name cleanup series 1

Message ID 20230728054742.622297-1-tdavies@darkphysics.net
Headers
Series Staging: rtl8192e: Function name cleanup series 1 |

Message

Tree Davies July 28, 2023, 5:47 a.m. UTC 
  Rename functions to fix checkpatch warning: Avoid CamelCase


Changelist:
v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
v2: Sent to mailing list via git send-email, patches are the same.

Tree Davies (5):
  Staging: rtl8192e: Rename function ActivateBAEntry
  Staging: rtl8192e: Rename function DeActivateBAEntry
  Staging: rtl8192e: Rename function TxTsDeleteBA
  Staging: rtl8192e: Rename function RxTsDeleteBA
  Staging: rtl8192e: Rename function ResetBaEntry

 drivers/staging/rtl8192e/rtl819x_BAProc.c | 44 +++++++++++------------
 drivers/staging/rtl8192e/rtl819x_TSProc.c |  6 ++--
 drivers/staging/rtl8192e/rtllib.h         |  2 +-
 3 files changed, 26 insertions(+), 26 deletions(-)

Comments

Tree Davies July 28, 2023, 6:27 a.m. UTC | #1 
On Fri, Jul 28, 2023 at 08:16:03AM +0200, Philipp Hortmann wrote:
> On 7/28/23 07:47, Tree Davies wrote:
> > Rename functions to fix checkpatch warning: Avoid CamelCase
> > 
> > 
> > Changelist:
> > v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
> > v2: Sent to mailing list via git send-email, patches are the same.
> > 
> > Tree Davies (5):
> >    Staging: rtl8192e: Rename function ActivateBAEntry
> >    Staging: rtl8192e: Rename function DeActivateBAEntry
> >    Staging: rtl8192e: Rename function TxTsDeleteBA
> >    Staging: rtl8192e: Rename function RxTsDeleteBA
> >    Staging: rtl8192e: Rename function ResetBaEntry
> > 
> >   drivers/staging/rtl8192e/rtl819x_BAProc.c | 44 +++++++++++------------
> >   drivers/staging/rtl8192e/rtl819x_TSProc.c |  6 ++--
> >   drivers/staging/rtl8192e/rtllib.h         |  2 +-
> >   3 files changed, 26 insertions(+), 26 deletions(-)
> > 
> Hi Tree,
> 
> those patches have been accepted and cannot be applied again.
> 

Hi Philipp,

Right, patch #5 was not accepted though. Grep asked to fix it up.
I thought that because it was part of that series I was supposed to
resend as new version.
 
Tree


> commit c928e84ce577262da288c0178c8c77620ba8b430 (HEAD -> staging-testing,
> origin/staging-testing)
> Author: Tree Davies <tdavies@darkphysics.net>
> Date:   Wed Jul 26 23:19:47 2023 -0700
> 
>     Staging: rtl8192e: Rename function RxTsDeleteBA
> 
>     Rename function RxTsDeleteBA to rx_ts_delete_ba in order to Fix
> checkpatch
>     warning: Avoid CamelCase
> 
>     Signed-off-by: Tree Davies <tdavies@darkphysics.net>
>     Link:
> https://lore.kernel.org/r/20230727061948.579480-5-tdavies@darkphysics.net
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> commit 7b31905582358d566332182653a4e5552dba1574
> Author: Tree Davies <tdavies@darkphysics.net>
> Date:   Wed Jul 26 23:19:46 2023 -0700
> 
>     Staging: rtl8192e: Rename function TxTsDeleteBA
> 
>     Rename function TxTsDeleteBA to tx_ts_delete_ba in order to Fix
> checkpatch
>     warning: Avoid CamelCase
> 
>     Signed-off-by: Tree Davies <tdavies@darkphysics.net>
>     Link:
> https://lore.kernel.org/r/20230727061948.579480-4-tdavies@darkphysics.net
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> commit 8dd56eaa9450fb19f6bcc73956b3b1477331d28b
> Author: Tree Davies <tdavies@darkphysics.net>
> Date:   Wed Jul 26 23:19:45 2023 -0700
> 
>     Staging: rtl8192e: Rename function DeActivateBAEntry
> 
>     Rename function DeActivateBAEntry to deactivate_ba_entry in order to Fix
>     checkpatch warning: Avoid CamelCase
> 
>     Signed-off-by: Tree Davies <tdavies@darkphysics.net>
>     Link:
> https://lore.kernel.org/r/20230727061948.579480-3-tdavies@darkphysics.net
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> commit ca77687ae3f6d65fb26a0e1f93b54753af3581fc
> Author: Tree Davies <tdavies@darkphysics.net>
> Date:   Wed Jul 26 23:19:44 2023 -0700
> 
>     Staging: rtl8192e: Rename function ActivateBAEntry
> 
>     Rename function ActivateBAEntry to activate_ba_entry in order to Fix
>     checkpatch warning: Avoid CamelCase
> 
>     Signed-off-by: Tree Davies <tdavies@darkphysics.net>
>     Link:
> https://lore.kernel.org/r/20230727061948.579480-2-tdavies@darkphysics.net
>     Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> 
> Bye Philipp
Dan Carpenter July 28, 2023, 6:49 a.m. UTC | #2 
On Thu, Jul 27, 2023 at 11:27:37PM -0700, Tree Davies wrote:
> On Fri, Jul 28, 2023 at 08:16:03AM +0200, Philipp Hortmann wrote:
> > On 7/28/23 07:47, Tree Davies wrote:
> > > Rename functions to fix checkpatch warning: Avoid CamelCase
> > > 
> > > 
> > > Changelist:
> > > v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
> > > v2: Sent to mailing list via git send-email, patches are the same.
> > > 
> > > Tree Davies (5):
> > >    Staging: rtl8192e: Rename function ActivateBAEntry
> > >    Staging: rtl8192e: Rename function DeActivateBAEntry
> > >    Staging: rtl8192e: Rename function TxTsDeleteBA
> > >    Staging: rtl8192e: Rename function RxTsDeleteBA
> > >    Staging: rtl8192e: Rename function ResetBaEntry
> > > 
> > >   drivers/staging/rtl8192e/rtl819x_BAProc.c | 44 +++++++++++------------
> > >   drivers/staging/rtl8192e/rtl819x_TSProc.c |  6 ++--
> > >   drivers/staging/rtl8192e/rtllib.h         |  2 +-
> > >   3 files changed, 26 insertions(+), 26 deletions(-)
> > > 
> > Hi Tree,
> > 
> > those patches have been accepted and cannot be applied again.
> > 
> 
> Hi Philipp,
> 
> Right, patch #5 was not accepted though. Grep asked to fix it up.
> I thought that because it was part of that series I was supposed to
> resend as new version.

But now you understand what to do, right?  Pull the latest code and do
all your work on top of that.  Don't resend the stuff which was applied.

regards,
dan carpenter
Tree Davies July 28, 2023, 7:08 a.m. UTC | #3 
On Fri, Jul 28, 2023 at 09:49:26AM +0300, Dan Carpenter wrote:
> On Thu, Jul 27, 2023 at 11:27:37PM -0700, Tree Davies wrote:
> > On Fri, Jul 28, 2023 at 08:16:03AM +0200, Philipp Hortmann wrote:
> > > On 7/28/23 07:47, Tree Davies wrote:
> > > > Rename functions to fix checkpatch warning: Avoid CamelCase
> > > > 
> > > > 
> > > > Changelist:
> > > > v3: Changed patch #5, Rename global function ResetBaEntry to rtllib_reset_ba_entry
> > > > v2: Sent to mailing list via git send-email, patches are the same.
> > > > 
> > > > Tree Davies (5):
> > > >    Staging: rtl8192e: Rename function ActivateBAEntry
> > > >    Staging: rtl8192e: Rename function DeActivateBAEntry
> > > >    Staging: rtl8192e: Rename function TxTsDeleteBA
> > > >    Staging: rtl8192e: Rename function RxTsDeleteBA
> > > >    Staging: rtl8192e: Rename function ResetBaEntry
> > > > 
> > > >   drivers/staging/rtl8192e/rtl819x_BAProc.c | 44 +++++++++++------------
> > > >   drivers/staging/rtl8192e/rtl819x_TSProc.c |  6 ++--
> > > >   drivers/staging/rtl8192e/rtllib.h         |  2 +-
> > > >   3 files changed, 26 insertions(+), 26 deletions(-)
> > > > 
> > > Hi Tree,
> > > 
> > > those patches have been accepted and cannot be applied again.
> > > 
> > 
> > Hi Philipp,
> > 
> > Right, patch #5 was not accepted though. Grep asked to fix it up.
> > I thought that because it was part of that series I was supposed to
> > resend as new version.
> 
> But now you understand what to do, right?  Pull the latest code and do
> all your work on top of that.  Don't resend the stuff which was applied.
> 
> regards,
> dan carpenter
>

Understood. Thanks.
regards,
Tree