From patchwork Fri Jul 28 02:39:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tinghan Shen X-Patchwork-Id: 12736 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:918b:0:b0:3e4:2afc:c1 with SMTP id s11csp156090vqg; Thu, 27 Jul 2023 20:03:01 -0700 (PDT) X-Google-Smtp-Source: APBJJlEGnPdwb3i6L2r12Fhk4Waz+518/Vf6RaXCtOD0En1dSXp9Cjp4TGYxjnqHlg92Ubz1E4+v X-Received: by 2002:a05:6a20:104e:b0:122:550f:aad4 with SMTP id gt14-20020a056a20104e00b00122550faad4mr440818pzc.9.1690513381060; Thu, 27 Jul 2023 20:03:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690513381; cv=none; d=google.com; s=arc-20160816; b=vcDGOcQvHS2K+/NuYOonRrzdjB8PGtNj+r06jUtR6y313/lu5fyyE9lLEBUgyM0KF/ CMMnhBGjcETjAJcCZ5PnZoeU/We9tV9+88noRJq37rqJKMd6QkKCYotnOH9L2SeZUDCV sOfZc0q5GHjfZv1U7F8w8A9+CHU/WvPm+JU0u5hpjhPitTqMbs+97omQXElU3J6K+lqc S1GIko6VaaUYyqtnnVS5V+bpiQJ509EIvYqEhY/1Q84npcaaoQ3W94CCsK0b6AcVSRXg 3OfImjU1HKOf5F4480WO4r0nmE35zE/zFkXKuKDMydKVYfdoUWgJKOgle9+dKBENUMFr z9lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=OEqj/l/j1mQY7VQhAqMfkpQJ66d4A/R6tPcAhn3GEgM=; fh=fiUFlTmdXAnPLHH0bIyIc4brKi/t2/OmtpRJQ8s00Ug=; b=X65KUpVRujrt6aN51HHb7slaclRrru2/5DTVc8dk0dk+q79yGGWPivxT/7cH2JU478 49lcNrT/J//+AIoMS424WO0K/9mYvuGcgSYOqNGCNdBZ3bPPXCP5sVzbmYwmzgk2mdhP vs3gYZjttMmbiQ1WjRcSrkF05Ajx5jDfmvrWFs//KnhIlmP9IyJZGxvLM7VfqQtbEdim s0aJKwHBR4RFW7K7Kse+E2pZPirB7iDYvlsIXPsQWOLzOtci9SUfgYsZqjixb9zjhxLz 1ggWbD1PzMPkd0NeWwcXAjDeVv/76vZGc2PR5Ump7B1aXdCEDbRbYHyWg3sXcZ0Pyckw wqEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b="b/uAUPR5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c186-20020a621cc3000000b006765f19e46bsi1938802pfc.147.2023.07.27.20.02.45; Thu, 27 Jul 2023 20:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@mediatek.com header.s=dk header.b="b/uAUPR5"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232810AbjG1CkU (ORCPT + 99 others); Thu, 27 Jul 2023 22:40:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232709AbjG1CkO (ORCPT ); Thu, 27 Jul 2023 22:40:14 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE70630E1; Thu, 27 Jul 2023 19:40:08 -0700 (PDT) X-UUID: 0d701ed42cf011ee9cb5633481061a41-20230728 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=OEqj/l/j1mQY7VQhAqMfkpQJ66d4A/R6tPcAhn3GEgM=; b=b/uAUPR5wINzvPfwLAAiQcTsRkVX7p6RAg/9Hfo3yQDO9DicdFmXtc/diTGOsp6JYOgweGs+lx6iK4cLfKX3GrrN5Y11IDE0msUJDbvPJoPv7YaBCTPVP3BGgI/iyJKuWwrPd5ckSR9bD/YfhK2v2eR7eL5jXhryDsRVwca2Ovc=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.30,REQID:18ba3d7a-31b4-4e84-a454-2fd32f9809d0,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:95 X-CID-INFO: VERSION:1.1.30,REQID:18ba3d7a-31b4-4e84-a454-2fd32f9809d0,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:95,FILE:0,BULK:0,RULE:Spam_GS981B3D,ACTION :quarantine,TS:95 X-CID-META: VersionHash:1fcc6f8,CLOUDID:d2026ad2-cd77-4e67-bbfd-aa4eaace762f,B ulkID:230728104003MOR57EKC,BulkQuantity:0,Recheck:0,SF:28|17|19|48|38|29,T C:nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 ,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR,TF_CID_SPAM_SDM,TF_CID_SPAM_ASC,TF_CID_SPAM_FAS, TF_CID_SPAM_FSD X-UUID: 0d701ed42cf011ee9cb5633481061a41-20230728 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 2059333360; Fri, 28 Jul 2023 10:40:02 +0800 Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by mtkmbs13n1.mediatek.inc (172.21.101.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Fri, 28 Jul 2023 10:40:01 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Fri, 28 Jul 2023 10:40:01 +0800 From: Tinghan Shen To: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Tinghan Shen CC: , , , , , Subject: [PATCH v16 00/14] Add support for MT8195 SCP 2nd core Date: Fri, 28 Jul 2023 10:39:45 +0800 Message-ID: <20230728023959.12293-1-tinghan.shen@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 X-MTK: N X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772631759351966245 X-GMAIL-MSGID: 1772631759351966245 The mediatek remoteproc driver currently only allows bringing up a single core SCP, e.g. MT8183. It also only bringing up the 1st core in SoCs with a dual-core SCP, e.g. MT8195. This series support to bring-up the 2nd core of the dual-core SCP. v15 -> v16: 1. fix the checkpatch warning at patchset 1 2. Move changes on scp_probe() to the new added patchset 6 3. revise platform_set_drvdata() at patchset 8 4. fix commit message at patchset 9 v15 -> v14: 1. Use the common SCP registers in struct mtk_scp_of_cluster instead of copy it to struct mtk_scp at patchset 5 2. Use platform_set_drvdata instead of platform_device_add_data at patchset 5 3. Rename l2tcm_lock to cluster_lock at patchset 8 4. Check l2tcm_refcnt value before decreasing at patchset 8 5. Revise the commit message at patchset 11 v13 -> v14: 1. add review tag to patchset 1,6 2. exchange the order of sram power on and reset assert in mt8195_scp_c1_before_load at patchset 2 3. Use ERR_CAST in patchset 5 4. Re-write patchset 7 to remove dependency between core 0 and core 1 5. Add patch set 10 to report watchdot timeout to all cores v12 -> v13: 1. replace subdevice with new mediatek scp operations in patchset 7 2. add review tag to patchset 3 3. modify mediatek,scp phandle name of video-codec@18000000 at patchset 11 v11 -> v12: 1. add scp_add_single/multi_core() to patchset 6 2. remove unused comment in patchset 6 3. rename list name from mtk_scp_cluster to mtk_scp_list 4. rewrite the multi-core probe flow 5. disable rproc->autoboot and boot rproc by request_firmware_nowait at patchset 7 6. remove patchset 7 review tag v10 -> v11: 1. rewrite patchset 5 to probe single-core SCP with the cluster list 2. Also in patchset 5, move the pointer of mtk_scp object from the platform data property to the driver data property 3. move the appearance of mtk_scp cluster property to patcheset 7 v9 -> v10: 1. move the global mtk_scp list into the platform device driver data structure 2. remove an unnecessary if() condition v8 -> v9: 1. initialize l1tcm_size/l1tcm_phys at patchset 05/11 2. rewrite patchset 06/11 to unify the flow and remove hacks v7 -> v8: 1. update the node name of mt8192 asurada SCP rpmsg subnode 2. squash register definitions into driver patches 3. initialize local variables on the declaration at patch v8 06/11 v6 -> v7: 1. merge the mtk_scp_cluster struct into the mtk_scp structure at the "Probe multi-core SCP" patch v5 -> v6: 1. move the mtk_scp_of_regs structure from mtk_common.h to mtk_scp.c 2. rename the SCP core 0 label from 'scp' to 'scp_c0' v4 -> v5: 1. move resource release actions to the platform driver remove operation 2. fix dual-core watchdog handling v3 -> v4: 1. change the representation of dual-core SCP in dts file and update SCP yaml 2. rewrite SCP driver to reflect the change of dts node 3. drop 'remove redundant call of rproc_boot for SCP' in v3 for further investigation v2 -> v3: 1. change the representation of dual-core SCP in dts file and update SCP yaml 2. rewrite SCP driver to reflect the change of dts node 3. add SCP core 1 node to mt8195.dtsi 4. remove redundant call of rproc_boot for SCP 5. refine IPI error message v1 -> v2: 1. update dt-binding property description 2. remove kconfig for scp dual driver 3. merge mtk_scp_dual.c and mtk_scp_subdev.c to mtk_scp.c Tinghan Shen (14): dt-bindings: remoteproc: mediatek: Improve the rpmsg subnode definition arm64: dts: mediatek: Update the node name of SCP rpmsg subnode dt-bindings: remoteproc: mediatek: Support MT8195 dual-core SCP remoteproc: mediatek: Add MT8195 SCP core 1 operations remoteproc: mediatek: Extract SCP common registers remoteproc: mediatek: Revise SCP rproc initialization flow for multi-core SCP remoteproc: mediatek: Probe SCP cluster on single-core SCP remoteproc: mediatek: Probe SCP cluster on multi-core SCP remoteproc: mediatek: Remove dependency of MT8195 SCP L2TCM power control on dual-core SCP remoteproc: mediatek: Setup MT8195 SCP core 1 SRAM offset remoteproc: mediatek: Handle MT8195 SCP core 1 watchdog timeout remoteproc: mediatek: Report watchdog crash to all cores remoteproc: mediatek: Refine ipi handler error message arm64: dts: mediatek: mt8195: Add SCP 2nd core .../bindings/remoteproc/mtk,scp.yaml | 176 +++++- .../arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 2 +- .../boot/dts/mediatek/mt8192-asurada.dtsi | 2 +- .../boot/dts/mediatek/mt8195-cherry.dtsi | 6 +- arch/arm64/boot/dts/mediatek/mt8195.dtsi | 34 +- drivers/remoteproc/mtk_common.h | 39 +- drivers/remoteproc/mtk_scp.c | 534 ++++++++++++++---- drivers/remoteproc/mtk_scp_ipi.c | 4 +- 8 files changed, 651 insertions(+), 146 deletions(-)