Message ID | 20230727154108.308320-1-umang.jain@ideasonboard.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a985:0:b0:3e4:2afc:c1 with SMTP id t5csp1211381vqo; Thu, 27 Jul 2023 09:16:55 -0700 (PDT) X-Google-Smtp-Source: APBJJlFX+METuh1ykWTi5TtfJrRk/hyugx5qwt9eEMgVbMexrcOvxDWGkMdNNo0Awjg1WYmncCnF X-Received: by 2002:a17:906:209d:b0:99b:c8bf:3f06 with SMTP id 29-20020a170906209d00b0099bc8bf3f06mr3485092ejq.24.1690474615585; Thu, 27 Jul 2023 09:16:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690474615; cv=none; d=google.com; s=arc-20160816; b=uc+8QNDE4vnWt8dAQ/CpiafiLJF4uBFT0mXKtkZCDBpOn+Epni4E9JTy0HskY/m5lk yfRQ13oDoWfe1SPjERon03mtpURyCmAS5EOp+20gc9+yV4ZmykBEDUD+RMzw0wTkUAn2 HQYhW1V05+ZAzJQgRkky0oqnKMfTQffi6d7zblZxV0mM9RkYpUirV6nHvaZQQb67J8j5 bKgf+2sw7YaBtSwXoV5QKRodFITRBk1ca4yqDc8ij4GYyjbbzjIWUSJzpJG1kMmnaREB gPKgrh/pZg3Crp2SKGIX2dYYfZ8C+EqIRcNu7DSGaMxa97cDWmI5cBmOpsKoRQ5l/4i9 Z8qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=btcc5VLTmC91BIplqqXqdoa5dHFbbrLiUCqbPXg5eCs=; fh=cI6VfmMXZHgD/HmDvqSv3ZhlnYud12Bs0GhgU/QG248=; b=cNM0MJcbGtTIMpE+XrvqttJMc3aX1AMqSNWgZ+uNGJtODpczwgUwZFasY4Dh9CyGwS uoeNSG84t+q3b+UmKgEbTAUFCuJUU5F7MshpPCl6zatuzvTAKiKPVIBb8Eg+GsSqLd/J FnS5nWMP8S/tgDri60bACm5iN4KDpybkIOcx83ws4cUQUaafm9XIEJgziezqZO1KUG63 YDczFW7f+FRDGl6/NzWqZAMIvgD9c3txI5hrh0OEfntIQoiJzNsCXRFR2HdTmTukkd2b FZ1PvoL+PsNfAn+hmBBoouCEySNk5xigkZRCA7LWpb+q/8ZAnmZwhlAgD0FweDUlGmWk h6UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=AIMA6KJF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rl19-20020a170907217300b00988f21df36esi1264630ejb.594.2023.07.27.09.16.30; Thu, 27 Jul 2023 09:16:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=AIMA6KJF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232954AbjG0Pl0 (ORCPT <rfc822;hanasaki@gmail.com> + 99 others); Thu, 27 Jul 2023 11:41:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231839AbjG0PlY (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 27 Jul 2023 11:41:24 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21113B4; Thu, 27 Jul 2023 08:41:24 -0700 (PDT) Received: from umang.jainideasonboard.com (unknown [103.86.18.216]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 622594A9; Thu, 27 Jul 2023 17:40:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1690472422; bh=Xf++ltgPgr14drE6ifgMA6GI7A5yNuwTe9sdwBYtmuY=; h=From:To:Cc:Subject:Date:From; b=AIMA6KJFCarKLHwXBvAE2Tjr20weaLe5Ts6e7Ca20a3iK1iDgMBDfqBw/3B9JDkiX dWkKofme3/OTcTSgfVNB0MNiUhKYd+Kw95/i2jfgf52E4LGfLEo2Xy61Tbw6ztvLRt hlLYI7wJhoOrWLJDdh4kOSuZW54wNe1yTiWgVHoI= From: Umang Jain <umang.jain@ideasonboard.com> To: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Lee Jackson <lee.jackson@arducam.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Sakari Ailus <sakari.ailus@linux.intel.com>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, Shawn Tu <shawnx.tu@intel.com>, Nicholas Roth <nicholas@rothemail.net>, Mikhail Rudenko <mike.rudenko@gmail.com>, kieran.bingham@ideasonboard.com, Marco Felsch <m.felsch@pengutronix.de>, jacopo.mondi@ideasonboard.com, Umang Jain <umang.jain@ideasonboard.com> Subject: [PATCH 0/2] media: i2c: imx519: Support for Sony IMX519 sensor Date: Thu, 27 Jul 2023 21:11:06 +0530 Message-Id: <20230727154108.308320-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772591110494389983 X-GMAIL-MSGID: 1772591110494389983 |
Series |
media: i2c: imx519: Support for Sony IMX519 sensor
|
|
Message
Umang Jain
July 27, 2023, 3:41 p.m. UTC
Series adds driver support for Sony IMX519 sensor. Lee, can do add S-o-B tags please to these patches since I've updated your email IDs at various places from info@ to lee.jackson@. Thanks! Lee Jackson (2): media: dt-bindings: imx519: Add IMX519 DT bindings media: i2c: imx519: Support for the Sony IMX519 sensor .../bindings/media/i2c/sony,imx519.yaml | 113 + MAINTAINERS | 8 + drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile | 1 + drivers/media/i2c/imx519.c | 2134 +++++++++++++++++ 5 files changed, 2267 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml create mode 100644 drivers/media/i2c/imx519.c
Comments
Hi Umang, Quoting Umang Jain (2023-07-27 16:41:06) > Series adds driver support for Sony IMX519 sensor. > > Lee, can do add S-o-B tags please to these patches > since I've updated your email IDs at various places from > info@ to lee.jackson@. Can you dig and find out what your start point was here please? This series should already be numbered at least v6, there are 5 previous postings. The most recent of which was already Signed off by 'lee.jackson@arducam.com' So that makes me weary that v5 was not used as the start point for this refresh. Previous versions are identifiable here: - https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=imx519&archive=both&delegate= Could you check through any previous review comments and make sure they have all been addressed too please? It would be useful if the cover letter or patch described a changelog from the previous version too to identify what has been updated. I see the kernel test robot reported failures based on missing dependencies. It's helpful to list any dependency information here in the cover letter too. -- Kieran > > Thanks! > > Lee Jackson (2): > media: dt-bindings: imx519: Add IMX519 DT bindings > media: i2c: imx519: Support for the Sony IMX519 sensor > > .../bindings/media/i2c/sony,imx519.yaml | 113 + > MAINTAINERS | 8 + > drivers/media/i2c/Kconfig | 11 + > drivers/media/i2c/Makefile | 1 + > drivers/media/i2c/imx519.c | 2134 +++++++++++++++++ > 5 files changed, 2267 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > create mode 100644 drivers/media/i2c/imx519.c > > -- > 2.39.1 >
On Fri, Jul 28, 2023 at 09:52:08AM +0100, Kieran Bingham wrote: > Hi Umang, > > Quoting Umang Jain (2023-07-27 16:41:06) > > Series adds driver support for Sony IMX519 sensor. > > > > Lee, can do add S-o-B tags please to these patches > > since I've updated your email IDs at various places from > > info@ to lee.jackson@. > > Can you dig and find out what your start point was here please? > > This series should already be numbered at least v6, there are 5 previous > postings. The most recent of which was already Signed off by > 'lee.jackson@arducam.com' So that makes me weary that v5 was not used as > the start point for this refresh. > > Previous versions are identifiable here: > > - https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=imx519&archive=both&delegate= > > Could you check through any previous review comments and make sure they > have all been addressed too please? > > It would be useful if the cover letter or patch described a changelog > from the previous version too to identify what has been updated. I second this. A summary of the major changes in the cover letter plus a detailed changelog in each patch is invaluable for review. > I see the kernel test robot reported failures based on missing > dependencies. > > It's helpful to list any dependency information here in the cover > letter too. You can use the --base argument to git-format-patch to record the base commit, and point in the cover letter to a public branch where the series can be found. > > Thanks! > > > > Lee Jackson (2): > > media: dt-bindings: imx519: Add IMX519 DT bindings > > media: i2c: imx519: Support for the Sony IMX519 sensor > > > > .../bindings/media/i2c/sony,imx519.yaml | 113 + > > MAINTAINERS | 8 + > > drivers/media/i2c/Kconfig | 11 + > > drivers/media/i2c/Makefile | 1 + > > drivers/media/i2c/imx519.c | 2134 +++++++++++++++++ > > 5 files changed, 2267 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx519.yaml > > create mode 100644 drivers/media/i2c/imx519.c