From patchwork Tue Aug 8 11:43:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13289 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c44e:0:b0:3f2:4152:657d with SMTP id w14csp2257039vqr; Tue, 8 Aug 2023 09:59:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEz69Jxx+T+RcdJ3fxuKSPi2bMloqbT3rwUybZhOl6e2hiZJyGxESCSAnPLWeX6gl7b0Y7+ X-Received: by 2002:aa7:c542:0:b0:523:37f0:2d12 with SMTP id s2-20020aa7c542000000b0052337f02d12mr560288edr.17.1691513953881; Tue, 08 Aug 2023 09:59:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1691513953; cv=none; d=google.com; s=arc-20160816; b=J8NOWl7ilxwVZGhaGABYSDGWh9if0gjQThTTmKx/tK3J6lcEQS5j6G/i+LuJsry3k+ HNXRfsjgVcPUU42ajHnp8gJGybG6deEw0GPapj+rKPdUcNaV5/2iYj2WISigWvJkEue9 OQAWRUDXSFCxWVIxpp+TQBsskBUKvZC6lkdsfGgfic/hcJcAafNF5/mhn17JEhV68vgx p1GORnLMhPgGR9fQXw+hoAc0znvkKOu+W13R0pXrivG9j0rVtjGnKVyR6nXOKoaJUFLV qYxGhIQ0+8jqn0NmLXRu1OmcofVMC4F8rb9Hx8vMNw77+kyhRSV7a58nBmRhFlr5qVrX 6TJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:content-transfer-encoding:mime-version :message-id:date:subject:from:dkim-signature; bh=/O5Y0Ab6iaBrA/9OXoJTEQWxJ6aDOXFu3sTBHt6SbVg=; fh=eQYZoDkT5yiXC4FOuYG6Kem76e5j3IG0APJeW7cmDrc=; b=ZWoIBIxsdGKjAG5biuEb4kCSdxh11JJwUwkzLnRzFoDNR8D2e+UdEH4Q9qDv6DC1AE 9PN5TH0ZBLNv8ZRp7eqj+iBKVcUBCGVjJILcENRWVIWCDEXVTUqB79DczMjCTXHzKjuV R3icAMU7ISZBsSHyX8jHWPVET6wC2K/fU6Nj0RgHPrZvYins7O/HFJu1b9uSD3y0qFxT /GEbO97Wjl5qyfo67ciLDVW6huS47YdGM8joZtVe+0mOuLa+kz9jGYUvzGuRHBfSEBTY NlWckE9vPC+5w44Z7N3yi8JvTMFOI8ceMSBlMnN3ePA70qOAoJdJH4y7ZTdRg+nGc2Jn luvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yr4xqwNT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t5-20020a056402020500b005222ae088b1si7146212edv.271.2023.08.08.09.58.49; Tue, 08 Aug 2023 09:59:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=yr4xqwNT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231229AbjHHQoY (ORCPT + 99 others); Tue, 8 Aug 2023 12:44:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232268AbjHHQnc (ORCPT ); Tue, 8 Aug 2023 12:43:32 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 440859195 for ; Tue, 8 Aug 2023 08:55:50 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-99bdf08860dso1468081166b.0 for ; Tue, 08 Aug 2023 08:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1691510121; x=1692114921; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=/O5Y0Ab6iaBrA/9OXoJTEQWxJ6aDOXFu3sTBHt6SbVg=; b=yr4xqwNTrUlfY2U6bPxFgKQbGVTSdJp40271+JSO2cAYoDUlh/lTgSSw8C54fgxbqh WpQufT16w8TSgqrFeqkAAXcxh2f4uPB1qr3Dpzy6p9skRsBtP1jlScsAHvAwyAxUFrhs UwAGh+b2HkY0mIFoR+Nv9xkeJtYkWefTkM6PHYyDg45NrMWZnp2KmWP/1SUo4MJHVUul +INtUQPVwbSSkPhodaWqr4Ldeyb4oXWbt1eyRK2n9uYhy9Rl0yDTxODUCo+Zr1GEpGS8 De2VNmwTo0clPGysZlMQ29XVtflKe5WJah6SvQQdAmFTBWYixjls5I3+mEbyvmQ3spFZ x2ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691510121; x=1692114921; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/O5Y0Ab6iaBrA/9OXoJTEQWxJ6aDOXFu3sTBHt6SbVg=; b=EjRC7Qipus8FwaP7yk27PEStEfSP2kMpufWEoi1WaongJkDRX18Q5k3R0PseAhbytZ DctYhcjiRC/CzjiCbBWHR8v9OpEA9X6xsGNMxSJlSgBEQSbuRWX9lGVf5wJA2HrK/n6K XOY3EdGH5q0KXpKWjS3KYrXdqgy58PcVqyjlTgEjNqyamLC/DqOlzYcNiLMo3OApA9Zh WcbNH5XiIt0TUCcWIxZ1cg4YY3hAdXIC5A/xsNVYZs6/X2oZVS0ckYfq1yw+jMBsXcIg TYtRCV+cwf7vO9WEGKoJvjSxptC4Dv9HssgBK7N4a2g33X4S9NVMgyxXgnZsVwZqYj0x rxEg== X-Gm-Message-State: AOJu0YwDjgUbM0qObHc6M8cWNpgkF0QDmStsnL5JMUaKv4ZGHAFzNOtI CBmR+Y4CS17NEHlGux1SlxcW5TW+l87qVnPCme0= X-Received: by 2002:a05:6512:360d:b0:4fe:b97:e361 with SMTP id f13-20020a056512360d00b004fe0b97e361mr2685997lfs.18.1691495015550; Tue, 08 Aug 2023 04:43:35 -0700 (PDT) Received: from [192.168.1.101] (abxi185.neoplus.adsl.tpnet.pl. [83.9.2.185]) by smtp.gmail.com with ESMTPSA id j20-20020ac253b4000000b004fbdba4b075sm1861679lfh.57.2023.08.08.04.43.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 04:43:34 -0700 (PDT) From: Konrad Dybcio Subject: [PATCH v3 00/10] Fix up icc clock rate calculation on some platforms Date: Tue, 08 Aug 2023 13:43:31 +0200 Message-Id: <20230726-topic-icc_coeff-v3-0-dee684d6cdd2@linaro.org> MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAGMq0mQC/4WNywrCMBQFf6VkbSQPm7au/A8RSW4Te6EkJalBK f130+5ciMs5cGYWkmxEm8i5Wki0GRMGX0AeKgKD9g9LsS9MBBOSNULROUwIFAHuEKxz1LBa9vW JdaZzpLyMTpaaqD0M5eef41jGKVqHrz1zvRUeMM0hvvdq5tv6O5A5ZVRyxVWnWMtbuIzodQzHE B9kk2XxRyCKoIWOg4JGsUZ9CdZ1/QC5gVttBQEAAA== To: Andy Gross , Bjorn Andersson , Georgi Djakov , Michael Turquette , Stephen Boyd Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Konrad Dybcio X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1691495013; l=2722; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=XAhr1GRTTz11VXNGM0HJcweTRyuP6Ic8MAO173kSZZo=; b=uU3qPRoERGY/xei0GUD/LmqbFzELs1Kt4lOdOOMFgQzXC/ob46KMRct1oyF2A/us51ZC0pd+d 4CWXccEf7nzCol5TgXFeAIurv4W1u961WTfupsjOxliRUIydPuFqn7E X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1773680935921639915 X-GMAIL-MSGID: 1773680935921639915 Certain platforms require that some buses (or individual nodes) make some additional changes to the clock rate formula, throwing in some magic, Qualcomm-defined coefficients, to account for "inefficiencies". Add the framework for it and utilize it on a couple SoCs. Signed-off-by: Konrad Dybcio --- Changes in v3: - Allocate the node bus clock on the stack, as dynamically allocating it actually wastes memory on systems with 64-bit pointers.. - Add the node bus clock struct member in the correct patch - Simplify using coefficients by only checking the node-level ones, and setting them equal to the bus-specific ones at probe if absent - Fix building on arm32 - Mention some references to the related downstream code - Link to v2: https://lore.kernel.org/r/20230726-topic-icc_coeff-v2-0-8c91c6c76076@linaro.org Changes in v2: - Use the (arguably less favourable but necessary for precission) 100/x instead of x/100 for ib coefficient, update values in consequent patches to reflect that - Rename "_percent" to "_coeff" because of /\ - Add the necessary code to support per-node clocks - Add the necessary code to support per-node coefficients - Hook up the CPUSS<->GNoC clock on QCM2290 - Update EBI node on QCM2290 - Link to v1: https://lore.kernel.org/r/20230726-topic-icc_coeff-v1-0-31616960818c@linaro.org --- Konrad Dybcio (10): interconnect: qcom: icc-rpm: Add AB/IB calculations coefficients interconnect: qcom: icc-rpm: Separate out clock rate calulcations interconnect: qcom: icc-rpm: Let nodes drive their own bus clock interconnect: qcom: icc-rpm: Check for node-specific rate coefficients interconnect: qcom: qcm2290: Hook up MAS_APPS_PROC's bus clock interconnect: qcom: qcm2290: Set AB coefficients interconnect: qcom: qcm2290: Update EBI channel configuration interconnect: qcom: sdm660: Set AB/IB coefficients interconnect: qcom: msm8996: Set AB/IB coefficients clk: qcom: smd-rpm: Move CPUSS_GNoC clock to interconnect drivers/clk/qcom/clk-smd-rpm.c | 16 +++++-- drivers/interconnect/qcom/icc-rpm-clocks.c | 6 +++ drivers/interconnect/qcom/icc-rpm.c | 76 +++++++++++++++++++++++++----- drivers/interconnect/qcom/icc-rpm.h | 15 ++++++ drivers/interconnect/qcom/msm8996.c | 8 +++- drivers/interconnect/qcom/qcm2290.c | 9 +++- drivers/interconnect/qcom/sdm660.c | 4 ++ 7 files changed, 115 insertions(+), 19 deletions(-) --- base-commit: 71cd4fc492ec41e4acd85e98bbf7a13753fc1e03 change-id: 20230726-topic-icc_coeff-b053d5409b9f Best regards,