From patchwork Tue Jul 25 18:04:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 12570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2371150vqg; Tue, 25 Jul 2023 03:27:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlEAVU/8PCjPkqbEY1bireB580wEiL/LZzOrKAwmHsHXMu61w+xoFuxw98Pj2tXamAibH1Me X-Received: by 2002:a17:906:2086:b0:991:fef4:bb7 with SMTP id 6-20020a170906208600b00991fef40bb7mr12611222ejq.73.1690280873705; Tue, 25 Jul 2023 03:27:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690280873; cv=none; d=google.com; s=arc-20160816; b=ZoFAeCZl4tRB1ALynxvjWrkt/G/flqfXevmmn67er/FGQ5pugJWHxpWk9KSxy6ltSa rEsftgINTzgb16zjhwyQ0OIhAskx5CuZtmWLiAToyB6JRVmi25FRV6oYUUzmChDaAf33 V1sBLi9rJPvzHkwvf+4dfszPC9Eoc1vKvX2Cv/uuhZowaaUydlpwe3QSeZxit5PGsuHF T0iEIZCsdlXIjbbKBTX78afmxAhh2JbJ33rGZwT46zZXC/8G57mwjDSAsBH3HbrxJO8J OPmqPYhBDCah1/pNUSQ38mTZaVSH+AIonWJc3kFS7r/HzQMkUHoqveAxT2bgYnhZOZkC vF1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Yy/nDAoQGLsw/5llRqWOqYB6mIP3KocZ/KT7XNfQ86M=; fh=0zX8MkeZhwj7F3yOeQkt2lukWIQJcBZJTqPdFT68mvc=; b=RtFFJ7WSec5PmsmUk9mTmPtepYXYLj1psr1znEThXm+BolJgc5osP3HzSt4h6gh0Qx Vobvk5cPquYXTImUFe2eKYNoCVqRJ9tfPacYQEkF/j3TEWs6UOhVz/v6GyN6CiwN4Knk exBf/zti2uFJzbgQRO9seC888kTvGHLGsM3OpSazFY4SREz3Ccyr0ToWpPDrriatpST8 YYFmWc/UobuZkwz+t+s+BEzV+ZkNCncZ8pc79WFK6Z7Kx0ol7fSXWYLJbUrQbs1JmZcm hXBWHLdCGt9BSzTlb8RS4uJ3/DKDF/wTDtoLqDsFmV+DViDYCzNGt3XE8oiWaxbyng1g NWlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d15-20020a170906174f00b009937cf92693si7404080eje.427.2023.07.25.03.27.29; Tue, 25 Jul 2023 03:27:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbjGYKF2 (ORCPT + 99 others); Tue, 25 Jul 2023 06:05:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233196AbjGYKFB (ORCPT ); Tue, 25 Jul 2023 06:05:01 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2FDB1FC2 for ; Tue, 25 Jul 2023 03:04:31 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4R9CLN17NLz4f3kKl for ; Tue, 25 Jul 2023 18:04:28 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgAXC+ksnr9kFkPOOg--.2821S2; Tue, 25 Jul 2023 18:04:28 +0800 (CST) From: Kemeng Shi To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: willy@infradead.org, baolin.wang@linux.alibaba.com, david@redhat.com, shikemeng@huaweicloud.com Subject: [PATCH RESEND 0/4] minor cleanups for compact lock functions in Date: Wed, 26 Jul 2023 02:04:52 +0800 Message-Id: <20230725180456.2146626-1-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 X-CM-TRANSID: Syh0CgAXC+ksnr9kFkPOOg--.2821S2 X-Coremail-Antispam: 1UD129KBjvdXoWrur47JryxKw45tw1UCF1xXwb_yoWftrb_Aa yxJa4Dtw15AFy5JFZ8CFs0yFykKFW8Gr1UJ3Z5Zr45Cr929F1kJanrZw4fXr1YqF9rWws8 Gw18Jw48uF17CjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxkFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28lY4IEw2IIxx k0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK 6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjc xK6I8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVAC Y4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVWUJV W8JwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI2 0VAGYxC7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrV AFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCI c40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267 AKxVWUJVW8JwCI42IY6xAIw20EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRi RwZDUUUUU== X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_00,DATE_IN_FUTURE_06_12, KHOP_HELO_FCRDNS,MAY_BE_FORGED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772387957476181049 X-GMAIL-MSGID: 1772387957476181049 Hi all, this series tries to remove repeact lock handle code in compaction. Patch 1-3 try to make compact_unlock_should_abort more common and can be used in both isolate_freepages_block and isolate_migratepages_block. Patch 4 adds a new compact lock function compact_unlock_irqrestore used along with existing compact_lock_irqsave to remove repeat code to do compact unlock. More details can be found in respective patches. Thanks! Kemeng Shi (4): mm/compaction: use "spinlock_t *" to record held lock in compact [un]lock functions mm/compaction: use "spinlock_t *" to record held lock in isolate_migratepages_block mm/compaction: use compact_unlock_should_abort in isolate_migratepages_block mm/compaction: add compact_unlock_irqrestore to remove repeat code mm/compaction.c | 85 ++++++++++++++++++------------------------------- 1 file changed, 31 insertions(+), 54 deletions(-)