From patchwork Tue Jul 25 14:23:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hugo Villeneuve X-Patchwork-Id: 12589 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2511995vqg; Tue, 25 Jul 2023 07:31:08 -0700 (PDT) X-Google-Smtp-Source: APBJJlHGC2k80tj1Z5qohLiTXDulRuz4l2fa/VHf1i8Ow+os99Q5ErR4S9ExUF4B+vEmPSu4jJEd X-Received: by 2002:a17:90b:4c42:b0:25c:18ad:6b82 with SMTP id np2-20020a17090b4c4200b0025c18ad6b82mr901267pjb.21.1690295467761; Tue, 25 Jul 2023 07:31:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690295467; cv=none; d=google.com; s=arc-20160816; b=shSjNkCJgEBQ/ubbwLLha2npaypdPkIv6a0wpauhg7VJS0NZpBRo9ASS4acMrvQjMd 7IaJeiZvopsraQlXs/bjY6N67DNq0bFdi4ckqqqce+NzuEIO0iZd2TgSg13e0j1Gmb4p iTrh6BG2mTks7I+5BJLuyO4muhN9ayp9lf+68579GQjhThNx6dQk5uZCE/dZtvSBB+nU n4BbhG78TFPSiJqM7q98CMLY4RdKf9pLtTy6CUd74gzQV+zE8f/0jWm9kBcokUY6sdqC bIBtNL03ISubXZEsrJGFApoo1W6M/tqZwQ8peBIXe58Pavig5Za8+bkkCCohPDtpdLZx +JMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding:mime-version :message-id:date:cc:to:from:dkim-signature; bh=GH4DFvsFXW8HxyMaxhFu7HFeJ+P25ZX6SyEkxmWJA9Q=; fh=0VlAImCwxnaridjxRkn42Cddnvz8rXIUGjILdUUcDOw=; b=IMqLDl1lpknVMqZLVDKiRS7bd0ymFrevxY6QU9zSFmBx/6VRdYTxxQ8q5l2MeRfZcZ 4Ry/rp9+kzntTWICnebV0SGC48BgNitN21qS+MHdeE0JspsF5iPu6UGqiP9b4eX9qja1 m2bskbRa7P41b9ApK4UKOScj2x3cDv8ToDq4ERH9IBewncmgWaXfZKdMgkswx2JAp7PT uWLtPbirzXxHhPyBvTDb0etcQxwD4Ow+5EB10Pj0j3eYsCmd+LdevFkh99SGnqc6/ph7 OSChNB2U1FEnLmv21/vBBdJgTvrDqKxr/u6aD3FyeWakJ1s4wGeg5YXz17sn26UKLVbn QVbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=PuBT85WB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ci15-20020a17090afc8f00b002532c9b252asi11708826pjb.73.2023.07.25.07.30.50; Tue, 25 Jul 2023 07:31:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@hugovil.com header.s=x header.b=PuBT85WB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232142AbjGYOYU (ORCPT + 99 others); Tue, 25 Jul 2023 10:24:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232583AbjGYOYJ (ORCPT ); Tue, 25 Jul 2023 10:24:09 -0400 Received: from mail.hugovil.com (mail.hugovil.com [162.243.120.170]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B1AC10DC; Tue, 25 Jul 2023 07:24:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=hugovil.com ; s=x; h=Subject:Content-Transfer-Encoding:Content-Type:MIME-Version: Message-Id:Date:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GH4DFvsFXW8HxyMaxhFu7HFeJ+P25ZX6SyEkxmWJA9Q=; b=PuBT85WBZ0t6SsodvImuFTmfhA iHa1X53QasOKBN+PQfcwMk0aIesy840sRtKAS/47zBhsnEaRjORJL9Ab72onujxnMtT6UOtAm6BIy MPZYMcMpf0IcO7m/77jVgCSR3wRetM3qPw5m2bdobSrTUfjlYrC/FinvNC39XbZn5n3c=; Received: from modemcable061.19-161-184.mc.videotron.ca ([184.161.19.61]:34256 helo=localhost.localdomain) by mail.hugovil.com with esmtpa (Exim 4.92) (envelope-from ) id 1qOIx1-0003Kt-AQ; Tue, 25 Jul 2023 10:23:48 -0400 From: Hugo Villeneuve To: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com, isaac.true@canonical.com, jesse.sung@canonical.com, l.perczak@camlintechnologies.com, tomasz.mon@camlingroup.com Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, hugo@hugovil.com, linux-gpio@vger.kernel.org, Hugo Villeneuve Date: Tue, 25 Jul 2023 10:23:32 -0400 Message-Id: <20230725142343.1724130-1-hugo@hugovil.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 184.161.19.61 X-SA-Exim-Mail-From: hugo@hugovil.com X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Subject: [PATCH v9 00/10] serial: sc16is7xx: fix GPIO regression and rs485 improvements X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.hugovil.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772403260246982828 X-GMAIL-MSGID: 1772403260246982828 From: Hugo Villeneuve Hello, this patch series mainly fixes a GPIO regression and improve RS485 flags and properties detection from DT. It now also includes various small fixes and improvements that were previously sent as separate patches, but that made testing everything difficult. Patch 1 fixes an issue with init of first port during probing. Patch 2 fixes an issue when debugging IOcontrol register, but it is also necessary for patch "fix regression with GPIO configuration" to work. Patch 3 fixes an incorrect label in sc16is7xx_probe() cleanup code. Patch 4 is a refactor of GPIO registration code in preparation for patch 5. Patches 5 and 6 fix a GPIO regression by (re)allowing to choose GPIO function for GPIO pins shared with modem status lines. Patch 7 fixes a bug with the output value when first setting the GPIO direction. Patch 8 allows to read common rs485 device-tree flags and properties. Patch 9 introduces a delay after a reset operation to respect datasheet timing recommandations. Patch 10 improves comments about chip variants. I have tested the changes on a custom board with two SC16IS752 DUART using a Variscite IMX8MN NANO SOM. Boards that need to have GPIOS configured as modem control lines should add that property to their device tree. Here is a list of boards using the sc16is7xx driver in their device tree and that may need to be modified: arm64/boot/dts/freescale/fsl-ls1012a-frdm.dts mips/boot/dts/ingenic/cu1830-neo.dts mips/boot/dts/ingenic/cu1000-neo.dts Thank you. Link: [v0] https://lkml.org/lkml/2023/5/15/923 [v1] https://lkml.org/lkml/2023/5/17/967 [v1] https://lkml.org/lkml/2023/5/17/777 [v1] https://lkml.org/lkml/2023/5/17/780 [v1] https://lkml.org/lkml/2023/5/17/785 [v1] https://lkml.org/lkml/2023/5/17/1311 [v2] https://lkml.org/lkml/2023/5/18/516 [v3] https://lkml.org/lkml/2023/5/25/7 [v4] https://lkml.org/lkml/2023/5/29/656 [v5] https://lkml.org/lkml/2023/6/1/1046 [v6] https://lkml.org/lkml/2023/6/1/1328 [v7] https://lkml.org/lkml/2023/6/2/861 [v8] https://lkml.org/lkml/2023/6/7/813 https://lkml.org/lkml/2023/7/21/1055 Changes for V1: - Abandonned the approach of trying to fix GPIO regression by reverting the original patches, because it created more problems than it solved (breaking existing users). Instead, add DT property to fix the GPIO behavior. Changes for V2: - Integrate multiple patches into this serie. Changes for V3: - Integrated all patches into single serie to facilitate debugging and tests. - Reduce number of exported GPIOs depending on new property nxp,modem-control-line-ports - Added additional example in DT bindings Changes for V4: - Increase reset post delay to relax scheduler. - Put comments patches at the end. - Remove Fixes tag for patch "mark IOCONTROL register as volatile". - Improve commit messages after reviews. - Fix coding style issues after reviews. - Change GPIO registration to always register the maximum number of GPIOs supported by the chip, but maks-out GPIOs declared as modem control lines. - Add patch to refactor GPIO registration. - Remove patch "serial: sc16is7xx: fix syntax error in comments". - Remove patch "add dump registers function" Changes for V5: - Change patch order to facilitate stable backport(s). - Change duplicate device addresses in DT binding examples. - Use GENMASK for bit masks. - Replace of_property_for_each_u32() with device_property_read_u32_array - Add "Cc: stable..." tags Changes for V6: - Fix compilation bug introduced by patch 3 Changes for V7: - Minor changes and coding style fixes after review for patch 5 "fix regression with GPIO configuration". Changes for V8: - Move mctrl_mask to "struct sc16is7xx_port" to avoid compiler warning when CONFIG_GPIOLIB is undefined. - Add "struct device" member to "struct sc16is7xx_port", in order to avoid passing a raw "struct device" to called functions from sc16is7xx_probe(). - Add new patch "serial: sc16is7xx: remove obsolete out_thread label" Changes for V9: - Change DT property name in commit message and move some comments to cover letter for patch "fix regression with GPIO configuration". - Add proper link to pre-v1 (v0) RFC patch. - Add changes log for V1 and V2 to this cover letter. Hugo Villeneuve (10): serial: sc16is7xx: fix broken port 0 uart init serial: sc16is7xx: mark IOCONTROL register as volatile serial: sc16is7xx: remove obsolete out_thread label serial: sc16is7xx: refactor GPIO controller registration dt-bindings: sc16is7xx: Add property to change GPIO function serial: sc16is7xx: fix regression with GPIO configuration serial: sc16is7xx: fix bug when first setting GPIO direction serial: sc16is7xx: add call to get rs485 DT flags and properties serial: sc16is7xx: add post reset delay serial: sc16is7xx: improve comments about variants .../bindings/serial/nxp,sc16is7xx.txt | 46 +++++ drivers/tty/serial/sc16is7xx.c | 177 +++++++++++++----- 2 files changed, 181 insertions(+), 42 deletions(-) base-commit: 0b5547c51827e053cc754db47d3ec3e6c2c451d2