From patchwork Tue Jul 25 05:42:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 12551 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2255193vqg; Mon, 24 Jul 2023 22:46:47 -0700 (PDT) X-Google-Smtp-Source: APBJJlGw8tPuEqTAN3H4MGGj+I3G5G4GnKM4BiB/yJeJJADKoHrHriu6jFiktJgvOwfblnnxvwQv X-Received: by 2002:a05:6a00:1a0c:b0:678:5d3c:33e8 with SMTP id g12-20020a056a001a0c00b006785d3c33e8mr12899912pfv.18.1690264007287; Mon, 24 Jul 2023 22:46:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690264007; cv=none; d=google.com; s=arc-20160816; b=vqpnAYCPj4rmisIV4hoTMZ0SCj7BSFlheJ/nwNFqCYmzoEeGxSsYAlp/HOoxI4lDYP TFNwJbsL4OK9+3FhveDVbWkgZKjVF7HcDaI5RpRGP7C9sPY6y/LlgXxejNOxYn2AdOld u72ce9M7dovc4kieHv/Jr2sEpJQNQaFrcBTSOms5H1zi670K40K8XTasnZHS9BN7JCCJ UOFsKgR9ESRSrvgA+EieGMhBsIPKGRbqKB5gG62rjuYzPgU+Ka3W2kHXCPRmcximaalE gnTEf1XKrEvqFLkL/2Gsf8y/iFM6wdrxkXaUv24cveAZR0N5GKlWyJf0q5Jyeg7DEXoK WgnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=EX+F8zQ7ZEnLFHS7tNsXELIj9aQH9ckNA8r8x6IyK5I=; fh=IFcf3iAw72IF1KlvnVHX7hQ4wCcJMibeQr9RkAbnCBk=; b=NvKmKvOmbAKByWf29KDYozMT38B8/dc1fuW1ZpfusYi4AerCkIe8UaF8lpAKnDbKwM X2uulWOqEvOxADXdgY9zPeYG7c4DupoS3yRSSo9r/4V0f3NYatNi9NHUS7ssYkRMqJhg petSiikL+HAoXDuYT6iH23STBM6r+Uj4/njssuN6jCsk2a/0AM2EbHyqWi2tlTJ2sAkt xvl2QnHzwRwyc7nTv8DqmS9jSVWOsl88G2HHVQwvTWgcKCBBtsyiyNsm1gcL7y45BZ7c SVx8eCcOVm1xFUia9FE+WGZOnWKmQbDzW+x83nHS/kX2ANvA+dItbT3k+IfKyJJpDMJg JGgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ei35-20020a056a0080e300b0067e5edde6eesi9957458pfb.302.2023.07.24.22.46.34; Mon, 24 Jul 2023 22:46:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229848AbjGYFmb (ORCPT + 99 others); Tue, 25 Jul 2023 01:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229562AbjGYFm3 (ORCPT ); Tue, 25 Jul 2023 01:42:29 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3095B1990; Mon, 24 Jul 2023 22:42:27 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id AA5E98176; Tue, 25 Jul 2023 05:42:25 +0000 (UTC) From: Tony Lindgren To: Greg Kroah-Hartman , Jiri Slaby Cc: Andy Shevchenko , Dhruva Gole , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH v5 0/3] Serial core controller port device name fixes Date: Tue, 25 Jul 2023 08:42:09 +0300 Message-ID: <20230725054216.45696-1-tony@atomide.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772370271951496675 X-GMAIL-MSGID: 1772370271951496675 A few issues have been found with device naming for the serial core controller port device. These issues currently mostly affect the output for /sys/bus/serial-base/devices, but need to be also fixed to avoid port addressing issues later on. Changes since v4: - Make the sysfs device names nicer with DEVNAME:0.0 naming, the "ctrl" and "port" prefixes are not needed with the controller id in the name - Fix Andy's Reviewed-by as noted by Andy - Generate patches with --patience to make the last patch more readable Changes since v3: - Drop unnecessary else on the return path in serial_base_device_init() as noted by Andy - Add Andy's Reviewed-by - Update patch description for port_id instead of port port_id for the first patch Changes since v2: - Fix my email script as it had started to drop linux-serial as noted by Greg - Explain why we're changing ctrl_id as requested by Greg Changes since v1: - Port id cannot be negative as noted by Jiri - Controller id cannot be negative as noted by Andy - Port name is missing the controller instance as noted by Andy Tony Lindgren (3): serial: core: Controller id cannot be negative serial: core: Fix serial core port id to not use port->line serial: core: Fix serial core controller port name to show controller id drivers/tty/serial/8250/8250_core.c | 2 ++ drivers/tty/serial/serial_base_bus.c | 32 +++++++++++++++++----------- include/linux/serial_core.h | 3 ++- 3 files changed, 24 insertions(+), 13 deletions(-)