From patchwork Mon Jul 24 05:07:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tony Lindgren X-Patchwork-Id: 12478 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp1578449vqg; Sun, 23 Jul 2023 22:11:24 -0700 (PDT) X-Google-Smtp-Source: APBJJlHQvZStXjUX6qq2qtXCmQfuVQyAVSOr78T8Eyh84U4dhDRfWm/aRIlWIkam56nkUXdxlK2Y X-Received: by 2002:a17:907:75ce:b0:993:e94e:7234 with SMTP id jl14-20020a17090775ce00b00993e94e7234mr7968355ejc.77.1690175483874; Sun, 23 Jul 2023 22:11:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690175483; cv=none; d=google.com; s=arc-20160816; b=VzCVMHh8UH/DdC3jLf+DmGKvpUZF3kx6K50eFynbG9oyU/og88911cLAEtXTGCWoxr 52hPVoyb35SLB7LmoZ3ka+hYeFg1Ug0R1pczYEOXeJSqGelv37l8MjkyuOuEoIkWOylV 0A8Rg4xWzQJt/ca0ESWnwQ6lW4Y4nEpM9NnTckA8jxz3oXbZL1njOFqlgLehDyQjEQaD FvGMQl33ggE0/X+XHnv3j6vDHDuiZ26ZYLaHGdNreaSBalOQIk0eGIIzkkR4n5WOnUdH AwR+widQD8cVqAclt0xUXEU4ADDrrTkhQKJ0xO+s631q3fkNEqGcMKca6xTZmK8qs/7J xyMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JyO3l0ekPo/vuoARKqSMgZOj3R3GDVijd0Jvc1Tzu28=; fh=IFcf3iAw72IF1KlvnVHX7hQ4wCcJMibeQr9RkAbnCBk=; b=OsLpXsecbe5g1frXE4OGGvsct7qZiLcKx26by+m5FU3ktGJM8nZurG77eOOHnIFEH5 zmmCwOuajQJde/MJBXlPmA98ok+64kZQLsXlMtZuw/5YnrIjR2K9R16tisE7UoomJKHa sUDi3xuM8corXubFTKQxXMxMfuTcM9ex7qsxECcbjWhUDwAqGfSFkgzecfrqStFb5w5f +gsES6TVEG2RQaPK+NrjSQutdQS4Ir0BDQXPGSElKABZCcmWj062UwbFjG/UNbKEpj3g GwleglBwX5RP+ZcDP9o2FNUoifGuCGwUG8jyxWYDk65dElfkcWHOIYY5NLvsnVmGZtoZ ye2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xa17-20020a170907b9d100b0099233867740si6100367ejc.144.2023.07.23.22.11.00; Sun, 23 Jul 2023 22:11:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229683AbjGXFHZ (ORCPT + 99 others); Mon, 24 Jul 2023 01:07:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229666AbjGXFHY (ORCPT ); Mon, 24 Jul 2023 01:07:24 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id DCD96E4F; Sun, 23 Jul 2023 22:07:19 -0700 (PDT) Received: from hillo.muru.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTP id 851AC809F; Mon, 24 Jul 2023 05:07:17 +0000 (UTC) From: Tony Lindgren To: Greg Kroah-Hartman , Jiri Slaby Cc: Andy Shevchenko , Dhruva Gole , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: [PATCH v4 0/3] Serial core controller port device name fixes Date: Mon, 24 Jul 2023 08:07:02 +0300 Message-ID: <20230724050709.17544-1-tony@atomide.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772277447917348803 X-GMAIL-MSGID: 1772277447917348803 A few issues have been found with device naming for the serial core controller port device. These issues currently mostly affect the output for /sys/bus/serial-base/devices, but need to be also fixed to avoid port addressing issues later on. Changes since v3: - Drop unnecessary else on the return path in serial_base_device_init() as noted by Andy - Add Andy's Reviewed-by - Update first patch description for port_id instead of port port_id for the first patch Changes since v2: - Fix my email script as it had started to drop linux-serial as noted by Greg - Explain why we're changing ctrl_id as requested by Greg Changes since v1: - Port id cannot be negative as noted by Jiri - Controller id cannot be negative as noted by Andy - Port name is missing the controller instance as noted by Andy Tony Lindgren (3): serial: core: Controller id cannot be negative serial: core: Fix serial core port id to not use port->line serial: core: Fix serial core controller port name to show controller id drivers/tty/serial/8250/8250_core.c | 2 ++ drivers/tty/serial/serial_base_bus.c | 34 ++++++++++++++++++---------- include/linux/serial_core.h | 3 ++- 3 files changed, 26 insertions(+), 13 deletions(-)