From patchwork Fri Jul 21 22:59:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Christopherson X-Patchwork-Id: 12435 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp511459vqg; Fri, 21 Jul 2023 16:05:25 -0700 (PDT) X-Google-Smtp-Source: APBJJlHqNQsxaAj7t7foi1KakDlxFc3QwLoo2VCjC79Xblu09Qy4UL6c0QOpjxMymJi91HmMG98i X-Received: by 2002:a05:6512:3d86:b0:4fb:8616:7a03 with SMTP id k6-20020a0565123d8600b004fb86167a03mr2830456lfv.4.1689980724846; Fri, 21 Jul 2023 16:05:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689980724; cv=none; d=google.com; s=arc-20160816; b=Z5Gpda0B4GzS3tSbvwlXMQQ1Aa/8hcT6Q5CDzspSjDrapMtn1drSR2cvDgT88ItJHk W8cRSDHk+MaGqxIyvzfmE2vZXWoxQP+FMRhVx0u+NRuYS76zlSBFRpbofW4QsUrFhSbK 7Pd4zIqRkJgeolfznn9Zs/30jz1t8LfOfX9MfK/J321//Jc9JkkAZ8idJucsupOJPG+R eNW0Nd4KuZdw2/iF2GyQOxmYJMoXu+Yo8b6yJVFEpYJiZjMvlMR5VyZILtd/zMG/4yf+ fHIfpWNoaxyzb3phOnf2uChjGLLsH5cRbEaUyVkclNX6DZisLLvCFfQAZCx73cLXi9r6 KHRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :reply-to:dkim-signature; bh=dRpmM2jj/hlD9zn4KXUWJJ0DXD5l3XPrTy7EQ8BSFM0=; fh=sOnAx2GuCQaI5IJu7Mo1xgLCDrPH4l5HM1pSkvn/pIo=; b=TOhH67ptuGxMxhOi3KX/2+kv+IHaNHT9gZ1bZhOoeYtcKDit+O/aDRQVdHyVcRqVMm 5Scu82XjglwdNeEEA5qh7+wv+IuEA0Vt/HljlbmLR6AKimzFokmJNAsio7+IL3yAD0eF Mwa1NrgCUqP+nQxedqypLwpveOXpfE/l44yLkXxWXvGmm6BlrY7s76/UpLYrWS8dTEqu zCdXhhQpBZdWr8viX87IWU0+IjslWDaO1+gx56B7OzuwcOS/hN6MON3S/3zGwJ2+dzg9 76GAjkMPTcHREP1an2oHPFDE8ztmGDUgZvpXeCi/AC9fFLrxBZ3DgrXBaTJGWST4z6JM ITmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=R4cXu6oJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d3-20020a056402516300b0051dd6214af0si2882904ede.366.2023.07.21.16.04.57; Fri, 21 Jul 2023 16:05:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20221208 header.b=R4cXu6oJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229503AbjGUXAM (ORCPT + 99 others); Fri, 21 Jul 2023 19:00:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjGUXAL (ORCPT ); Fri, 21 Jul 2023 19:00:11 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9DF93A93 for ; Fri, 21 Jul 2023 16:00:10 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-1b89e3715acso14210425ad.3 for ; Fri, 21 Jul 2023 16:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689980410; x=1690585210; h=cc:to:from:subject:message-id:mime-version:date:reply-to:from:to:cc :subject:date:message-id:reply-to; bh=dRpmM2jj/hlD9zn4KXUWJJ0DXD5l3XPrTy7EQ8BSFM0=; b=R4cXu6oJUn5piVAk+Ojaz/Iff4NUz3w3kQypdkTlKTEAmzcUbg1ZSq/gbQiqbLMj2z yAATYAtjfQ/eH+vbOR01gexXmEaJnId0LkV8KJtQiTcL3rc1PGOGRFOZ+VfIvZJS2O2y v8eafe6JZ/Sm2Rh4U5uG6KbKCZgRMs5ml3zRO3wMtofE3549n4MWdhshri6tKCVbI3oZ MQYpmkcZS4AtA4qcE4XxD/xSoVoEoqopTPrlSF/jvesACRdiK31lE3H3YITFcrTXyOHZ Jvz+1WXhkXSmIW2zQF0KByfrQhDd9ij9hULCbB2UfoekPs2iooLM6IMFNJcQ1ceoco4R O2Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689980410; x=1690585210; h=cc:to:from:subject:message-id:mime-version:date:reply-to :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dRpmM2jj/hlD9zn4KXUWJJ0DXD5l3XPrTy7EQ8BSFM0=; b=iLU/RlnTLZjDLJPzQRYtX9Ps3ZyFBfy8x1HQl1HHwkOj6pJQtmQkAnH4lA53B8U7Uv e/CLjmgQF3R4LNVM0zjY3lBdhQrEwf62Ze5C0GyuFSzjlPAuaOLL0hBSYUS5/dcG9mx6 97RqAEzfWvFfD0URApHjKSiIU2weS8YX3rtZhujNKfdtYuT97oWNwNKo9BTvlB4lsOqP IIe2CyaVNEpn4oNzsONTmcWbhAYjQ8pnoEajWZeaFMgbo2iy3ylRvlJ0Ik/WKn5ZzvxV Kc3vRyTw0CMJ641P3YNap4i6RTVcz7iEJoFZtn9ldj1ZqRSjxZMw/lnqfobR9rFbXnsB FV9g== X-Gm-Message-State: ABy/qLbACU+R1WPbDYlrOKpBjtpezDNCk+PxnboTHpqashR52MVzwazv q2lKXA6aiqUdCgPNGNrCM1rmVzAFB+Q= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:1c9:b0:1b9:df8f:888c with SMTP id e9-20020a17090301c900b001b9df8f888cmr11726plh.8.1689980410094; Fri, 21 Jul 2023 16:00:10 -0700 (PDT) Reply-To: Sean Christopherson Date: Fri, 21 Jul 2023 15:59:57 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.41.0.487.g6d72f3e995-goog Message-ID: <20230721230006.2337941-1-seanjc@google.com> Subject: [PATCH v2 0/9] KVM: x86/mmu: Clean up MMU_DEBUG and BUG/WARN usage From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Mingwei Zhang , David Matlack , Jim Mattson X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772073228651135795 X-GMAIL-MSGID: 1772073228651135795 This series consist of three loosely related miniseries: 1. Remove the noisy prints buried behind MMU_DEBUG, and replace MMU_DEBUG with a KVM_PROVE_MMU Kconfig. 2. Use WARN_ON_ONCE() for all runtime WARNs, i.e. avoid spamming the kernel log if something goes awry in the MMU. 3. Demote BUG() usage in the shadow MMU to KVM_BUG_ON() when the kernel is built with CONFIG_BUG_ON_DATA_CORRUPTION=n. v2: - Collect a review. [Mingwei] - Call out the more obvious path to FNAME(walk_addr_generic) in patch 6. [David] - Use BUILD_BUG_ON_INVALID() for the stub. [David] v1: https://lore.kernel.org/all/20230511235917.639770-1-seanjc@google.com Mingwei Zhang (1): KVM: x86/mmu: Plumb "struct kvm" all the way to pte_list_remove() Sean Christopherson (8): KVM: x86/mmu: Delete rmap_printk() and all its usage KVM: x86/mmu: Delete the "dbg" module param KVM: x86/mmu: Rename MMU_WARN_ON() to KVM_MMU_WARN_ON() KVM: x86/mmu: Convert "runtime" WARN_ON() assertions to WARN_ON_ONCE() KVM: x86/mmu: Bug the VM if a vCPU ends up in long mode without PAE enabled KVM: x86/mmu: Replace MMU_DEBUG with proper KVM_PROVE_MMU Kconfig KVM: x86/mmu: Use BUILD_BUG_ON_INVALID() for KVM_MMU_WARN_ON() stub KVM: x86/mmu: BUG() in rmap helpers iff CONFIG_BUG_ON_DATA_CORRUPTION=y arch/x86/kvm/Kconfig | 13 ++++ arch/x86/kvm/mmu/mmu.c | 127 ++++++++++++++------------------ arch/x86/kvm/mmu/mmu_internal.h | 12 +-- arch/x86/kvm/mmu/page_track.c | 16 ++-- arch/x86/kvm/mmu/paging_tmpl.h | 16 +++- arch/x86/kvm/mmu/spte.c | 4 +- arch/x86/kvm/mmu/spte.h | 8 +- arch/x86/kvm/mmu/tdp_iter.c | 4 +- arch/x86/kvm/mmu/tdp_mmu.c | 28 +++---- include/linux/kvm_host.h | 19 +++++ 10 files changed, 134 insertions(+), 113 deletions(-) base-commit: 294ebdda1560d3eb515da88b805ba7f88eb28d21