mbox series

[v3,0/3] Serial core controller port device name fixes

Message ID 20230721072147.59121-1-tony@atomide.com
Headers
Series Serial core controller port device name fixes |

Message

Tony Lindgren July 21, 2023, 7:21 a.m. UTC 
  A few issues have been found with device naming for the serial core
controller port device. These issues currently mostly affect the output
for /sys/bus/serial-base/devices, but need to be also fixed to avoid
port addressing issues later on.

Changes since v2:
- Fix my email script as it had started to drop linux-serial as noted by
  Greg

- Explain why we're changing ctrl_id as requested by Greg

Changes since v1:
- Port id cannot be negative as noted by Jiri

- Controller id cannot be negative as noted by Andy

- Port name is missing the controller instance as noted by Andy

Tony Lindgren (3):
  serial: core: Controller id cannot be negative
  serial: core: Fix serial core port id to not use port->line
  serial: core: Fix serial core controller port name to show controller
    id

 drivers/tty/serial/8250/8250_core.c  |  2 ++
 drivers/tty/serial/serial_base_bus.c | 33 ++++++++++++++++++----------
 include/linux/serial_core.h          |  3 ++-
 3 files changed, 25 insertions(+), 13 deletions(-)

Comments

Andy Shevchenko July 21, 2023, 10:36 a.m. UTC | #1 
On Fri, Jul 21, 2023 at 10:21:39AM +0300, Tony Lindgren wrote:
> A few issues have been found with device naming for the serial core
> controller port device. These issues currently mostly affect the output
> for /sys/bus/serial-base/devices, but need to be also fixed to avoid
> port addressing issues later on.

With the addressed change,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
for the entire series, good fixes!