Message ID | 20230719125430.249644-1-francesco@dolcini.it |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp2426404vqt; Wed, 19 Jul 2023 06:09:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlGifJRQyRbkIIuIoex5BZhqDbqTYEjBe70ynX/zyNzziW0tmRmROo9Prt9lH14TsTiD5vIY X-Received: by 2002:a17:906:6495:b0:98e:933:2909 with SMTP id e21-20020a170906649500b0098e09332909mr2510699ejm.22.1689772166906; Wed, 19 Jul 2023 06:09:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689772166; cv=none; d=google.com; s=arc-20160816; b=Llf8heqJPzdS2bpOOPmXGljbb/c4haEcMKhmxeqVkJmZknWFm9bP04yjDxmUrmjtQS /J5S/TIv02F88kURg7Pi2T10AwaSq5YAwAl5YiwWLZlTMZFvd6yhyxC8mE5R7T6Jx7Su b8MzMX+bqLAyw7UeQACWp1jxD/agBDxxm4wdLnFcSw7QSw3SgUAozXFPsoq1WmF3KQua sPFIcd9wPTEGdqx8wA7D2ZRs2z0141It1/IZ2whDFFlQQ9DKcg7gkx3Ot+jXqN7GCsII oClZ4HiVsQO3BRLd8r24ds34QiEOv8ic9hFB74DycQe+uu0U7MoTNTLR8EJjm56eDxZ8 RiQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=VyTvSTXAUJpeePGhX0egbKyk20k5PqiTArlgQnzqngo=; fh=qgq+kCNF42FP1PeJcKT3BSSZNc2+/PNS7qKHZ1wB8Ug=; b=quaUiXdZqIOEM/rYj8JTETB0e0Wfwjf0WaYyVOd/dtqKndjiB0UAkxGtLKWIgfxW3b AC8hmq75+RHgPn577YarAQh2K+sBWqViESTnAB80XKaeGBf4NjdOCSrE/NwLe3SE84x4 N4SgIBbn/bYGoS/RgloYXmFXkCtd6V76ZlQFbIiDveEbkqbPcBktwNoZDdGRULS5IAYG GkXlppNpruBbq2nN4tIkhfvsYjyy4Qi05RbUD/Q+IBM0oEF4jOWAOvbHNuE+X4bq2pKM i2TesUxcW4dVd1FkL9BtmR9o+mtagRVW5kdTigc0F7oOlgZwzYcHHj2Tx9TqcxXIJm2w t8jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c26-20020a170906171a00b009939d1b60bdsi2498041eje.67.2023.07.19.06.09.00; Wed, 19 Jul 2023 06:09:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbjGSMyi (ORCPT <rfc822;chrisben.tianve@gmail.com> + 99 others); Wed, 19 Jul 2023 08:54:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbjGSMyh (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 19 Jul 2023 08:54:37 -0400 Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2C7310B; Wed, 19 Jul 2023 05:54:36 -0700 (PDT) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id CCC8D20623; Wed, 19 Jul 2023 14:54:34 +0200 (CEST) From: Francesco Dolcini <francesco@dolcini.it> To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Francesco Dolcini <francesco.dolcini@toradex.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Mark Brown <broonie@kernel.org> Subject: [PATCH v1 0/2] arm64: dts: freescale: verdin-imx8mp: add sound card Date: Wed, 19 Jul 2023 14:54:28 +0200 Message-Id: <20230719125430.249644-1-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771854539617629357 X-GMAIL-MSGID: 1771854539617629357 |
Series |
arm64: dts: freescale: verdin-imx8mp: add sound card
|
|
Message
Francesco Dolcini
July 19, 2023, 12:54 p.m. UTC
From: Francesco Dolcini <francesco.dolcini@toradex.com>
Add audio support to both Dahlia and Development carrier boards
Francesco Dolcini (2):
arm64: dts: freescale: verdin-imx8mp: dahlia: add sound card
arm64: dts: freescale: verdin-imx8mp: dev: add sound card
.../dts/freescale/imx8mp-verdin-dahlia.dtsi | 56 ++++++++++++++++++-
.../boot/dts/freescale/imx8mp-verdin-dev.dtsi | 55 ++++++++++++++++--
2 files changed, 104 insertions(+), 7 deletions(-)
Comments
On 23-07-19, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add WM8904 based analog sound card to Dahlia carrier board. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../dts/freescale/imx8mp-verdin-dahlia.dtsi | 56 ++++++++++++++++++- > 1 file changed, 53 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > index 56b0e4b865c9..7e9e4b13b5c5 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-dahlia.dtsi > @@ -3,7 +3,36 @@ > * Copyright 2022 Toradex > */ > > -/* TODO: Audio Codec */ > +/ { > + sound { > + compatible = "simple-audio-card"; > + simple-audio-card,bitclock-master = <&codec_dai>; > + simple-audio-card,format = "i2s"; > + simple-audio-card,frame-master = <&codec_dai>; > + simple-audio-card,mclk-fs = <256>; > + simple-audio-card,name = "imx8mp-wm8904"; > + simple-audio-card,routing = > + "Headphone Jack", "HPOUTL", > + "Headphone Jack", "HPOUTR", > + "IN2L", "Line In Jack", > + "IN2R", "Line In Jack", > + "Headphone Jack", "MICBIAS", > + "IN1L", "Headphone Jack"; > + simple-audio-card,widgets = > + "Microphone", "Headphone Jack", > + "Headphone", "Headphone Jack", > + "Line", "Line In Jack"; > + > + codec_dai: simple-audio-card,codec { > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1>; Nit: since the audio-codec node is using the same clock you can drop it here. Regards, Marco > + sound-dai = <&wm8904_1a>; > + }; > + > + simple-audio-card,cpu { > + sound-dai = <&sai1>; > + }; > + }; > +}; > > &backlight { > power-supply = <®_3p3v>; > @@ -64,7 +93,21 @@ &i2c3 { > &i2c4 { > status = "okay"; > > - /* TODO: Audio Codec */ > + /* Audio Codec */ > + wm8904_1a: audio-codec@1a { > + compatible = "wlf,wm8904"; > + reg = <0x1a>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_sai1>; > + #sound-dai-cells = <0>; > + clocks = <&audio_blk_ctrl IMX8MP_CLK_AUDIOMIX_SAI1_MCLK1>; > + clock-names = "mclk"; > + AVDD-supply = <®_1p8v>; > + CPVDD-supply = <®_1p8v>; > + DBVDD-supply = <®_1p8v>; > + DCVDD-supply = <®_1p8v>; > + MICVDD-supply = <®_1p8v>; > + }; > }; > > /* Verdin PCIE_1 */ > @@ -95,7 +138,14 @@ ®_usdhc2_vmmc { > vin-supply = <®_3p3v>; > }; > > -/* TODO: Verdin I2S_1 */ > +/* Verdin I2S_1 */ > +&sai1 { > + assigned-clocks = <&clk IMX8MP_CLK_SAI1>; > + assigned-clock-parents = <&clk IMX8MP_AUDIO_PLL1_OUT>; > + assigned-clock-rates = <24576000>; > + fsl,sai-mclk-direction-output; > + status = "okay"; > +}; > > /* Verdin UART_1 */ > &uart1 { > -- > 2.25.1 > > >
Hello Shawn On Wed, Jul 19, 2023 at 02:54:28PM +0200, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add audio support to both Dahlia and Development carrier boards > > Francesco Dolcini (2): > arm64: dts: freescale: verdin-imx8mp: dahlia: add sound card > arm64: dts: freescale: verdin-imx8mp: dev: add sound card > > .../dts/freescale/imx8mp-verdin-dahlia.dtsi | 56 ++++++++++++++++++- > .../boot/dts/freescale/imx8mp-verdin-dev.dtsi | 55 ++++++++++++++++-- > 2 files changed, 104 insertions(+), 7 deletions(-) Any concern on this series? Francesco
On Wed, Jul 19, 2023 at 02:54:28PM +0200, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add audio support to both Dahlia and Development carrier boards > > Francesco Dolcini (2): > arm64: dts: freescale: verdin-imx8mp: dahlia: add sound card > arm64: dts: freescale: verdin-imx8mp: dev: add sound card Applied both, thanks!