From patchwork Mon Jul 17 12:40:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Joaqu=C3=ADn_Ignacio_Aramend=C3=ADa?= X-Patchwork-Id: 12137 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1104566vqt; Mon, 17 Jul 2023 06:16:05 -0700 (PDT) X-Google-Smtp-Source: APBJJlG80MDlYMpyXO/QZbLxDZ33F4xY5Mc9XciK/UL5SMPaj1421REFMPl1QZFZtnXYejpXMi0Q X-Received: by 2002:a50:fb06:0:b0:51e:2a56:91d6 with SMTP id d6-20020a50fb06000000b0051e2a5691d6mr10823831edq.19.1689599764688; Mon, 17 Jul 2023 06:16:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689599764; cv=none; d=google.com; s=arc-20160816; b=SmEE2jNBRNCMVdlGFV5XFVvk9wX9qRkHj+oh0/rWguWnaygC2UmphIZg9PaO3Zph/1 rSVp9NqZUZKkKQBPKkmV+r6pS4am9ETg2y9tG+uyVFfTVuyH4EpahxOZyU+p9MiE2ztX nkz+QvHTntF8UAIPnWy2TpVc0l0RpYkNqc5v+fhTQYqLooFy3e9ysz6ApXjFlSseZGCp hjkBE9SoAeUfGJUZy1epuJdf6tbto6XvUt+9SCvsDkSiiSBB/rzN+J4WcrUC3cMLoL1d 2ey4XF2JiLjQGK4w06nHL3gwszxOXVVvETiM8oq2p1vgAS6o4JglwTBng3RiOJBtljxO 0JzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/LfL84LAIi1r27lZlLbd37kGrrsw2l29HoDFKJOl4Ac=; fh=h793OaUni30alKFb4D+hGQdzb3dwmJ62PCcOI4idbnU=; b=ItW294T0W3Jgn5XQdmafnpMCGTr9jAYb2jN8jeBRd1zWmocuSyQ3iN9AwZnlFUAXYs 4MII4Yosp5g26Sd1IH3Ro3bx188rsI5/sHVfWeYaRfltKtNJZ4+0C85uj347EHaXORXd 3vQIetFnvsZSINlzb+xSoKMRpxI63aZDfDnrTaB4hOp7HXrTocqRWcT1bQtehKAAtZLV 5D5aTLuClrJ2OENXqnMlxsKN26Whn5tgnOZ4TSZd2fX/I6Z9lYdH6EKJTT0m7LgrYWQe KjBpYjxhP7rzgnZQl+6FDv846R4dYU6OkExiP8ZCMzBBTGE48mWBzHxKtiVqzaMcfyZK 0TIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=bl7pi9Bw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a12-20020aa7cf0c000000b0051e01f391besi12735945edy.581.2023.07.17.06.15.41; Mon, 17 Jul 2023 06:16:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=bl7pi9Bw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230211AbjGQMkq (ORCPT + 99 others); Mon, 17 Jul 2023 08:40:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231140AbjGQMkl (ORCPT ); Mon, 17 Jul 2023 08:40:41 -0400 Received: from mail-oa1-x35.google.com (mail-oa1-x35.google.com [IPv6:2001:4860:4864:20::35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE9F1E47; Mon, 17 Jul 2023 05:40:40 -0700 (PDT) Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-1ba79f16f4cso1108227fac.3; Mon, 17 Jul 2023 05:40:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689597639; x=1692189639; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/LfL84LAIi1r27lZlLbd37kGrrsw2l29HoDFKJOl4Ac=; b=bl7pi9BwVeVvPvArUJ1DgctUD5M5O5JzJO6HoBMf5wql6uv05L9lN2w32IQtkPz3Xf R1farv7PIGwje5Rc2optcizkz9QxGdqXuwsCn4EV4Cw1GE7AUKytNqgLo9vAtupe2IaC 3Lg5pInY1pvIGl3WTTLzdZM5QIzilR+T7Lul7DbWtzvVWok3CvO5T98XvXLH/cxkG0/B dGApxNxU/FQVtdhpbSw2uoq7aC6C2CH35Z2JhG1m1PCrItNvomkFC5qmYxDgzM5m1KWM kfSKELkKeKg/RiPxD4+bQwMnyCxPt5eqBoKsQ4YM4ErPmer8KdIWJWP0wsLaEqwt52ZI WIAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689597639; x=1692189639; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/LfL84LAIi1r27lZlLbd37kGrrsw2l29HoDFKJOl4Ac=; b=SNdR7MJTUPg1UpYjghk8IFRY3N/ya3xZzK9xaY78+3R2xy8empFSR8HrJGqoFuOl4x d3vd/TTye/3z9NtQPUVWzXj4ZpAPlkDRBrWII6OKATlIeHCgF+00QSRIpkgorwMrSE4O JcXYbUHDBNGVLlG7GgJIQoZY0ZZoCO/jq6FhexfohVf8DsNkNe2/8TAFiBovZBzz1LuX CXsvCRVQYjyhIoSZO9rcSrSKZPgMLu18gTdTj1tN1B4jAIC/UEfF07Ki8ZvX1vNoAWVO IimPvVLtvO+HMAzGW4WNnAqhLt0Rg5kbb9wHVB6Sc7qznAofm7TreVNYKknMVoZqzHRS MOdw== X-Gm-Message-State: ABy/qLaCLOFWrdAyEXIHFyY1x9u/699Fubze4WjSzZEhNeMm3qx7jZxh rzrUlL3dMS/d6WTdNG/8dvm/dbT6Nuw= X-Received: by 2002:a05:6870:708e:b0:1b0:2fc3:b4f1 with SMTP id v14-20020a056870708e00b001b02fc3b4f1mr14389162oae.9.1689597639341; Mon, 17 Jul 2023 05:40:39 -0700 (PDT) Received: from smeagol.fibertel.com.ar ([201.235.4.68]) by smtp.gmail.com with ESMTPSA id em30-20020a0568705b9e00b001b02a3426ddsm7032173oab.14.2023.07.17.05.40.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 05:40:38 -0700 (PDT) From: =?utf-8?q?Joaqu=C3=ADn_Ignacio_Aramend=C3=ADa?= To: linux@roeck-us.net Cc: =?utf-8?q?Joaqu=C3=ADn_Ignacio_Aramend=C3=ADa?= , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: [PATCH 0/3] hwmon: (oxp-sensors) Refactor probe() and init() and remove devm_add_groups() Date: Mon, 17 Jul 2023 09:40:03 -0300 Message-ID: <20230717124013.38796-2-samsagax@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771673762880081824 X-GMAIL-MSGID: 1771673762880081824 Remove the use of devm_add_groups() in favour of dev_groups in platform driver structure. This will allow for removal of the function as it was intended in Greg's email[1]. Also since the driver is not hotpluggable move al the initialization and detection logic to init() instead of probe() so we don't instantiate the driver if the detection fails. [1] Link: https://lore.kernel.org/linux-hwmon/ZKW7WuP0T9QdCR+G@google.com/ Joaquín Ignacio Aramendía (3): hwmon: (oxp-sensors) Move tt_toggle attribute to dev_groups hwmon: (oxp-sensors) Move board detection to the init function hwmon: (oxp-sensors) Refactor init() and remove probe() drivers/hwmon/oxp-sensors.c | 81 +++++++++++++++++++++---------------- 1 file changed, 46 insertions(+), 35 deletions(-)