mbox series

[0/3] regmap: Add interface for checking if a register is cached

Message ID 20230717-regmap-cache-check-v1-0-73ef688afae3@kernel.org
Headers
Series regmap: Add interface for checking if a register is cached |

Message

Mark Brown July 17, 2023, 8:33 p.m. UTC 
  HDA has a use case for checking if a register is present in the cache
which it awkwardly open codes with use of _cache_only() and a read,
provide a direct API for this.

---
Mark Brown (3):
      regmap: Let users check if a register is cached
      regmap: Provide test for regcache_reg_present()
      ALSA: hda: Use regcache_reg_cached() rather than open coding

 drivers/base/regmap/regcache.c     | 23 ++++++++++++++++++++++
 drivers/base/regmap/regmap-kunit.c | 40 ++++++++++++++++++++++++++++++++++++++
 include/linux/regmap.h             |  1 +
 sound/hda/hdac_regmap.c            |  9 +++------
 4 files changed, 67 insertions(+), 6 deletions(-)
---
base-commit: 3953d5c79c21defa716624a8623c4157c0f2fee0
change-id: 20230716-regmap-cache-check-6f6939f41ed5

Best regards,

Comments

Takashi Iwai July 18, 2023, 5:46 a.m. UTC | #1 
On Mon, 17 Jul 2023 22:33:02 +0200,
Mark Brown wrote:
> 
> HDA has a use case for checking if a register is present in the cache
> which it awkwardly open codes with use of _cache_only() and a read,
> provide a direct API for this.
> 
> ---
> Mark Brown (3):
>       regmap: Let users check if a register is cached
>       regmap: Provide test for regcache_reg_present()
>       ALSA: hda: Use regcache_reg_cached() rather than open coding

Reviewed-by: Takashi Iwai <tiwai@suse.de>

I suppose you'll take those from regmap.git?


thanks,

Takashi

> 
>  drivers/base/regmap/regcache.c     | 23 ++++++++++++++++++++++
>  drivers/base/regmap/regmap-kunit.c | 40 ++++++++++++++++++++++++++++++++++++++
>  include/linux/regmap.h             |  1 +
>  sound/hda/hdac_regmap.c            |  9 +++------
>  4 files changed, 67 insertions(+), 6 deletions(-)
> ---
> base-commit: 3953d5c79c21defa716624a8623c4157c0f2fee0
> change-id: 20230716-regmap-cache-check-6f6939f41ed5
> 
> Best regards,
> -- 
> Mark Brown <broonie@kernel.org>
>
Mark Brown July 18, 2023, 1:56 p.m. UTC | #2 
On Tue, Jul 18, 2023 at 07:46:42AM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > Mark Brown (3):
> >       regmap: Let users check if a register is cached
> >       regmap: Provide test for regcache_reg_present()
> >       ALSA: hda: Use regcache_reg_cached() rather than open coding

> Reviewed-by: Takashi Iwai <tiwai@suse.de>

> I suppose you'll take those from regmap.git?

Sure, it's probably easiest (and there's some annoying overlap with some
other work in there that'd make for conflicts otherwise).
Mark Brown July 19, 2023, 1:33 p.m. UTC | #3 
On Mon, 17 Jul 2023 21:33:02 +0100, Mark Brown wrote:
> HDA has a use case for checking if a register is present in the cache
> which it awkwardly open codes with use of _cache_only() and a read,
> provide a direct API for this.
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git for-next

Thanks!

[1/3] regmap: Let users check if a register is cached
      commit: 78908f45ccf1dc2f4d5fb395c460fdbbf7e9ac3a
[2/3] regmap: Provide test for regcache_reg_present()
      commit: d881ee5a872fd539a8c693e4c8656b9343c9aae0
[3/3] ALSA: hda: Use regcache_reg_cached() rather than open coding
      commit: 99aae70551f99536936438bbcfc562df69eeb79c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark