From patchwork Fri Jul 14 16:11:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 12072 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2616626vqm; Fri, 14 Jul 2023 09:27:56 -0700 (PDT) X-Google-Smtp-Source: APBJJlHj3FvCO4P1LkZRWLpqXB4IvrM2bQQn5c6qbUpHKEnCmRYwKTN9zrlgBXaTQnfM0qMqTgKy X-Received: by 2002:a17:906:3f56:b0:992:1233:9c45 with SMTP id f22-20020a1709063f5600b0099212339c45mr3802776ejj.69.1689352076386; Fri, 14 Jul 2023 09:27:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689352076; cv=none; d=google.com; s=arc-20160816; b=y3yg1Gj3i02MWBlwZpiF8PKfkkwft6smpyzxkMoIgOgh4mTErhkz9U0NB2YwG7cXZu HOhco5kzsqa3cwsWMSPARctoCgKdFxQYWH2ZUlpKuOVPJcKxdu2Ypo1mn4Md5fSg1Pj9 vop6dXNvHgv++oX9QDXbmmmKNJKadVYnPqiX4PtVvsYU0bMT/u08Ar5eWS8+KzCuu4dO Ieep1ZlJUdUmobpOq+ivMTrVMC895kwdgnRWOUHKh+siCVO6Pp+7CJbNkSW1xk2yw5SZ GymMkuH9XEvC6AUo45Jmg+ZMflydmT2MIHj6EI6ntlPSI4T7hmz36dMTFxiL55akU8vV hxEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=X3u49tpdY4rOV9dSlCIkVQr0V84jvH6SM3HD26dSfQE=; fh=aYwOFvh45AiUk04AC35/CxFbCKpYy0XHNT+Ky7LGVhk=; b=0+jtuDOPXElQSYmbkaHJyv0tSFc2MasVHzgWj+2WLJTezsTl8l0kUikihigrg+VgRq 2CXBM1+xBX/bdrUFn7STSw3Je0JmR4+225W1DVHiyQjQQBdeTM4INUNP9PnV27o0tZGI yB6gPsEnvphZCh6YSG/MlnAydGZLa3DDWOJAI7D8/wW7THhY5Hiko/RnUq3dRHr7xSUT lspq4DpHAA1OzRjJ1UZwxOK/08Hxh4uTrrymQCULRVDndX6tUxzWi3p2zJ4YC3r4ol5r JwTBcVdu0dE11Ood5UcriDF2fkkc7XweHXM8pJ0o/OWLQk34qLsWTj7/ZvIsUNgUqiTJ 7zTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=UM0TkNHn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id xo26-20020a170907bb9a00b0099280a7eeeasi1529912ejc.526.2023.07.14.09.27.30; Fri, 14 Jul 2023 09:27:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=UM0TkNHn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236145AbjGNQLu (ORCPT + 99 others); Fri, 14 Jul 2023 12:11:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234562AbjGNQLo (ORCPT ); Fri, 14 Jul 2023 12:11:44 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28BF635AE for ; Fri, 14 Jul 2023 09:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=X3u49tpdY4rOV9dSlCIkVQr0V84jvH6SM3HD26dSfQE=; b=UM0TkNHngnwYh8Z8NYAqGIzDlx AlUfE3QULHGoTbAnS4rSLqhTQ0rGjBuXGxAM5LN5eN/2GYfO57deUF9bbns6OmoRk7YFlTeot2LS3 qBanpEFcTHkptIlsMVkUBYaODetu6MjtO6JPrCGQVj40iZsqfNViW45rcOHxjQcAkf+8EUKAvAVqU EfGo/StXw9qiEsvm7X+Yt6hi5Crr/VdAccrVoofvsATryW+2uJFvcAlPs9ZLuAFWvGb5GZmRVC+X/ 7YPMSNPFMOQFejWSzlIeSpzOzrvhyQC7qKYehYG6+XAiyw6tlrhA+MUel0/wzgCrhMyjComsiXKLw I2M5izag==; Received: from [187.74.70.209] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1qKLOH-00Eaot-UF; Fri, 14 Jul 2023 18:11:34 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, pierre-eric.pelloux-prayer@amd.com, =?utf-8?b?J01hcmVrIE9sxaHDoWsn?= , Samuel Pitoiset , Bas Nieuwenhuizen , =?utf-8?q?Timur_Krist=C3=B3f?= , michel.daenzer@mailbox.org, =?utf-8?q?Andr=C3=A9_Almeida?= Subject: [PATCH v3 0/5] drm/amdgpu: Add new reset option and rework coredump Date: Fri, 14 Jul 2023 13:11:23 -0300 Message-ID: <20230714161128.69545-1-andrealmeid@igalia.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771414042890990354 X-GMAIL-MSGID: 1771414042890990354 Hi, The goal of this patchset is to improve debugging device resets on amdgpu. The first patch creates a new module parameter to disable soft recoveries, ensuring every recovery go through the full device reset, making easier to generate resets from userspace tools like [0] and [1]. This is important to validate how the stack behaves on resets, from end-to-end. The last patches are a rework to alloc devcoredump dynamically and to move it to a better source file. I have dropped the patches that add more information to devcoredump for now, until I figure out a better way to do so, like storing the IB address in the fence. Thanks, André [0] https://gitlab.freedesktop.org/andrealmeid/gpu-timeout [1] https://github.com/andrealmeid/vulkan-triangle-v1 Changelog: v2: https://lore.kernel.org/dri-devel/20230713213242.680944-1-andrealmeid@igalia.com/ - Drop the IB and ring patch - Drop patch that limited information from kernel threads - Add patch to move coredump to amdgpu_reset v1: https://lore.kernel.org/dri-devel/20230711213501.526237-1-andrealmeid@igalia.com/ - Drop "Mark contexts guilty for causing soft recoveries" patch - Use GFP_NOWAIT for devcoredump allocation André Almeida (5): drm/amdgpu: Create a module param to disable soft recovery drm/amdgpu: Allocate coredump memory in a nonblocking way drm/amdgpu: Rework coredump to use memory dynamically drm/amdgpu: Move coredump code to amdgpu_reset file drm/amdgpu: Create version number for coredumps drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 67 +----------------- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 9 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 79 ++++++++++++++++++++++ drivers/gpu/drm/amd/amdgpu/amdgpu_reset.h | 14 ++++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 6 +- 6 files changed, 111 insertions(+), 70 deletions(-)