Message ID | 20230714010141.824226-1-ilkka@os.amperecomputing.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp2192678vqm; Thu, 13 Jul 2023 18:07:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlHt+FmGc38Qj2qP9nGVYY3kTKU4CB2Ev53Nw8VLsVRDymnF3q+Lqd8UNZ9MOF5F3YxEzmkc X-Received: by 2002:a17:90a:a787:b0:262:ecd3:990c with SMTP id f7-20020a17090aa78700b00262ecd3990cmr2903421pjq.47.1689296848882; Thu, 13 Jul 2023 18:07:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1689296848; cv=pass; d=google.com; s=arc-20160816; b=JUZwnWw3EKoulZ8l9z3eHyiHBEMGPAMuLgJxoieiDuAbFs6Z06vNrfrFkaPjzp6qH2 hh2BcrAkDF+dc+U21YqVJQDtk5X+jtRhu1poy2uj6F26BRrcSWPK1r28leeUqjDuy+SI zOq7jVKTD0L6zhMc9GEd8DeR24I7y5LTAF8QHU/8DCFM3ljfLIj1xFAbG4TFKfZCUxtM 4Vo/oUMEPStuzjjXFQ4svlz56/OZnY02vvliZyrxasFMVijXwQAUZ394o97O4RmfeogY 6Yl5msLiCS+Djqsi8hvWe3NanQOvJBCoD5UfXnNS2kmkZ9tno9qQapXKJlp88ao2NZtr MJtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :message-id:date:subject:cc:to:from:dkim-signature; bh=t7xHvM/kA4l9rUNrVhBg9XsMqEcNUDOakWs0wrg+nPg=; fh=26GyE49KjSE4+CIbBX0WsKdZgEMElM+fJ8Bjkxk50VU=; b=hZNBIBpI0CNgjIqOplsvYBaL7vCOI2TsDEtx33LHqlnZnWvuAcb4iYCCwVOZg/OZQs GxkrmGFRUgN5qQ8BtbLni6lM31XBE3GLSTY1fnYZl1gbIpE+VQomFDNRFDtOYalTEy+f rm1xpy8/EXv5xP+sLsORAXXf3YwUp3ImurzwGq/0R7SDDFdY14W5VUou3QXqzc6byz+p VsiJ5wOHQwVWkovvSnAFianR72DtD3v4t4yMTMIXpvmZC6GQ1u4XhseHQEGYixIzPkPB BZZMR3w76KXv96uuPHkXruEyoANlObgfWEuWEUifwJiokHaRu91T8w61NIjEOG2u+Bsd yS9g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b=CTeQ1aG9; arc=pass (i=1 spf=pass spfdomain=os.amperecomputing.com dkim=pass dkdomain=os.amperecomputing.com dmarc=pass fromdomain=os.amperecomputing.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amperecomputing.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ie10-20020a17090b400a00b00262fc8d4dfesi274231pjb.108.2023.07.13.18.07.16; Thu, 13 Jul 2023 18:07:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b=CTeQ1aG9; arc=pass (i=1 spf=pass spfdomain=os.amperecomputing.com dkim=pass dkdomain=os.amperecomputing.com dmarc=pass fromdomain=os.amperecomputing.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amperecomputing.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234575AbjGNBCR (ORCPT <rfc822;ybw1215001957@gmail.com> + 99 others); Thu, 13 Jul 2023 21:02:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbjGNBCP (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 13 Jul 2023 21:02:15 -0400 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2099.outbound.protection.outlook.com [40.107.220.99]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F18521FEA; Thu, 13 Jul 2023 18:02:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JOIJ2yJRoq6vd8QYQG9/NpWlkH6f6SkhGuqRS5USiR++pTC5X4Mb9ub7D3jvtqxWhQY0BbRBl4KB+CpkVjJPgkNFpxf1mhAWlIirgnQpyDUZkAbqmiFAk/5N2S5RYrRjiEAx6DXoZ/GjFCdjJYbKePRPgVfw0a+CRROMYXLXA0yIgMEB2JGbBz+th2fTtYLMsMOE7nuLybqiGGKP1AMdO0YlJoqmtItS3Pw5RpdZzeGDMqcvc3Mb9iC7e8pywDscSYF5d2URmdbheThzy6h2Mnmj/STCsiJSgGnHPrH0uw4YTAyrHm+lDu+bKU4l3WLAFE00ZwVM5/IWRR5oVXJKaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t7xHvM/kA4l9rUNrVhBg9XsMqEcNUDOakWs0wrg+nPg=; b=gYMrqJhtWx7vjIXKc2n09XwMmLS3dNOTfdC+SJv9rrHbSL5cn6cs5fwGe2TLRTnTBzEFit6mmDaDgXXob2/x/dNeFYGzaH1daCm3vnrfMk1sKn0Zvb461iY4UMrt+SSy6Z1p6jgJEYhJh6ZqCv9nq+j+A1K4456Vj1bPQnNCByXXEunKv4LxzRnK4LAjUdg4VFctCDvKOv4/EQNmNdO0MgZSvkCoBxrNo36n5brB0A8e2EvFonpQZOcRWnbR6OCwNd0bws3ipIwSu1mCLlUYXZlogI6xcyT7oNj3YA/JmC89eXmSd+Qsm9r46jSt6uhy+udiC4ys2Z/ztyInAUiiJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t7xHvM/kA4l9rUNrVhBg9XsMqEcNUDOakWs0wrg+nPg=; b=CTeQ1aG9I8IRH2APo/vfiiOG8zG7SJBAI10ZcF7S3neQ/b/j7QUf2lkJ1LIfNTx6kPV4/hV9HateOSMH7+/Aw+CHXpnaWRU7Yw6btkl4cqkicOg4NLYe1/XHkqrZkhfFDIR9kczMUvrCF8b9WVus+hdSxaTqOmSgFiNJ2ynypQw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) by BY3PR01MB6611.prod.exchangelabs.com (2603:10b6:a03:36a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.27; Fri, 14 Jul 2023 01:02:08 +0000 Received: from DM5PR0102MB3590.prod.exchangelabs.com ([fe80::235a:622:9239:3963]) by DM5PR0102MB3590.prod.exchangelabs.com ([fe80::235a:622:9239:3963%7]) with mapi id 15.20.6588.017; Fri, 14 Jul 2023 01:02:08 +0000 From: Ilkka Koskinen <ilkka@os.amperecomputing.com> To: Will Deacon <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, Besar Wicaksono <bwicaksono@nvidia.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Mark Rutland <mark.rutland@arm.com>, Jonathan Corbet <corbet@lwn.net> Cc: Ilkka Koskinen <ilkka@os.amperecomputing.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: [PATCH v5 0/4] perf: ampere: Add support for Ampere SoC PMUs Date: Thu, 13 Jul 2023 18:01:37 -0700 Message-Id: <20230714010141.824226-1-ilkka@os.amperecomputing.com> X-Mailer: git-send-email 2.40.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: CH0P223CA0013.NAMP223.PROD.OUTLOOK.COM (2603:10b6:610:116::30) To DM5PR0102MB3590.prod.exchangelabs.com (2603:10b6:4:a4::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3590:EE_|BY3PR01MB6611:EE_ X-MS-Office365-Filtering-Correlation-Id: e513d80a-87d7-4697-510c-08db8405f284 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kOdoI20KWQbLL/ZZQf08H/fTIeR1Zpyz0mi9K9HnOfob4qowXaEo3PwarwIRI0VLAAgu6/SxxOzv4atJrzNTXebBdagp34cNIekQMEobKzT22fviOYevFTtj/BgekzO7xKAfSXtWcx622KUHtDFQG9UjAK8MFwjdCt6KEKJGj3O8JelRKvutyx10OmHbsF3iQ0dY9iBpoXSfOEn/5MOgkPjhIObvkbjJujrHvms9tEzF0CeRhbeysgZsP+sLqby12azXWp6FczTVxDu0ZvusQs35qa95gAVEJHoKYhPET7zfwB8WBLGmDQfrcoib9L4cQfYgJh1E48NCKCfg7/rlYfNeutmp2nC1DhjpVtQD+b4uOskefkueQ5NsPzmIvOkw6nc507LxAeiK3sk6CUedAKy6t9r5Zge3++yOl6XzM2JX9mUPpBtgBkQYEXVdE6RkgpRNMUGyWCRkrEXSADmtg5ZsEMw+YIqH1cO7XyJAuxHE+0DmOIIk/F/souguSXF7eiB/RfcKBFVtYFLEKzXd+Ft7Y/eQV7ISUuRYjlS9GCMxWdYWLBr4yemRq7V9MhhYSZImkEGhFJumPzpOXMGBmimltkeGeDyAbtZngTgPgdGCjWt6FMmxkHbnMM44eNvW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3590.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(396003)(366004)(346002)(136003)(39850400004)(376002)(451199021)(2906002)(38100700002)(38350700002)(6512007)(83380400001)(186003)(2616005)(26005)(1076003)(86362001)(6506007)(5660300002)(8676002)(8936002)(7416002)(110136005)(478600001)(6486002)(52116002)(6666004)(41300700001)(66946007)(66556008)(66476007)(316002)(4326008);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Jnw15+n75xoLosSPJdD+yHVvDIQTO8rfOc3bqn/eNlxJC3zGlYg0FNChb6iUtpAz61R5sU/yFnZrUydKx8KL6YTmdJp8wHEjp0i4fsfmgo1pBSFovwi8rN7FFd9/uoKAht3iwfhAMrwez6G6MUaFec0ZG7hVTv353e9I5F0BqExj2AG6IY/3zLuYBqN0MEaHuizuLl3zBWxUIxBV9OrZ9ES04VWklhR2V6KPyQkXa+YzQm0vT5GITaDr0m5VjFAiulWMKlM9/mgQZR/77VlyQSwGr/6JPA/5uHyUYNap0R1Gg1y98+XhqcqTlQs3tnHr6Isb96BPvfU2d/jtXPaoPZQbPfIlZLOFBM1slStKa4TXOKwiEMYIIyQOVMd0C6PMvoYnDw654zNmqtasYCgX9CK5lok9pcgbDK59YKXY6tuMkhBHufHSo7ql33hy6cdgJl/pCs77oCpkJ0MxgzL3eC0wxyMcYANAAjkUFc8GwmuKOeReVCVk0mFiXsqJSJ/myPLiIe58OUv7/5aHObDjIl7NJxCNAZKc94f/U60z/3cdm6M9kQcRKO0SPLF7IcOzgM6mJpRcm+4EqhP7I83WUrsn7KRZY9mA1vmzrbNyQ2oy1Bwb3UIc+KLZSuErHsR8iePEYgwsaUPla73HLfVG6rHDuXB/Fdf3+ikMqJmlp8JdmOgYn0fuwFIh1alQWclJyzAX7AcUOmdniynkp4OQXBJSV1pUwt1wlcytgiv9XTiFwZYL34kQlvWITsiXYcEIzEVAJSORVDTtTm/v4zUwX0WYwpUqOCZJC+KEHKV/vBe2Qrwmtous7m41UkyUK1qY0ZJ2pzdxaZTFfl+eZXRwyf8CHlTtV7xEcrgRNuWg/Rz58m9BP0DFN6rSxyC8daDIU7cIuJ4OJ7PXAcM8g46oQSgbUXFv6F8w5Q33gEa+58qHLpD6QeKyD6RYf/l8YFEIZ310FyTZllXTtCnl2TR3vrAr4pzVlkToRRWGNvGH0rpsL2ESiz78041x4sdgx1BJL2ReSZ78hF0RAJS7lUW7xL/ylJShdpV+5k3SpkqmU5ej85+rnfKCUIc4ujkhi/6UkESrda93K3BdTm0J4scv5jSClM/jt8eVYH9ssSGZ+WdZ7STp69my0C4PkBc2HYTHIKiNgrBq9pkAHOVufnj+XQ3QiIaNEGeSD8p1bP/zNMsb17hiMBuxXGjrRaCXAjIf5VdyahN1+FR8RY8WG4ytRZp7FSBTAR1ROY583n6+lutNckS4bpORSywzQMikwXZ4qmCcsmb4liQbgde7lhQaaQO4JF8y1b+JvhK8lPSMQSj31eAOcH5D4iKKBT5hgGc73HqIjmhB1XsyN5KmAYLgI93vaiTc20tS5f7cKPTALvOBXKdqTx8NZ0HE1IVdt2f6cRyZ1D/oCIo3JvugvypqUbdOu89CmXsSFR0tpnfWF3iPWw0jdhmchW/vNX3XoOthcbBJesAPU0yZWjbP9/ovfk8TEn3LyR5H/CNrbMRdudlsVKEPrzg2pTEYigHoqh40BY8Qij7l2tUUd3GXRqrsOaUhvpTxu31wysZoLMbH2Xb5qIiby65/zy9A/Qm+tQEfcCtLcaOeVkgYdsG4CJfNCQ== X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: e513d80a-87d7-4697-510c-08db8405f284 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3590.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2023 01:02:08.4384 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VvL3LwkUaI9lwSnrkLRPtupK6ENLV7Z3/cCEFB0+b1LslIpsAeDbxPGN+DGRJHZDQd2914bc7V0c+74ayJmPKM+9kXKUu0aselbsIuzT774G9NsL2IEUHFc8u3SWS14R X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR01MB6611 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771356132267711319 X-GMAIL-MSGID: 1771356132267711319 |
Series |
perf: ampere: Add support for Ampere SoC PMUs
|
|
Message
Ilkka Koskinen
July 14, 2023, 1:01 a.m. UTC
Changes since v4: * "Support implementation specific filters" patch: - Added comment about filter and impdef registers and reference to the Coresight PMU specification to the commit message * "Add support for Ampere SoC PMU" patch: - Fixed the documentation and added more comments - Changed the incrementing PMU index number to idr_alloc() (Needs a impdef release hook patch to release unused index) - Fixed style in init_ops() to more reasonable - Moved bank parameter to config1 Changes since v3: * use_64b_counter_reg => has_atomic_dword (patch 1/4) * Removed the unnecessary hook for group validation (patch 3/4) * Added group config validation to ampere_cspmu_validate_event() (patch 4/4) * Rebased the patchset Changes since v2: * Changed to use supports_64bits_atomics() and replaced the split writes with lo_hi_writeq() * Added implementation specific group validation to patch 3 * Dropped shared interrupt patch * Removed unnecessary filter_enable parameter from ampere module * Added group validation to ampere module Changes since v1: * Rather than creating a completely new driver, implemented as a submodule of Arm CoreSight PMU driver * Fixed shared filter handling Ilkka Koskinen (4): perf: arm_cspmu: Split 64-bit write to 32-bit writes perf: arm_cspmu: Support implementation specific filters perf: arm_cspmu: Support implementation specific validation perf: arm_cspmu: ampere_cspmu: Add support for Ampere SoC PMU .../admin-guide/perf/ampere_cspmu.rst | 29 +++ drivers/perf/arm_cspmu/Makefile | 2 +- drivers/perf/arm_cspmu/ampere_cspmu.c | 243 ++++++++++++++++++ drivers/perf/arm_cspmu/ampere_cspmu.h | 17 ++ drivers/perf/arm_cspmu/arm_cspmu.c | 29 ++- drivers/perf/arm_cspmu/arm_cspmu.h | 6 + 6 files changed, 321 insertions(+), 5 deletions(-) create mode 100644 Documentation/admin-guide/perf/ampere_cspmu.rst create mode 100644 drivers/perf/arm_cspmu/ampere_cspmu.c create mode 100644 drivers/perf/arm_cspmu/ampere_cspmu.h
Comments
On Thu, Jul 13, 2023 at 06:01:37PM -0700, Ilkka Koskinen wrote: > Changes since v4: > * "Support implementation specific filters" patch: > - Added comment about filter and impdef registers and reference > to the Coresight PMU specification to the commit message > > * "Add support for Ampere SoC PMU" patch: > - Fixed the documentation and added more comments > - Changed the incrementing PMU index number to idr_alloc() > (Needs a impdef release hook patch to release unused index) > - Fixed style in init_ops() to more reasonable > - Moved bank parameter to config1 This looks pretty good to me, but I think we should merge the series reworking the backend registration first: https://lore.kernel.org/all/20230705104745.52255-1-bwicaksono@nvidia.com/ and then this should slot in quite nicely. I've left a minor comment over there and I'd like Suzuki's review, but then we're good to go. Cheers, Will
Hi Will, On Fri, 28 Jul 2023, Will Deacon wrote: > On Thu, Jul 13, 2023 at 06:01:37PM -0700, Ilkka Koskinen wrote: >> Changes since v4: >> * "Support implementation specific filters" patch: >> - Added comment about filter and impdef registers and reference >> to the Coresight PMU specification to the commit message >> >> * "Add support for Ampere SoC PMU" patch: >> - Fixed the documentation and added more comments >> - Changed the incrementing PMU index number to idr_alloc() >> (Needs a impdef release hook patch to release unused index) >> - Fixed style in init_ops() to more reasonable >> - Moved bank parameter to config1 > > This looks pretty good to me, but I think we should merge the series > reworking the backend registration first: > > https://lore.kernel.org/all/20230705104745.52255-1-bwicaksono@nvidia.com/ > > and then this should slot in quite nicely. I've left a minor comment over > there and I'd like Suzuki's review, but then we're good to go. > > Cheers, > > Will Sounds good to me. I'll try to find some time to do the needed changes to my patches and rebase them on top of Besar's patchset. Cheers, Ilkka