From patchwork Thu Jul 13 16:27:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marco Pagani X-Patchwork-Id: 12014 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp1947013vqm; Thu, 13 Jul 2023 09:37:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlHl+GuA60WwJgzKeC706+TDXSiwFxa/pBNLXiXpCS4bE+qQGDdtCzL8CAPH+kpVuUoh/ZEI X-Received: by 2002:a05:6a20:549f:b0:122:c6c4:36b1 with SMTP id i31-20020a056a20549f00b00122c6c436b1mr2572752pzk.4.1689266253553; Thu, 13 Jul 2023 09:37:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689266253; cv=none; d=google.com; s=arc-20160816; b=XHHtiLWhySxp+mG8R8l5PqgUtIdcn+Y74PgJjXJxKMWbafBUmeqCJbuV2sSKwhuw/g vZ6czWoLXb2gdpDum5BxJefp30vYQ++3amKDRmdOFIThwutc7zxHAP/AETw2xzzrJBUh UT4ZYHr231N1B49PTNp5ecvjAV+5iwreg6lwCfgRKTj29lyT8/RiFs77dlW08vhvxLpi hMt2UUNmnbQNDbTyGlviw75Gfot5DLsj3Taqpo3Ba3YawJhtB6sFeVkH2csbqunWwkYU ZHKTa7ugLsCYeHavy3RWzD4ARI13lC3JxEzN07sX197gfvCTFFTn9zBZFWnHvBlwW/e2 GCqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=A2FScgjIIHr5dgpOjhRwvmNpnwN6mlAl3MXJ/NNsJ8Q=; fh=M37Ydd+BXMWH9O/XP+uN5l3PQrnD/ZjHRj9NyKzE96w=; b=Hq/wR3p7A28wGXX4ZOUIWBA/6xnhST+sOkCuOoiQIBIMlfOA8MAWXIYwNHNCL5rABp DfrNYUatie60ZlAI17VqK2ygCBMAu/jSCIrbbox6wsixM/qCVahoxMaEsmPalRubVGgu JyYJk4DOtzNJp7VjKBclfy6Sl8oQLopc3augYeoHLBW8CL95QIPd4eEobuLj+F0EbtcI j4BcA+MCGsKno2iVZLAcBHN2nj71KMN45DSXFFHhME8ZGQjJa4xPiknetVvqHzRqyK7k s0D7jFHxwzPvG2R/z3XkySVdS3/b8i1CTpFDmlLN4cGAWCefCJ6NPwqOKX7N6Q4FkVbq 6oWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PM+Sy5pg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ct11-20020a056a000f8b00b00682574b6ef1si5297417pfb.381.2023.07.13.09.37.20; Thu, 13 Jul 2023 09:37:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PM+Sy5pg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235182AbjGMQ2g (ORCPT + 99 others); Thu, 13 Jul 2023 12:28:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbjGMQ2d (ORCPT ); Thu, 13 Jul 2023 12:28:33 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE819272A for ; Thu, 13 Jul 2023 09:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689265661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=A2FScgjIIHr5dgpOjhRwvmNpnwN6mlAl3MXJ/NNsJ8Q=; b=PM+Sy5pgn7Q8/8MQNrenkukDZmPex4tUvCfwSbpmmMq8cm9XNDLNYS/siIKhvvJ8pgsFiE qMzF9aEkes7t0bNcbRKINfd3bZJ+3wP3a6/fsCYPFQmhgAhjXqeT96phocSrm42UWtHLc4 HM/Ygk90XRL0iAKpK3o3YqHcE2N7B2A= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-6WBDSliiN_a4DJQp8s60Hw-1; Thu, 13 Jul 2023 12:27:39 -0400 X-MC-Unique: 6WBDSliiN_a4DJQp8s60Hw-1 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-634dacfa27bso8940756d6.3 for ; Thu, 13 Jul 2023 09:27:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689265659; x=1691857659; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A2FScgjIIHr5dgpOjhRwvmNpnwN6mlAl3MXJ/NNsJ8Q=; b=kH9RWM0CIHlJc21aOlU/PvaK5AX9ZkwPYmX2JFomN13foR8+JRISdNW+NiiJnUG76o iMoSwvsmZmLbp/yNlsupdmdAaMKKEQgeU/evu+ZxiTvpq0u/vnAK3ijKKJB62mFDMNIg tF2DRo2yKJcirNStIQuvzSSrJH3nbEP6cBBXczK5sStsBJYR86o5qhs0HryKWckULqAv tGGYFSQb2yNXpNX5ibG4sOhNzekH69FwJZRh4hUsjHhs6Szr3vVOcXyUTlfH7a/sod0Q 86XuFsTpkvFn8TfPMuXvUn1nCMSWhH9l93hmRQb1bkDEY5jmXyiLrRBAhGCR21E8rLnh F1bw== X-Gm-Message-State: ABy/qLbY4ek68qK6eS95XujlhvNu5Do1TWlfkAa6N0/xOslaTGEY7YvI PH1tWbQPFhN1HKTYBkMaMp6TMAM944mYfCmU1CaJHUDxWTOwbp45H0UleErVQzlW4W0YjResE2V IhRq90JRrL4hQqQE661GTglk= X-Received: by 2002:a0c:de0e:0:b0:635:eee3:e30a with SMTP id t14-20020a0cde0e000000b00635eee3e30amr1788628qvk.18.1689265659273; Thu, 13 Jul 2023 09:27:39 -0700 (PDT) X-Received: by 2002:a0c:de0e:0:b0:635:eee3:e30a with SMTP id t14-20020a0cde0e000000b00635eee3e30amr1788617qvk.18.1689265659051; Thu, 13 Jul 2023 09:27:39 -0700 (PDT) Received: from klayman.redhat.com (net-2-34-24-242.cust.vodafonedsl.it. [2.34.24.242]) by smtp.gmail.com with ESMTPSA id u17-20020a0cf1d1000000b00637873ff0f3sm3206582qvl.15.2023.07.13.09.27.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 09:27:38 -0700 (PDT) From: Marco Pagani To: Moritz Fischer , Wu Hao , Xu Yilun , Tom Rix Cc: Marco Pagani , linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org Subject: [PATCH v9 0/4] fpga: add initial KUnit tests for the subsystem Date: Thu, 13 Jul 2023 18:27:27 +0200 Message-ID: <20230713162731.211669-1-marpagan@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771324051368485649 X-GMAIL-MSGID: 1771324051368485649 This patch set introduces an initial set of KUnit test suites for the core components of the FPGA subsystem. Tests can be run using: [user@localhost linux]$ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/fpga/tests v9: - Improved and commented test ops for the FPGA Manager test suite - Fixed minor capitalization discrepancies v8: - Using memset to set header and payload of the test image - Using sg_miter_* functions to check the image in the write_sg op - Includes sorted in alphabetical order - Add commas for fpga_bridge_ops - Improved Makefile v7: - Dropped RFC prefix - Add comments to explain fakes and helper functions - Changed the implementation of the Bridge used in the Region suite v6: - Restructured the code into self-contained test modules - Added tests for the basic behaviors of the components - Improved programming tests for the FPGA Manager - Fixed code/comments mismatch in the list of Bridges test case v5: - Removed most of the exported functions using shared buffers for stats - Moved all KUnit expectations/assertions to the main test module - Removed standalone use case to simplify the code - Removed instances counters from fake components (using device.id instead) - Set header size in the .parse_header op - Improved bridge get_put_list test case v4: - Fix build error v3: - Calling fpga_bridges_put() between reconfigurations - Functions for registering fake modules allocate and return context structs v2: - Restructured code into multiple suites to test components in isolation - Reduced code duplication using init and exit methods - Using a get_bridges() method to build the list of bridges just before programming - Regions and Bridges are organized topologically - Changed bitstream/bit to images - Allocate images dynamically - Renamed fpga-tests to fpga-test - Simplified Kconfig - Add license info to the fpga-test module Marco Pagani (4): fpga: add an initial KUnit suite for the FPGA Manager fpga: add an initial KUnit suite for the FPGA Bridge fpga: add an initial KUnit suite for the FPGA Region fpga: add configuration for the FPGA KUnit test suites. drivers/fpga/Kconfig | 2 + drivers/fpga/Makefile | 3 + drivers/fpga/tests/.kunitconfig | 5 + drivers/fpga/tests/Kconfig | 11 + drivers/fpga/tests/Makefile | 6 + drivers/fpga/tests/fpga-bridge-test.c | 175 ++++++++++++++ drivers/fpga/tests/fpga-mgr-test.c | 329 ++++++++++++++++++++++++++ drivers/fpga/tests/fpga-region-test.c | 211 +++++++++++++++++ 8 files changed, 742 insertions(+) create mode 100644 drivers/fpga/tests/.kunitconfig create mode 100644 drivers/fpga/tests/Kconfig create mode 100644 drivers/fpga/tests/Makefile create mode 100644 drivers/fpga/tests/fpga-bridge-test.c create mode 100644 drivers/fpga/tests/fpga-mgr-test.c create mode 100644 drivers/fpga/tests/fpga-region-test.c base-commit: 06c2afb862f9da8dc5efa4b6076a0e48c3fbaaa5