Message ID | 20230710154932.68377-1-andriy.shevchenko@linux.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp5118161vqx; Mon, 10 Jul 2023 08:51:35 -0700 (PDT) X-Google-Smtp-Source: APBJJlFPYpagrV75PRfvD0Ee5G4D1bd292LJ93NntQ8D9i0U3OuGgUMGjsmWZFnI7irt5Drahxie X-Received: by 2002:a17:90a:5314:b0:262:c291:4b6c with SMTP id x20-20020a17090a531400b00262c2914b6cmr13720607pjh.45.1689004295577; Mon, 10 Jul 2023 08:51:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689004295; cv=none; d=google.com; s=arc-20160816; b=HDrh6gdWHgD1LB0oyVLQLX/q1dETnFYcbCpgbcpUwr0SuPiPn6XCnvQOJvWPmtnYxz DcqetFzuNKZQIzTv5mR1nHZwdOi2KVcMskoXcYQxaRj2MErA+Naw857p1IkB9DrhpXSR vL8r/2wQD4dhMEil/KPKgodjTngfT5ON3UcHP/wSwC7Oxy34DFjAr3XojHg43XoWoxMW QI0TtuSeviP8LJzGFmmf72xLN0g5OrETqjRwu9pFEIMuz9SsNqTLPYw6k6Kszttjq/sj tRLNq7cQO8igisCVNADohr64xjB/hY+9oene/NADURze8iTxCuOQv0mnTNc9WEbsX5F5 LfCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/T1+ETU4HKY13N1/qW+GdSTm2ZCn+muVgWZ4DXNhYYA=; fh=CWfEt6/vd4IsHMc+T8W3bMkH4b5uOoX72TeJSijIGlU=; b=cBpcatajj8n2UsdNQlOVJeyU/XJVJQ+jS8ckrEI+ahP/KxWcqnsMVAuGsDm+ptK5Vy UQjG96cMJJve1jH9Cg3r09xmQyUkwFFc2jZtEYVr0+kzaJE67rX4J8OZhLIjBqyFLqm9 zKvlKLcoE/ggwsBjc8XLiOu6zltoFsrNdB9Z3FkZZ85bnRRpb1zMFnP2JxzTNpHq4h+J pExpq68U8LVjr2v0Ii8JFHkIKQg/1XPetmDyKt7nOq5+Zmwps8aHtPtjR0reSktEVuWd rUakWMLqdB9fimzRctYejUQCOudPJExvb3BdL4WPvDdGc4wD5vHMOud9/yzBbKeXiE5Y puTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ARnnqONJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d14-20020a17090ad3ce00b00263b4a986cfsi7475224pjw.73.2023.07.10.08.51.21; Mon, 10 Jul 2023 08:51:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ARnnqONJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbjGJPtr (ORCPT <rfc822;ybw1215001957@gmail.com> + 99 others); Mon, 10 Jul 2023 11:49:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233555AbjGJPtn (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 10 Jul 2023 11:49:43 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2994710D; Mon, 10 Jul 2023 08:49:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689004182; x=1720540182; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=qyXZ9l/eDXJvwNtej9Cq3pKS54WfQZS0AfJJYPgySOQ=; b=ARnnqONJocfxNg7P/7hx4qrID8s8+ajcsr7cB6fPQ21uGVAnK88BrHdE nYCtUgDA0HnzcfhjEAyA96C7WqH+qKZAUh+j4qCbrW5pjz2UGetfbREwT AV6yzzY5KfYOeoyt8/LF8UMgBL3+UJCFe902vfUgfaOrgOlGuaBn+J6ZY p2kRSPwH9aV+PS2ss32nI4pNoJMV7QzWAGs1xhCGABdW6S16dQya5zHM7 dsvUrHUeIzcD18xdWa30OZ1x7AkLWnNDggvcegmL6Rq4+sB73sxeASduS RZtgZF4OlV9zaY7aLGN86OvuWY7PmMNsZUV5nw8Efo+de3F2GvZTogRco Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="361842418" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="361842418" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 08:49:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10767"; a="720743951" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="720743951" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga002.jf.intel.com with ESMTP; 10 Jul 2023 08:49:29 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 115861FC; Mon, 10 Jul 2023 18:49:33 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Mark Brown <broonie@kernel.org>, Cristian Ciocaltea <cristian.ciocaltea@collabora.com>, Yang Yingliang <yangyingliang@huawei.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Amit Kumar Mahapatra via Alsa-devel <alsa-devel@alsa-project.org>, Neil Armstrong <neil.armstrong@linaro.org>, Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>, Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>, =?utf-8?q?Uwe_Kleine-K?= =?utf-8?q?=C3=B6nig?= <u.kleine-koenig@pengutronix.de>, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-trace-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: Sanjay R Mehta <sanju.mehta@amd.com>, Radu Pirea <radu_nicolae.pirea@upb.ro>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Claudiu Beznea <claudiu.beznea@microchip.com>, Tudor Ambarus <tudor.ambarus@linaro.org>, Serge Semin <fancer.lancer@gmail.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Heiko Stuebner <heiko@sntech.de>, Palmer Dabbelt <palmer@dabbelt.com>, Paul Walmsley <paul.walmsley@sifive.com>, Orson Zhai <orsonzhai@gmail.com>, Baolin Wang <baolin.wang@linux.alibaba.com>, Chunyan Zhang <zhang.lyra@gmail.com>, Alain Volmat <alain.volmat@foss.st.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Max Filippov <jcmvbkbc@gmail.com>, Steven Rostedt <rostedt@goodmis.org>, Masami Hiramatsu <mhiramat@kernel.org>, Richard Cochran <richardcochran@gmail.com> Subject: [PATCH v2 00/15] spi: Header and core clean up and refactoring Date: Mon, 10 Jul 2023 18:49:17 +0300 Message-Id: <20230710154932.68377-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771029797253282691 X-GMAIL-MSGID: 1771049368284148491 |
Series |
spi: Header and core clean up and refactoring
|
|
Message
Andy Shevchenko
July 10, 2023, 3:49 p.m. UTC
Various cleanups and refactorings of the SPI header and core parts united in a single series. It also touches drivers under SPI subsystem folder on the pure renaming purposes of some constants. No functional change intended. Changelog v2: - added new patches 3,4,5,10,13,14 - massaged comment and kernel doc in patch 9 - split used to be patch 4 to patches 11,12 - covered a few things in SPI core in patch 15 - amended commit message for above (Mark) - reshuffled patches in the series for better logical grouping Andy Shevchenko (15): spi: Remove unneeded OF node NULL checks spi: Drop duplicate IDR allocation code in spi_register_controller() spi: Replace if-else-if by bitops and multiplications spi: Replace open coded spi_controller_xfer_timeout() spi: Remove code duplication in spi_add_device_locked() spi: Use sysfs_emit() to instead of s*printf() spi: Sort headers alphabetically spi: Clean up headers spi: Use struct_size() helper spi: Use predefined constants from bits.h and units.h spi: Get rid of old SPI_MASTER_NO_TX & SPI_MASTER_NO_RX spi: Get rid of old SPI_MASTER_MUST_TX & SPI_MASTER_MUST_RX spi: Rename SPI_MASTER_GPIO_SS to SPI_CONTROLLER_GPIO_SS spi: Convert to SPI_CONTROLLER_HALF_DUPLEX spi: Fix spelling typos and acronyms capitalization drivers/spi/spi-amd.c | 2 +- drivers/spi/spi-at91-usart.c | 2 +- drivers/spi/spi-ath79.c | 2 +- drivers/spi/spi-atmel.c | 4 +- drivers/spi/spi-bitbang-txrx.h | 16 +-- drivers/spi/spi-bitbang.c | 8 +- drivers/spi/spi-cavium-thunderx.c | 2 +- drivers/spi/spi-davinci.c | 2 +- drivers/spi/spi-dw-core.c | 2 +- drivers/spi/spi-falcon.c | 2 +- drivers/spi/spi-fsl-lpspi.c | 2 +- drivers/spi/spi-gpio.c | 10 +- drivers/spi/spi-imx.c | 2 +- drivers/spi/spi-lp8841-rtc.c | 10 +- drivers/spi/spi-meson-spicc.c | 2 +- drivers/spi/spi-mt65xx.c | 2 +- drivers/spi/spi-mxs.c | 2 +- drivers/spi/spi-omap-uwire.c | 2 +- drivers/spi/spi-orion.c | 2 +- drivers/spi/spi-pci1xxxx.c | 2 +- drivers/spi/spi-pic32-sqi.c | 2 +- drivers/spi/spi-pic32.c | 2 +- drivers/spi/spi-qcom-qspi.c | 2 +- drivers/spi/spi-rb4xx.c | 2 +- drivers/spi/spi-rockchip-sfc.c | 2 +- drivers/spi/spi-rockchip.c | 2 +- drivers/spi/spi-sifive.c | 2 +- drivers/spi/spi-slave-mt27xx.c | 2 +- drivers/spi/spi-sprd-adi.c | 2 +- drivers/spi/spi-stm32.c | 2 +- drivers/spi/spi-ti-qspi.c | 2 +- drivers/spi/spi-xcomm.c | 2 +- drivers/spi/spi-xtensa-xtfpga.c | 2 +- drivers/spi/spi.c | 204 ++++++++++++------------------ include/linux/spi/spi.h | 198 +++++++++++++++++------------ include/trace/events/spi.h | 2 +- 36 files changed, 247 insertions(+), 261 deletions(-)
Comments
On Mon, Jul 10, 2023 at 06:49:17PM +0300, Andy Shevchenko wrote: > Various cleanups and refactorings of the SPI header and core parts > united in a single series. It also touches drivers under SPI subsystem > folder on the pure renaming purposes of some constants. I've queued 1-3, 6-8 and 11- for CI thanks.
On Mon, Jul 10, 2023 at 06:31:12PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 06:49:17PM +0300, Andy Shevchenko wrote: > > Various cleanups and refactorings of the SPI header and core parts > > united in a single series. It also touches drivers under SPI subsystem > > folder on the pure renaming purposes of some constants. > > I've queued 1-3, 6-8 and 11- for CI thanks. Thank you! Do you think patch 9 deserves to be proceeded?
On Tue, Jul 11, 2023 at 02:11:59PM +0300, Andy Shevchenko wrote:
> Do you think patch 9 deserves to be proceeded?
That one I need to think about, may as well resend it and I can think
about the resend.
On Tue, Jul 11, 2023 at 02:38:37PM +0100, Mark Brown wrote: > On Tue, Jul 11, 2023 at 02:11:59PM +0300, Andy Shevchenko wrote: > > > Do you think patch 9 deserves to be proceeded? > > That one I need to think about, may as well resend it and I can think > about the resend. Got it. Probably I have to amend commit message in the patch 9 to point out why struct_size() is better.
On Mon, 10 Jul 2023 18:49:17 +0300, Andy Shevchenko wrote: > Various cleanups and refactorings of the SPI header and core parts > united in a single series. It also touches drivers under SPI subsystem > folder on the pure renaming purposes of some constants. > > No functional change intended. > > Changelog v2: > - added new patches 3,4,5,10,13,14 > - massaged comment and kernel doc in patch 9 > - split used to be patch 4 to patches 11,12 > - covered a few things in SPI core in patch 15 > - amended commit message for above (Mark) > - reshuffled patches in the series for better logical grouping > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [01/15] spi: Remove unneeded OF node NULL checks commit: fbab5b2c09060e8034fee6ec2df69a62594fb7db [02/15] spi: Drop duplicate IDR allocation code in spi_register_controller() commit: 440c47331bdb889e24128c75387c695ca81d9b9b [03/15] spi: Replace if-else-if by bitops and multiplications commit: 2b308e7176e366a52a07a49868e3b1a295e56785 [06/15] spi: Use sysfs_emit() to instead of s*printf() commit: f2daa4667fda1aa951b91da0ae9675a5da9d7716 [07/15] spi: Sort headers alphabetically commit: edf6a864c996f9a9f5299a3b3e574a37e64000c5 [08/15] spi: Clean up headers (no commit info) [11/15] spi: Get rid of old SPI_MASTER_NO_TX & SPI_MASTER_NO_RX commit: c397f09e5498994790503a64486213ef85e58db9 [12/15] spi: Get rid of old SPI_MASTER_MUST_TX & SPI_MASTER_MUST_RX commit: 90366cd60133a9f5b6a2f31360367c658585e125 [13/15] spi: Rename SPI_MASTER_GPIO_SS to SPI_CONTROLLER_GPIO_SS commit: 82238d2cbd99ebd09dda48fb7c1c8802097da6a2 [14/15] spi: Convert to SPI_CONTROLLER_HALF_DUPLEX commit: 7a2b552c8e0e5bb280558f6c120140f5f06323bc [15/15] spi: Fix spelling typos and acronyms capitalization commit: 702ca0269ed56e2d8dae7874a4d8af268e2a382e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark