Message ID | 20230707153322.114302-1-gnstark@sberdevices.ru |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp3356812vqx; Fri, 7 Jul 2023 08:40:18 -0700 (PDT) X-Google-Smtp-Source: APBJJlHZbczv39Z4RjrA7z75/g7UuOK7a8edEXYucQMMWCSBsIwvO5EqZ+euMBvlGS6C55nT+8+i X-Received: by 2002:a05:6870:4292:b0:1b0:657f:5047 with SMTP id y18-20020a056870429200b001b0657f5047mr6354167oah.46.1688744417896; Fri, 07 Jul 2023 08:40:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688744417; cv=none; d=google.com; s=arc-20160816; b=UJnm28dyL0rxNNG3xeGu2c6HDIl3ddCiZpSrEo6f2QQh7Dj2tO9t06NyGEDJ56hb68 wfyPoRU7jcr2fvbpiaEH2V/D9OlXDgSt2fAM1ikdWfV9B9VnSMe/qfwtA54ZMqDkuDTn Yt2PFqVn8x0lzCI7xCPLUroXgr9IAD3FrS3BMvzRbKdfpRUU0WmuOAroSRHWjlFD/JmM gYWEzVNkEo2r7s8Hmq6/nRfaT7nm6w0+fFILmgvBZtzlu9X2xRnGTkL1dENtaPyxUzPG iph5AxVbkqLPaaIBXminjMZj/CQVzfWmHsDDUI06BOuhmtA6m0WEcFSbKKoWgSPjEomb 7yHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature:dkim-filter; bh=GKtM0bSwk3y4gBkptV+v8XDqcrZiJgzslOcrYoAtv4g=; fh=Nkpk7VjQstRrk/SIKeFB2DsfhHIA7OANQWPD54Aly/o=; b=QGEdtZxZMPSVDwoE39zrRtEsnDSD2odxScZhevLHMNLg5owBXG49G/dWnk3ig/xNCp cwYrifzARmJUO6NySHYgIKyzmC8tm73WFLD7pChSxXSDDm/VB508z9WL6emn0iW5ez+N A3+35FunWBVx9xQ7TWZA+V2hp5jkW538QsDBotzmO6pyF/ubwTTelo66Ijpq5Vq1aHgF kdPWT5SagDn5nKtKPP3+XjRzmvAfJw+ggb6aJsr6RrSAdtniXs+NuGFsipBk0hx8sSIB R0wR889uhVpXyVFKbjKlURo+CEqMLthbJhO2dHrTi2ShEyIF8Q4sMoPp4FaFvryWjBDi UmtQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b="W/Cq9Wae"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mg7-20020a17090b370700b002639ae468d4si2211767pjb.162.2023.07.07.08.40.03; Fri, 07 Jul 2023 08:40:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b="W/Cq9Wae"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232831AbjGGPd5 (ORCPT <rfc822;tebrre53rla2o@gmail.com> + 99 others); Fri, 7 Jul 2023 11:33:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230443AbjGGPdj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 7 Jul 2023 11:33:39 -0400 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 803D12123; Fri, 7 Jul 2023 08:33:35 -0700 (PDT) Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id A0397120010; Fri, 7 Jul 2023 18:33:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru A0397120010 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1688744012; bh=GKtM0bSwk3y4gBkptV+v8XDqcrZiJgzslOcrYoAtv4g=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=W/Cq9WaeaAXXAZoG/ni/YfrW58kcWRQRFU0JbkcrxG/FLtQe3jOm4CZnU1duCNeQ6 AhC5Wg7fuMyWih0PBLFsi6a+RkDLN4i86dsV/HXhfQ4FQ0eIjBemzWVd8kgNRckn7D dYWUvQbv6a8VNl9FYL59Zkigb+GKZLnAy+UqdNusD9F8PvBnT68wB5wqX8QZWV7JDJ /BKCNdj2usNvEbDum2Up63ybTXKtcTkCMVTrL9yaENvcqOl3TPc3OcgPlO+cr9HIy8 SjdqWeCoRlAiznHkcK1pANvgi/UDFq9MX9NvbN/rFs2jU3wUtzYFhx/OkjcH4UxTD/ fFmFvTScKBSfA== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Fri, 7 Jul 2023 18:33:32 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Fri, 7 Jul 2023 18:33:15 +0300 From: George Stark <gnstark@sberdevices.ru> To: <jic23@kernel.org>, <lars@metafoo.de>, <neil.armstrong@linaro.org>, <khilman@baylibre.com>, <jbrunet@baylibre.com>, <martin.blumenstingl@googlemail.com>, <andriy.shevchenko@linux.intel.com>, <nuno.sa@analog.com>, <gnstark@sberdevices.ru> CC: <linux-iio@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <linux-amlogic@lists.infradead.org>, <kernel@sberdevices.ru>, George Stark <GNStark@sberdevices.ru> Subject: [PATCH v4 0/6] iio: adc: meson: add iio channels to read channel 7 mux inputs Date: Fri, 7 Jul 2023 18:27:37 +0300 Message-ID: <20230707153322.114302-1-gnstark@sberdevices.ru> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 178491 [Jul 07 2023] X-KSMG-AntiSpam-Version: 5.9.59.0 X-KSMG-AntiSpam-Envelope-From: GNStark@sberdevices.ru X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 520 520 ccb018a655251011855942a2571029252d3d69a2, {Tracking_uf_ne_domains}, {Tracking_from_domain_doesnt_match_to}, lore.kernel.org:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;sberdevices.ru:5.0.1,7.1.1;p-i-exch-sc-m01.sberdevices.ru:5.0.1,7.1.1;100.64.160.123:7.1.2, FromAlignment: s, {Tracking_white_helo}, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean, bases: 2023/07/07 14:34:00 X-KSMG-LinksScanning: Clean, bases: 2023/07/07 14:35:00 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/07/07 03:24:00 #21575635 X-KSMG-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770776866893577753?= X-GMAIL-MSGID: =?utf-8?q?1770776866893577753?= |
Series |
iio: adc: meson: add iio channels to read channel 7 mux inputs
|
|
Message
George Stark
July 7, 2023, 3:27 p.m. UTC
From: George Stark <GNStark@sberdevices.ru>
Changelog:
v1->v2:
split refactoring patch [1] into 4 smaller patches, fix comment style
[1] https://lore.kernel.org/lkml/20230621062715.455652-2-gnstark@sberdevices.ru/
v2->v3:
remove patch 'meson saradc: unite iio channel array definitions' [1] after discussion
patch 'meson saradc: add enum for iio channel array indexes'
- change enum items prefix from INDEX_ to NUM_ since name 'channel index' is
more relevant to channel array index in iio world and with 2 tables our array index is
not always equal to channel number
- resolve conflicts after deleting [1]
- update commit message, previous patch [2]
- return channel number for temp channel. It wasn't used and isn't used currently
but may need later
patch meson saradc: support reading from channel 7 mux inputs
- resolve conflicts after deleting [1]
- update commit message, previous patch [3]
- add routine find_channel_by_num to get channel by channel number
[1] https://lore.kernel.org/lkml/20230623022334.791026-4-gnstark@sberdevices.ru/
[2] https://lore.kernel.org/lkml/20230623022334.791026-5-gnstark@sberdevices.ru/
[3] https://lore.kernel.org/lkml/20230623022334.791026-7-gnstark@sberdevices.ru/
v3->v4:
add new patch 'iio: adc: meson: remove unused timestamp channel' [1]
patch 'iio: adc: meson: move enums declaration before'
update commit message, previous patch [2]
patch 'iio: adc: meson: move meson_sar_adc_set_chan7_mux'
update commit message, previous patch [3]
patch 'iio: adc: meson: add enum for iio channel numbers'
update commit message, previous patch [4]
patch 'iio: adc: meson: add channel labels'
update commit message, previous patch [5]
change sprintf(label, "%s\n", "temp-sensor") to sprintf(label, "temp-sensor\n")
patch 'iio: adc: meson: support reading from channel 7 mux'
rewrite enum meson_sar_adc_chan7_mux_sel definition and
read_label routine proposed by Andy [7], previous patch [6]
[1] https://lore.kernel.org/lkml/20230705160413.000062e7@Huawei.com/
[2] https://lore.kernel.org/lkml/20230627224017.1724097-2-gnstark@sberdevices.ru/
[3] https://lore.kernel.org/lkml/20230627224017.1724097-3-gnstark@sberdevices.ru/
[4] https://lore.kernel.org/lkml/20230627224017.1724097-4-gnstark@sberdevices.ru/
[5] https://lore.kernel.org/lkml/20230627224017.1724097-5-gnstark@sberdevices.ru/
[6] https://lore.kernel.org/lkml/20230627224017.1724097-6-gnstark@sberdevices.ru/
[7] https://lore.kernel.org/lkml/ZJwGCNA+ZURri24i@smile.fi.intel.com/
George Stark (6):
iio: adc: meson: remove unused timestamp channel
iio: adc: meson: move enums declaration before variables declaration
iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper
iio: adc: meson: add enum for iio channel numbers
iio: adc: meson: add channel labels
iio: adc: meson: support reading from channel 7 mux inputs
drivers/iio/adc/meson_saradc.c | 173 +++++++++++++++++++++++++--------
1 file changed, 134 insertions(+), 39 deletions(-)
Comments
On Fri, 7 Jul 2023 18:27:37 +0300 George Stark <gnstark@sberdevices.ru> wrote: > From: George Stark <GNStark@sberdevices.ru> All looks fine to me. However, given earlier versions had various other reviewers I'd like to leave it on list a little longer. Jonathan > > Changelog: > > v1->v2: > split refactoring patch [1] into 4 smaller patches, fix comment style > > [1] https://lore.kernel.org/lkml/20230621062715.455652-2-gnstark@sberdevices.ru/ > > v2->v3: > remove patch 'meson saradc: unite iio channel array definitions' [1] after discussion > > patch 'meson saradc: add enum for iio channel array indexes' > - change enum items prefix from INDEX_ to NUM_ since name 'channel index' is > more relevant to channel array index in iio world and with 2 tables our array index is > not always equal to channel number > - resolve conflicts after deleting [1] > - update commit message, previous patch [2] > - return channel number for temp channel. It wasn't used and isn't used currently > but may need later > > patch meson saradc: support reading from channel 7 mux inputs > - resolve conflicts after deleting [1] > - update commit message, previous patch [3] > - add routine find_channel_by_num to get channel by channel number > > [1] https://lore.kernel.org/lkml/20230623022334.791026-4-gnstark@sberdevices.ru/ > [2] https://lore.kernel.org/lkml/20230623022334.791026-5-gnstark@sberdevices.ru/ > [3] https://lore.kernel.org/lkml/20230623022334.791026-7-gnstark@sberdevices.ru/ > > v3->v4: > add new patch 'iio: adc: meson: remove unused timestamp channel' [1] > > patch 'iio: adc: meson: move enums declaration before' > update commit message, previous patch [2] > patch 'iio: adc: meson: move meson_sar_adc_set_chan7_mux' > update commit message, previous patch [3] > patch 'iio: adc: meson: add enum for iio channel numbers' > update commit message, previous patch [4] > patch 'iio: adc: meson: add channel labels' > update commit message, previous patch [5] > change sprintf(label, "%s\n", "temp-sensor") to sprintf(label, "temp-sensor\n") > patch 'iio: adc: meson: support reading from channel 7 mux' > rewrite enum meson_sar_adc_chan7_mux_sel definition and > read_label routine proposed by Andy [7], previous patch [6] > > [1] https://lore.kernel.org/lkml/20230705160413.000062e7@Huawei.com/ > [2] https://lore.kernel.org/lkml/20230627224017.1724097-2-gnstark@sberdevices.ru/ > [3] https://lore.kernel.org/lkml/20230627224017.1724097-3-gnstark@sberdevices.ru/ > [4] https://lore.kernel.org/lkml/20230627224017.1724097-4-gnstark@sberdevices.ru/ > [5] https://lore.kernel.org/lkml/20230627224017.1724097-5-gnstark@sberdevices.ru/ > [6] https://lore.kernel.org/lkml/20230627224017.1724097-6-gnstark@sberdevices.ru/ > [7] https://lore.kernel.org/lkml/ZJwGCNA+ZURri24i@smile.fi.intel.com/ > > George Stark (6): > iio: adc: meson: remove unused timestamp channel > iio: adc: meson: move enums declaration before variables declaration > iio: adc: meson: move meson_sar_adc_set_chan7_mux routine upper > iio: adc: meson: add enum for iio channel numbers > iio: adc: meson: add channel labels > iio: adc: meson: support reading from channel 7 mux inputs > > drivers/iio/adc/meson_saradc.c | 173 +++++++++++++++++++++++++-------- > 1 file changed, 134 insertions(+), 39 deletions(-) >
On Sat, Jul 08, 2023 at 05:04:10PM +0100, Jonathan Cameron wrote: > On Fri, 7 Jul 2023 18:27:37 +0300 > George Stark <gnstark@sberdevices.ru> wrote: > > > From: George Stark <GNStark@sberdevices.ru> > > > All looks fine to me. However, given earlier versions had various other reviewers > I'd like to leave it on list a little longer. Code wise Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> The commit messages have to be improved, but hey, I'm not a native speaker, so I assume that Jonathan can help me with that and correct me if required :-)