mbox series

[net,v2,0/3] s390/ism: Fixes to client handling

Message ID 20230707105622.3332261-1-schnelle@linux.ibm.com
Headers
Series s390/ism: Fixes to client handling |

Message

Niklas Schnelle July 7, 2023, 10:56 a.m. UTC 
  Hi networking developers,

This is v2 of the patch previously titled "s390/ism: Detangle ISM client
IRQ and event forwarding". As suggested by Paolo Abeni I split the patch
up. While doing so I noticed another problem that was fixed by this patch
concerning the way the workqueues access the client structs. This means the
second patch turning the workqueues into simple direct calls also fixes
a problem. Finally I split off a third patch just for fixing
ism_unregister_client()s error path.

The code after these 3 patches is identical to the result of the v1 patch
except that I also turned the dev_err() for still registered DMBs into
a WARN().

Thanks,
Niklas

Changes since v1:
- Split into three patches (Paolo Abeni)
- Turned the dev_err() in ism_unregsiter_client() on still registered DMBs
  into a WARN() as it should only happen due to client bugs.

Niklas Schnelle (3):
  s390/ism: Fix locking for forwarding of IRQs and events to clients
  s390/ism: Fix and simplify add()/remove() callback handling
  s390/ism: Do not unregister clients with registered DMBs

 drivers/s390/net/ism_drv.c | 153 ++++++++++++++++++-------------------
 include/linux/ism.h        |   7 +-
 2 files changed, 74 insertions(+), 86 deletions(-)


base-commit: d528014517f2b0531862c02865b9d4c908019dc4

Comments

Alexandra Winter July 7, 2023, 1:46 p.m. UTC | #1 
On 07.07.23 12:56, Niklas Schnelle wrote:
> Hi networking developers,
> 
> This is v2 of the patch previously titled "s390/ism: Detangle ISM client
> IRQ and event forwarding". As suggested by Paolo Abeni I split the patch
> up. While doing so I noticed another problem that was fixed by this patch
> concerning the way the workqueues access the client structs. This means the
> second patch turning the workqueues into simple direct calls also fixes
> a problem. Finally I split off a third patch just for fixing
> ism_unregister_client()s error path.
> 
> The code after these 3 patches is identical to the result of the v1 patch
> except that I also turned the dev_err() for still registered DMBs into
> a WARN().
> 
> Thanks,
> Niklas
> 
> Changes since v1:
> - Split into three patches (Paolo Abeni)
> - Turned the dev_err() in ism_unregsiter_client() on still registered DMBs
>   into a WARN() as it should only happen due to client bugs.
> 
> Niklas Schnelle (3):
>   s390/ism: Fix locking for forwarding of IRQs and events to clients
>   s390/ism: Fix and simplify add()/remove() callback handling
>   s390/ism: Do not unregister clients with registered DMBs
> 
>  drivers/s390/net/ism_drv.c | 153 ++++++++++++++++++-------------------
>  include/linux/ism.h        |   7 +-
>  2 files changed, 74 insertions(+), 86 deletions(-)
> 
> 
> base-commit: d528014517f2b0531862c02865b9d4c908019dc4

For the series: 
Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Wenjia Zhang July 7, 2023, 8:19 p.m. UTC | #2 
On 07.07.23 12:56, Niklas Schnelle wrote:
> Hi networking developers,
> 
> This is v2 of the patch previously titled "s390/ism: Detangle ISM client
> IRQ and event forwarding". As suggested by Paolo Abeni I split the patch
> up. While doing so I noticed another problem that was fixed by this patch
> concerning the way the workqueues access the client structs. This means the
> second patch turning the workqueues into simple direct calls also fixes
> a problem. Finally I split off a third patch just for fixing
> ism_unregister_client()s error path.
> 
> The code after these 3 patches is identical to the result of the v1 patch
> except that I also turned the dev_err() for still registered DMBs into
> a WARN().
> 
> Thanks,
> Niklas
> 
> Changes since v1:
> - Split into three patches (Paolo Abeni)
> - Turned the dev_err() in ism_unregsiter_client() on still registered DMBs
>    into a WARN() as it should only happen due to client bugs.
> 
> Niklas Schnelle (3):
>    s390/ism: Fix locking for forwarding of IRQs and events to clients
>    s390/ism: Fix and simplify add()/remove() callback handling
>    s390/ism: Do not unregister clients with registered DMBs
> 
>   drivers/s390/net/ism_drv.c | 153 ++++++++++++++++++-------------------
>   include/linux/ism.h        |   7 +-
>   2 files changed, 74 insertions(+), 86 deletions(-)
> 
> 
> base-commit: d528014517f2b0531862c02865b9d4c908019dc4


Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com>
patchwork-bot+netdevbpf@kernel.org July 8, 2023, 9:13 a.m. UTC | #3 
Hello:

This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri,  7 Jul 2023 12:56:19 +0200 you wrote:
> Hi networking developers,
> 
> This is v2 of the patch previously titled "s390/ism: Detangle ISM client
> IRQ and event forwarding". As suggested by Paolo Abeni I split the patch
> up. While doing so I noticed another problem that was fixed by this patch
> concerning the way the workqueues access the client structs. This means the
> second patch turning the workqueues into simple direct calls also fixes
> a problem. Finally I split off a third patch just for fixing
> ism_unregister_client()s error path.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/3] s390/ism: Fix locking for forwarding of IRQs and events to clients
    https://git.kernel.org/netdev/net/c/6b5c13b591d7
  - [net,v2,2/3] s390/ism: Fix and simplify add()/remove() callback handling
    https://git.kernel.org/netdev/net/c/76631ffa2fd2
  - [net,v2,3/3] s390/ism: Do not unregister clients with registered DMBs
    https://git.kernel.org/netdev/net/c/266deeea34ff

You are awesome, thank you!