From patchwork Wed Jul 5 19:53:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Judith Mendez X-Patchwork-Id: 11666 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp2118180vqx; Wed, 5 Jul 2023 13:27:04 -0700 (PDT) X-Google-Smtp-Source: APBJJlHr8GMsSzb3FhrCyOjzEdGRemLR5C8Fros2YqE2r/6nbBTdAVP6wSHgd/BmvMUfbOYVr0a6 X-Received: by 2002:a05:6a00:2d29:b0:67a:8fc7:1b4e with SMTP id fa41-20020a056a002d2900b0067a8fc71b4emr12866399pfb.4.1688588824176; Wed, 05 Jul 2023 13:27:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688588824; cv=none; d=google.com; s=arc-20160816; b=DxND/UijF7iCyq1LrYS5dCij8Wc/W039uYPWZzmItpm7vlKu+KeIfSZf2jbXvc0AWm LqtaA66aF18JGhD4tEDk0O/skp0lvyY4lEZQbXiZkLOJ//Dlek5Vdy2HJeuCPrj7Dfwx phgqnvCSW91kL5IDR5ZoCSOgChMI5/GquwQKzxoSFsfwwHn0eQsW3riRf5hm11OmP5F+ N/paQk4A5Xd5y+24xgxFn3GtPFy0p+nSqy4rMBE6SyaA4HYQtLY17zgL5V1N1AW844aU l5YiNKORlH5QeiGylVYI5CMiczEmlaVY7a+SOVeH0O5H7hkpmjRRbNGpgMZkzi1UKKgO qrgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JYEmsOFHbXgS5MxsHkWI4gJFbQZO7FxeLmm0d1G/I18=; fh=LR5v1PItrt/38y71LjXyQ7kNzSHk4Ueo9S/+TraEzmI=; b=SSWiECTHU58MUExe3mIrCuod23H2ZXyk61G3aCA5mhpoKdceroAycBjJJqdGCYbFBr R3K3pF2Q9zyLRdFV6MOJA0QxY+qJtb/XKoFEYZa6GbwVX95i2j5PopbFs2lefmtv7CGc J+FOTERfwhfF8TjzJtArZulHAzWyVE8JodaM1oHnfHkgQ1DUp4XLiLEFei8F3uqGCJSq lEkL7OrJv9Oq882bRogK8Qh2TRi4wnuyMFIJ3yZnV8oC+XK/GkZ0JoxTE8ze12sWZar8 QYN5lkBookT+BHg7fEOhsHfMqWgUx8qPxeXBtom6pbC+KrcXQtUX0jqcbr79XY9oLLiB BiPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Dtr3GvoL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 67-20020a630246000000b0055785a37147si23285567pgc.590.2023.07.05.13.26.49; Wed, 05 Jul 2023 13:27:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Dtr3GvoL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233475AbjGETy2 (ORCPT + 99 others); Wed, 5 Jul 2023 15:54:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233435AbjGETyY (ORCPT ); Wed, 5 Jul 2023 15:54:24 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3EA041981; Wed, 5 Jul 2023 12:54:21 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 365JruRW029344; Wed, 5 Jul 2023 14:53:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1688586836; bh=JYEmsOFHbXgS5MxsHkWI4gJFbQZO7FxeLmm0d1G/I18=; h=From:To:CC:Subject:Date; b=Dtr3GvoLEH1+JV3O3xC2peTbniUUh/ZSq7Q9izsEuwludmzMUCn5n0sEuISQuHuly kwKid9WkcW3YLBQhPcA8BzLhPAD/fTrIxCADe4z4QlOLfmOUqK5nlgEchxFW1eJ3DK /crXLuuEVeUlM4dQqThHW3qsgJc8Ee1dLse8xWh8= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 365Jru2k083979 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 5 Jul 2023 14:53:56 -0500 Received: from DFLE101.ent.ti.com (10.64.6.22) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 5 Jul 2023 14:53:56 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 5 Jul 2023 14:53:56 -0500 Received: from uda0498204.dhcp.ti.com (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 365JrueS041658; Wed, 5 Jul 2023 14:53:56 -0500 From: Judith Mendez To: Chandrasekar Ramakrishnan , Marc Kleine-Budde CC: Wolfgang Grandegger , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , , , , Schuyler Patton , Tero Kristo , Rob Herring , Krzysztof Kozlowski , , Oliver Hartkopp , Simon Horman Subject: [PATCH 0/2] Enable multiple MCAN on AM62x Date: Wed, 5 Jul 2023 14:53:54 -0500 Message-ID: <20230705195356.866774-1-jm@ti.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770613715005617622?= X-GMAIL-MSGID: =?utf-8?q?1770613715005617622?= On AM62x there are two MCANs in MCU domain. The MCANs in MCU domain were not enabled since there is no hardware interrupt routed to A53 GIC interrupt controller. Therefore A53 Linux cannot be interrupted by MCU MCANs. This solution instantiates a hrtimer with 1 ms polling interval for MCAN device when there is no hardware interrupt property in DTB MCAN node. The hrtimer generates a recurring software interrupt which allows to call the isr. The isr will check if there is pending transaction by reading a register and proceed normally if there is. MCANs with hardware interrupt routed to A53 Linux will continue to use the hardware interrupt as expected. Timer polling method was tested on both classic CAN and CAN-FD at 125 KBPS, 250 KBPS, 1 MBPS and 2.5 MBPS with 4 MBPS bitrate switching. Letency and CPU load benchmarks were tested on 3x MCAN on AM62x. 1 MBPS timer polling interval is the better timer polling interval since it has comparable latency to hardware interrupt with the worse case being 1ms + CAN frame propagation time and CPU load is not substantial. Latency can be improved further with less than 1 ms polling intervals, howerver it is at the cost of CPU usage since CPU load increases at 0.5 ms. Note that in terms of power, enabling MCU MCANs with timer-polling implementation might have negative impact since we will have to wake up every 1 ms whether there are CAN packets pending in the RX FIFO or not. This might prevent the CPU from entering into deeper idle states for extended periods of time. v8: Link: https://lore.kernel.org/linux-can/20230530224820.303619-1-jm@ti.com/T/#t v7: Link: https://lore.kernel.org/linux-can/20230523023749.4526-1-jm@ti.com/T/#t v6: Link: https://lore.kernel.org/linux-can/20230518193613.15185-1-jm@ti.com/T/#t v5: Link: https://lore.kernel.org/linux-can/20230510202952.27111-1-jm@ti.com/T/#t v4: Link: https://lore.kernel.org/linux-can/c3395692-7dbf-19b2-bd3f-31ba86fa4ac9@linaro.org/T/#t v2: Link: https://lore.kernel.org/linux-can/20230424195402.516-1-jm@ti.com/T/#t V1: Link: https://lore.kernel.org/linux-can/19d8ae7f-7b74-a869-a818-93b74d106709@ti.com/T/#t RFC: Link: https://lore.kernel.org/linux-can/52a37e51-4143-9017-42ee-8d17c67028e3@ti.com/T/#t v9: - Change add MS to HRTIMER_POLL_INTERVAL - Change syntax from "= 0" to "!" v8: - Cancel hrtimer after interrupts in m_can_stop - Move assignment of hrtimer_callback to m_can_class_register() - Initialize irq = 0 if polling mode is used v7: - Clean up m_can_platform.c after removing poll-interval v6: - Move hrtimer stop/start function calls to m_can_open and m_can_close to support power suspend/resume v5: - Remove poll-interval in bindings - Change dev_dbg to dev_info if hardware int exists and polling is enabled v4: - Wrong patches sent v3: - Update binding poll-interval description - Add oneOf to select either interrupts/798d276b39e984345d52b933a900a71fa0815928 v2: - Add poll-interval property to bindings and MCAN DTB node - Add functionality to check for 'poll-interval' property in MCAN node - Bindings: add an example using poll-interval - Add 'polling' flag in driver to check if device is using polling method - Check for timer polling and hardware interrupt cases, default to hardware interrupt method - Change ns_to_ktime() to ms_to_ktime() Judith Mendez (2): dt-bindings: net: can: Remove interrupt properties for MCAN can: m_can: Add hrtimer to generate software interrupt .../bindings/net/can/bosch,m_can.yaml | 20 ++++++++++-- drivers/net/can/m_can/m_can.c | 32 ++++++++++++++++++- drivers/net/can/m_can/m_can.h | 3 ++ drivers/net/can/m_can/m_can_platform.c | 23 +++++++++++-- 4 files changed, 72 insertions(+), 6 deletions(-) base-commit: e1f6a8eaf1c271a0158114a03e3605f4fba059ad