Message ID | 20230703121838.70898-1-andriy.shevchenko@linux.intel.com |
---|---|
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp486408vqx; Mon, 3 Jul 2023 05:33:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54YLVF77q9ojCSVhCxRuV0XvvlegR2p2E5CCM6ipFBbe4VJdA0wHC7UBbguy44Bvxmqh9h X-Received: by 2002:a05:6a20:1446:b0:111:ee3b:59a7 with SMTP id a6-20020a056a20144600b00111ee3b59a7mr14492408pzi.5.1688387618298; Mon, 03 Jul 2023 05:33:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688387618; cv=none; d=google.com; s=arc-20160816; b=nYV4O9pLOLHmVOEOgWX1yxs8GA1ft6+YK4OY9ryxi4keqw0lkchzH7Q+A3+yvCwcxF dIwXHODd1Orqo4Ylpv83nkj7tKnvUbg/unXF5J23szx8F8zj8iozydKBizdVEvyVMyii mnMI4dTjqNXjov6lplRylKJAh28kaLTcJ0u7fDzc56eTReOJF1pV8W5Y2cXaj71tFgL0 6IvYjYDFOuFZXoBC6XRoRwTNnkIa2OpnVckM8FC+HqACweoMGFTwDXwE8dEtvjvRrINN 8FvmhMQ/xrJieXA0pBCvyswUk4JRb0GBT08thKsIDIKm/Jmk4Jfcs1DurDrdLHc2DNwt NhQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=X9GBKm3wt6dL9Gtttcu/JRxhdqzvbi/8p89J4mxYKKI=; fh=pnZ7JKqo4a1NkH5BtCuwVXjSzsf2RF1cbw2rekbMd8g=; b=Y9ISxJZ43aOxN2M5UR7ai5GReX8y4CHZ+zxylZKS3uov0gBCe2D23H+I9t9CQCKEjc YlU9b8Y/gVHFYsA8QGMSZZ26NqB0ToGQeVBNadMfAuHDnuqy1LEt4Anlgrk/ZwXDGZjk u+h7BvvZ5N7gAqa7p2ucpeeB7YRO0Jp9u2+tX/UhCmiM5VEo64yQzb7eHKomzsZgklu4 nHk4XB7oOa6EbA8XmWSA+X5aPrZgdW7G3XIud4t1qpqaXKL3XZkt6vuHxs7lorC4D89R fwQhv0/tFPFcA1/xg3UQdE+GO1PypCQIU7omIHHtjdAm68BwjxcbkwM9oUqgpLvvG4Yb I1zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YHqJwLJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cl11-20020a056a0032cb00b0067f4fd59b00si11245269pfb.260.2023.07.03.05.33.23; Mon, 03 Jul 2023 05:33:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=YHqJwLJN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbjGCMTK (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 99 others); Mon, 3 Jul 2023 08:19:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230338AbjGCMSy (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 3 Jul 2023 08:18:54 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 360A8115; Mon, 3 Jul 2023 05:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688386734; x=1719922734; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nKEsI2IZLID9V+jVyPeOLIm09S2eMx6zf5fhOw9OIoI=; b=YHqJwLJNb7/ukpW8F13QnQy/SFTrU5/IKJOttFJScWuHiddB6wlYWFme upzjd9wiy4KI7+2Lgf5nX/LGgKcOxmTb1m0UQJDwdyYRYG6RRx0DaVeoV nvOwQNYX4+Jy5t1OMbBzWXj+ZWFvGkBSE18SQaNTi9jyT8bvgUvMrJ1b8 bt7zX7/DCgnJcP0GBoK72HYozYSokjW+aQm5Qe1wsZ3FAMysm+bEgzJVX F/EYyNY3l8Zwr7XqSC5ryAM6yg5JvsviBfOLOUempaleJUspdPJ5EjZHN lqFNgtwQ3gkK5238EoT4mvB9NKj6Z5SvcsUVYFxMZwkHq626OwtAjrHmE g==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="343200927" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="343200927" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 05:18:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="831811639" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="831811639" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 03 Jul 2023 05:18:39 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 133B1170; Mon, 3 Jul 2023 15:18:41 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg <mika.westerberg@linux.intel.com>, Linus Walleij <linus.walleij@linaro.org>, Bartosz Golaszewski <brgl@bgdev.pl>, Benjamin Tissoires <benjamin.tissoires@redhat.com> Subject: [PATCH v1 0/3] gpiolib: Avpid modifying GPIO chip fwnode Date: Mon, 3 Jul 2023 15:18:35 +0300 Message-Id: <20230703121838.70898-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770402735073152242?= X-GMAIL-MSGID: =?utf-8?q?1770402735073152242?= |
Series |
gpiolib: Avpid modifying GPIO chip fwnode
|
|
Message
Andy Shevchenko
July 3, 2023, 12:18 p.m. UTC
Ideally the GPIO chip data structure has to be constant. In real life it's not true, but we can make it closer to that. Hence the series. Benjamin, would be nice it you can perform regression test for your case. Bart, the idea is that this series has to land immediately after v6.5-rc1 is out so we will have longer time to fix any downsides and regressions found, if any. Andy Shevchenko (3): gpiolib: of: Don't use GPIO chip fwnode in of_gpiochip_*() gpiolib: acpi: Don't use GPIO chip fwnode in acpi_gpiochip_find() gpiolib: Do not alter GPIO chip fwnode member drivers/gpio/gpiolib-acpi.c | 2 +- drivers/gpio/gpiolib-of.c | 6 +++--- drivers/gpio/gpiolib.c | 16 ++++++++-------- 3 files changed, 12 insertions(+), 12 deletions(-)
Comments
On Mon, Jul 3, 2023 at 2:18 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > Ideally the GPIO chip data structure has to be constant. > In real life it's not true, but we can make it closer to > that. Hence the series. > > Benjamin, would be nice it you can perform regression test for your > case. FWIW: Tested-by: Benjamin Tissoires <bentiss@kernel.org> I've tested Danny's series + my SSDT override, with and without your series on top of the master of hid.git (v6.4+merge of the hid.git tree for v6.5-rc1), and in both cases, I can access the I2C-HID node that sits on top of the CP2112 USB adapter. Cheers, Benjamin > > > Bart, the idea is that this series has to land immediately after > v6.5-rc1 is out so we will have longer time to fix any downsides > and regressions found, if any. > > Andy Shevchenko (3): > gpiolib: of: Don't use GPIO chip fwnode in of_gpiochip_*() > gpiolib: acpi: Don't use GPIO chip fwnode in acpi_gpiochip_find() > gpiolib: Do not alter GPIO chip fwnode member > > drivers/gpio/gpiolib-acpi.c | 2 +- > drivers/gpio/gpiolib-of.c | 6 +++--- > drivers/gpio/gpiolib.c | 16 ++++++++-------- > 3 files changed, 12 insertions(+), 12 deletions(-) > > -- > 2.40.0.1.gaa8946217a0b >
On Mon, Jul 03, 2023 at 04:06:38PM +0200, Benjamin Tissoires wrote: > On Mon, Jul 3, 2023 at 2:18 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > > > Ideally the GPIO chip data structure has to be constant. > > In real life it's not true, but we can make it closer to > > that. Hence the series. > > > > Benjamin, would be nice it you can perform regression test for your > > case. > > FWIW: > Tested-by: Benjamin Tissoires <bentiss@kernel.org> > > I've tested Danny's series + my SSDT override, with and without your > series on top of the master of hid.git (v6.4+merge of the hid.git tree > for v6.5-rc1), and in both cases, I can access the I2C-HID node that > sits on top of the CP2112 USB adapter. Thank you very much! I will issue a v2 either today or this week. So Bart will have time to review that and robots to test more before v6.5-rc1 is out. > > Bart, the idea is that this series has to land immediately after > > v6.5-rc1 is out so we will have longer time to fix any downsides > > and regressions found, if any.