mbox series

[0/5] ASoC: codecs: wcd938x/wcd934x: loglevel fix and cleanups

Message ID 20230630142717.5314-1-johan+linaro@kernel.org
Headers
Series ASoC: codecs: wcd938x/wcd934x: loglevel fix and cleanups |

Message

Johan Hovold June 30, 2023, 2:27 p.m. UTC 
  When investigating a race in the wcd938x driver I noticed that the MBHC
impedance measurements where printed at error loglevel which is clearly
wrong.

Fix that, and clean up the logging somewhat by using dev_printk() and
addressing some style issues.

Included are also two patches that drop the bogus inline keywords from
the functions involved.

Johan


Johan Hovold (5):
  ASoC: codecs: wcd938x: fix mbhc impedance loglevel
  ASoC: codecs: wcd938x: drop inline keywords
  ASoC: codecs: wcd938x: use dev_printk() for impedance logging
  ASoC: codecs: wcd934x: demote impedance printk loglevel
  ASoC: codecs: wcd934x: drop inline keywords

 sound/soc/codecs/wcd934x.c |  8 ++++----
 sound/soc/codecs/wcd938x.c | 17 +++++++++--------
 2 files changed, 13 insertions(+), 12 deletions(-)

Comments

Srinivas Kandagatla June 30, 2023, 3:02 p.m. UTC | #1 
On 30/06/2023 15:27, Johan Hovold wrote:
> When investigating a race in the wcd938x driver I noticed that the MBHC
> impedance measurements where printed at error loglevel which is clearly
> wrong.
> 
> Fix that, and clean up the logging somewhat by using dev_printk() and
> addressing some style issues.
> 
> Included are also two patches that drop the bogus inline keywords from
> the functions involved.
> 
> Johan
> 
> 
> Johan Hovold (5):
>    ASoC: codecs: wcd938x: fix mbhc impedance loglevel
>    ASoC: codecs: wcd938x: drop inline keywords
>    ASoC: codecs: wcd938x: use dev_printk() for impedance logging
>    ASoC: codecs: wcd934x: demote impedance printk loglevel
>    ASoC: codecs: wcd934x: drop inline keywords
> 

lgtm,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

--srini


>   sound/soc/codecs/wcd934x.c |  8 ++++----
>   sound/soc/codecs/wcd938x.c | 17 +++++++++--------
>   2 files changed, 13 insertions(+), 12 deletions(-)
>
Mark Brown July 3, 2023, 3:14 p.m. UTC | #2 
On Fri, 30 Jun 2023 16:27:12 +0200, Johan Hovold wrote:
> When investigating a race in the wcd938x driver I noticed that the MBHC
> impedance measurements where printed at error loglevel which is clearly
> wrong.
> 
> Fix that, and clean up the logging somewhat by using dev_printk() and
> addressing some style issues.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: codecs: wcd938x: fix mbhc impedance loglevel
      commit: e5ce198bd5c6923b6a51e1493b1401f84c24b26d
[2/5] ASoC: codecs: wcd938x: drop inline keywords
      commit: 5db9fe9562aaefca3c972401a9e3d6454707b1d5
[3/5] ASoC: codecs: wcd938x: use dev_printk() for impedance logging
      commit: 17d59d9ed832742f9572fe5e77ed3a66f5ae404d
[4/5] ASoC: codecs: wcd934x: demote impedance printk
      commit: cb7d60ab98cfe12fdd6052142176d42682f78540
[5/5] ASoC: codecs: wcd934x: drop inline keywords
      commit: c93723ada378a63929b3135b4f30483383e88e05

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark