From patchwork Tue Jun 27 12:08:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: mawupeng X-Patchwork-Id: 11340 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8153046vqr; Tue, 27 Jun 2023 05:22:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7E0FHs+gKCsFllYjfJ8A9mPG+pheb3nqmrnOwvSY6Me8KOHvRqDwZ6+epyEa8Q7D9QvOwi X-Received: by 2002:a17:906:58c5:b0:988:797c:759c with SMTP id e5-20020a17090658c500b00988797c759cmr25239082ejs.69.1687868578654; Tue, 27 Jun 2023 05:22:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687868578; cv=none; d=google.com; s=arc-20160816; b=ssFfgFSq7VU62dwLbtLdfZue+HKS83VoaDkxZD4LAXKFg+jNtNwvvKTnSrp63lqVzh zTauUehnNhV7+9d6VHpXFyH7m468hpSYYuEZYqm/h6e75kDpRTwIjjvwCLBYVdDddqwQ 9TJE/crzwiJMKNiw5vVL0L8BMS2K/Hx2vTqm1BI1kA9BbSi2AltmIRLldQYsdXYy4HVP VpdLkP4cW2L5Bd+Vi0RhS+QD1g/Ga4Ea5BdgiXiUg3ECYf1odYsXdIIm9Amh5aacHHg9 JwZJVrFsxeejMuiw4hmTLYTNXVjmd3kdl1JY40G884eug7LFp5RBrWP+XlO+TID1KxlV ivHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=FF0hPr8HAb2hcXVAmSyoVJVp6Drvo5ox1lgoCRYSE/s=; fh=B+lalLlRMhceeGv6a2GD0rnKBVzY964FmD9hd9xoQ4s=; b=hXLkdNPo4Q1lTqi8cUuWb32ytkXE4K2r3Ms3hZFL8s/UHlpsjWz7M6Is9NmxkBQkVR XDb7f7BKxEjfsJDPsAySBa0M6ailDsAxEmMCnbEBu2RQ3smEPfbKBrWWLzPvn5z8iPkZ KO+QkOyNP7Z30w5WKuuk1ikRK+41HA1PkQgn7EQwTdnxPIo4iXfp3QTfg2Anb/m0D9El w8KnB4cIPSKkn2iLSIYujzKYk/lcx7nGro3xkT0RGiQ8d98TFU+usA6Cn7ADDyhSbD7X uE1P75PYXRnNKy0JdwEdQoUVhMH7sFSafCtRrcGTyCVgIx6ebwrvDKnD6pdkPD2DQic5 7Zgg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb17-20020a170906b89100b00991f1e4b044si1601644ejb.336.2023.06.27.05.22.33; Tue, 27 Jun 2023 05:22:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231824AbjF0MIu (ORCPT + 99 others); Tue, 27 Jun 2023 08:08:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231800AbjF0MIn (ORCPT ); Tue, 27 Jun 2023 08:08:43 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 759B91999 for ; Tue, 27 Jun 2023 05:08:42 -0700 (PDT) Received: from dggpemm500014.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qr3Lv3X7czMnhv; Tue, 27 Jun 2023 20:05:27 +0800 (CST) Received: from localhost.localdomain (10.175.112.125) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 27 Jun 2023 20:08:37 +0800 From: Wupeng Ma To: CC: , , Subject: [PATCH 0/2] fix WARN_ON in add_to_avail_list Date: Tue, 27 Jun 2023 20:08:31 +0800 Message-ID: <20230627120833.2230766-1-mawupeng1@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.175.112.125] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769858482520829716?= X-GMAIL-MSGID: =?utf-8?q?1769858482520829716?= From: Ma Wupeng Our test find a WARN_ON in add_to_avail_list. During add_to_avail_list, avail_lists is already in swap_avail_heads, while lead to this WARN_ON. During swapoff, try_to_unuse fail to alloc memory due to memory limit and this lead the failure of swapoff and casing re-insert swap space back into swap_list. During _enable_swap_info, this swap device is added to avail list even this swap device if full. At the same time, one entry in this full swap device in released and try to add this device into avail list and found it is already in the avail list. This cause this WARN_ON. Ma Wupeng (2): swap: Cleanup duplicated WARN_ON in add_to_avail_list swap: Stop add to avail list is swap is full mm/swapfile.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)