From patchwork Tue Jun 27 08:56:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yu Kuai X-Patchwork-Id: 11330 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8073350vqr; Tue, 27 Jun 2023 02:54:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7IWuNZgqWEr8pKbrlCKDBOTIc9RttFei26/Pp1sUNfsSfK/gFqgjSOmJUG41ge8/ocT8+o X-Received: by 2002:a17:907:26cb:b0:982:bbc7:15c0 with SMTP id bp11-20020a17090726cb00b00982bbc715c0mr30310968ejc.66.1687859673795; Tue, 27 Jun 2023 02:54:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687859673; cv=none; d=google.com; s=arc-20160816; b=0+yabWpE+AbbpuIAXfNqCCBJHyoU9vQ58Z9LV9tdF/twY38JjXNY+OHqmEnnMyP7Tp 046y1wrOMHgrtLgIeKHBupB80ic4t5LuqLQljmHbq6RNnidAIP5WcEcA0WeYrNH9q/jC cUtXfakdVlyEvyUmVJPV088cJGx3+K+ADotOQ9IwutTYG85W5BBTrmMsdFqzzOMrF9Hp bLlCfC+TiJryGdc9mmPMzlxSqMErq76U+lI2/tkTa56UtQBkHqZK58PN8lGyckvgBaWB XuwHn0aIu/M6g4wLBSdUVCSbMYQiJ3VEi1eNDeRI6OeRpNjEfNbCIgXe/djdae+R4xiN EAYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=tppQJUPlTk2GUcl+WsQOFnCD4774DcZUkL2ZcxlLS98=; fh=P2RmqiG/AbPUM/TRpdNI39rrkM+L2D1IF6Cyfyo8sKQ=; b=qlDWdP0dYSRZGM1Vxk7ih2jYwshPqlJ7SS1sYl1xfxb0JYUa2xHSjSpo6WXrcuB8yI OzTiXrKFnZKlkoUwYDPRKKslMwpV0r084FmelH2xINJ+2/LTs/VliKMHUQx/dG2NalNb mUN0J7P50vdBD7cAgG0BD93PWA2NZO7/UbFkjILCzHBQgjxQrqvH4KFH0w9aHx7NCeGe 37XYT0Y9Ot1IfSSXamWSwc2G3dURpIUxI1lMyoHqi+3xXcMF0PKy8UZoqA/oyouJF35G KkV7w4oOQoDQQlYbTgABjt5jVIiznCQ9HCzGdivecqnyfBESoAGXXfy7acyCm6jZ9RyN aglg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t23-20020a170906179700b00982930191b4si4158664eje.546.2023.06.27.02.54.09; Tue, 27 Jun 2023 02:54:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231267AbjF0I5P (ORCPT + 99 others); Tue, 27 Jun 2023 04:57:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231354AbjF0I5L (ORCPT ); Tue, 27 Jun 2023 04:57:11 -0400 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F5811991; Tue, 27 Jun 2023 01:57:05 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4Qqz9T387Xz4f40xT; Tue, 27 Jun 2023 16:57:01 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.104.67]) by APP4 (Coremail) with SMTP id gCh0CgAHcLNcpJpkTBKTMg--.3216S4; Tue, 27 Jun 2023 16:57:02 +0800 (CST) From: Yu Kuai To: logang@deltatee.com, hch@lst.de, song@kernel.org, shli@fb.com Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH -next 0/2] md/raid5-cache: fix a deadlock in r5l_exit_log() Date: Tue, 27 Jun 2023 16:56:09 +0800 Message-Id: <20230627085611.4186951-1-yukuai1@huaweicloud.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CM-TRANSID: gCh0CgAHcLNcpJpkTBKTMg--.3216S4 X-Coremail-Antispam: 1UD129KBjvdXoW7JFy7WF4kJr1UCFy3tw18Xwb_yoWfXwcEgF yxWF98Gw4rA3Wakas5Cr1fGr97KrW8ZFWrtFy8trWa9Fy3XryFkr48Gr4rWa9rWrWDuFnx Cry8tFW8Jr1qgjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxxFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j 6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v n2kIc2xKxwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F4 0E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFyl IxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxV AFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6rW3Jr0E3s1lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjfUoO J5UUUUU X-CM-SenderInfo: 51xn3trlr6x35dzhxuhorxvhhfrp/ X-CFilter-Loop: Reflected X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769849145392023724?= X-GMAIL-MSGID: =?utf-8?q?1769849145392023724?= From: Yu Kuai Commit b13015af94cf ("md/raid5-cache: Clear conf->log after finishing work") introduce a new problem: // caller hold reconfig_mutex r5l_exit_log flush_work(&log->disable_writeback_work) r5c_disable_writeback_async wait_event /* * conf->log is not NULL, and mddev_trylock() * will fail, wait_event() can never pass. */ conf->log = NULL patch 1 revert this patch, an patch 2 fix the original problem in a different way. Noted this problem is just found by code review, and I think this is probably the reason that some mdadm tests is broken. Yu Kuai (2): md/raid5-cache: Revert "md/raid5-cache: Clear conf->log after finishing work" md/raid5-cache: fix null-ptr-deref in r5l_reclaim_thread() drivers/md/raid5-cache.c | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-)