mbox series

[v5,00/14] Add display driver for MT8188 VDOSYS1

Message ID 20230627063946.14935-1-shawn.sung@mediatek.com
Headers
Series Add display driver for MT8188 VDOSYS1 |

Message

Shawn Sung (宋孝謙) June 27, 2023, 6:39 a.m. UTC 
  Support MT8188 VDOSYS1 in display driver.

Changes in v5:
- Reuse .clk_enable/.clk_disable in struct mtk_ddp_comp_funcs
  in mtk_disp_ovl_adaptor.c
- Adjust commits order

Changes in v4:
- Add new functions in mtk_disp_ovl_adaptor.c to enable/disable
  components and reuse them when clock enable/disable
- Rename components in mtk_disp_ovl_adaptor.c and sort them in
  alphabetical order

Changes in v3:
- Define macro MMSYS_RST_NR in mtk-mmsys.h and update reset table
- Fix typos (ETDHR -> ETHDR, VSNYC -> VSYNC)
- Rebase dt-bindings on linux-next
- Refine description of Padding
- Squash reset bit map commits for VDO0 and VDO1 into one

Changes in v2:
- Remove redundant compatibles of MT8188 because it shares the same
  configuration with MT8195
- Separate dt-bindings by modules
- Support reset bit mapping in mmsys driver

Hsiao Chien Sung (14):
  dt-bindings: display: mediatek: ethdr: Add compatible for MT8188
  dt-bindings: display: mediatek: mdp-rdma: Add compatible for MT8188
  dt-bindings: display: mediatek: merge: Add compatible for MT8188
  dt-bindings: display: mediatek: padding: Add MT8188
  dt-bindings: arm: mediatek: Add compatible for MT8188
  dt-bindings: reset: mt8188: Add VDOSYS reset control bits
  soc: mediatek: Support MT8188 VDOSYS1 in mtk-mmsys
  soc: mediatek: Support MT8188 VDOSYS1 Padding in mtk-mmsys
  soc: mediatek: Support reset bit mapping in mmsys driver
  soc: mediatek: Add MT8188 VDOSYS reset bit map
  drm/mediatek: Support MT8188 VDOSYS1 in display driver
  drm/mediatek: Sort OVL adaptor components in alphabetical order
  drm/mediatek: Improve compatibility of display driver
  drm/mediatek: Support MT8188 Padding in display driver

 .../bindings/arm/mediatek/mediatek,mmsys.yaml |   1 +
 .../display/mediatek/mediatek,ethdr.yaml      |   6 +-
 .../display/mediatek/mediatek,mdp-rdma.yaml   |   6 +-
 .../display/mediatek/mediatek,merge.yaml      |   3 +
 .../display/mediatek/mediatek,padding.yaml    |  81 +++++++
 drivers/gpu/drm/mediatek/Makefile             |   3 +-
 drivers/gpu/drm/mediatek/mtk_disp_drv.h       |   3 +
 .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   | 226 +++++++++---------
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |   4 +
 drivers/gpu/drm/mediatek/mtk_drm_drv.h        |   2 +-
 drivers/gpu/drm/mediatek/mtk_mdp_rdma.c       |  20 +-
 drivers/gpu/drm/mediatek/mtk_padding.c        | 136 +++++++++++
 drivers/soc/mediatek/mt8188-mmsys.h           | 210 ++++++++++++++++
 drivers/soc/mediatek/mtk-mmsys.c              |  23 ++
 drivers/soc/mediatek/mtk-mmsys.h              |  32 +++
 drivers/soc/mediatek/mtk-mutex.c              |  51 ++++
 include/dt-bindings/reset/mt8188-resets.h     |  75 ++++++
 include/linux/soc/mediatek/mtk-mmsys.h        |   8 +
 18 files changed, 768 insertions(+), 122 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/display/mediatek/mediatek,padding.yaml
 create mode 100644 drivers/gpu/drm/mediatek/mtk_padding.c

--
2.18.0

Comments

Fei Shao July 18, 2023, 8:08 a.m. UTC | #1 
Hi Hsiao-Chien,

On Tue, Jun 27, 2023 at 2:50 PM Hsiao Chien Sung
<shawn.sung@mediatek.com> wrote:
>
> Support MT8188 VDOSYS1 in display driver.

I'm testing this series with my local MT8188 setup + an external 4K
display, and I feel there is something missing in it.
With these patches the external display can be lit up on my end, but I
only see glitches and no meaningful content is rendered.
Could you check again and send the updated series with the fix?

Thanks,
Fei
Shawn Sung (宋孝謙) July 18, 2023, 11:24 a.m. UTC | #2 
Hi Fei,

On Tue, 2023-07-18 at 16:08 +0800, Fei Shao wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Hi Hsiao-Chien,
> 
> On Tue, Jun 27, 2023 at 2:50 PM Hsiao Chien Sung
> <shawn.sung@mediatek.com> wrote:
> >
> > Support MT8188 VDOSYS1 in display driver.
> 
> I'm testing this series with my local MT8188 setup + an external 4K
> display, and I feel there is something missing in it.

Yes, there is a patch for fixing DPI misconfiguration (.input_2pixel =
true), but since I'm not DPI owner, didn't include that in this patch.

> With these patches the external display can be lit up on my end, but
> I
> only see glitches and no meaningful content is rendered.
> Could you check again and send the updated series with the fix?

Will discuss with DPI owner and merge that fix into this series and re-
send it again if you would like to.

> 
> Thanks,
> Fei

Thanks,
Hsiao Chien Sung