From patchwork Mon Jun 26 15:28:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 11301 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp7587071vqr; Mon, 26 Jun 2023 09:04:56 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7MCeFTLW5+7RUeFRJDuhrjlBlp+Z6NM8Z3uCgTYgIyI6XJEJpum9v+vvlIBTiL21mwjgAb X-Received: by 2002:a62:8283:0:b0:668:8ad5:778f with SMTP id w125-20020a628283000000b006688ad5778fmr22922808pfd.17.1687795496150; Mon, 26 Jun 2023 09:04:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687795496; cv=none; d=google.com; s=arc-20160816; b=RZFm0XYoV3ijX5ahXe0E6xsxQg+VR1V5VcunQBMzIFXENKz88bDqTm0qsz3qWHWz7F I1afs/c6/tZmXEoJlsHPwu93oKwMfBjJe3Cf3CAFqwGcnBZ5GjECbcNOd5RRye5qQksm xLPyD0Xsk7keCOLanON8gmbOR3qzZWmPNAZ97N9GBujwNOELu6JDNouGjfHGoJs0P7Bd NvEBOGU1dTkaHS9Zxw3FsE7LXN8K0PzbdHZweWVLD4EY2Or0Q1KMKJVCo/Xmq2LSIhnj P5qrXqwlYVRbB3rp21w11VXeMutRrQPyvjuDEDRz27oC5p2Xprpa1Z2CoUdO9HW+/Myd OjWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=6QE9mCQbwzZnyVSXvlLu86vX0zP353mJfm+/rQkuZow=; fh=FLcX+XbzkOw3QxHQPjO014/8K+Khr2r3DSj6x1yx7i0=; b=AlYYwhMBOhpFsI/8zwCmyRjOlzCMooE3lD95JhBHyrlIPgG/QQ1Pfj4LllKLHi+Ajq Yk7pmqdumPMIsUoeNayT0IS2jOBZxVVM4k9lPqlHOGZv+xqXLFm4a1UF8aG0fwoOpd2V mtODCHiYJZPhJy6g5TyWNKFeMkMLwMiWVQChScER5C/Hs3uUwaBAr2narzq0CIq+Ge4f QpysLpl/A0nVmAUnnmBKO9Ild73/nfrED/Q0SgDOHLbELLPZY2Cc73xNX6IHLmtW/9ta Kw+6gbDAghg5e8CcDg7Jmg22XfUi5XqTujzRahOv3nSPrdz1VvBymeT25s2QEhji9BEP V+Kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W6J0PeX7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id fi31-20020a056a00399f00b0066356d0888dsi5222343pfb.126.2023.06.26.09.04.11; Mon, 26 Jun 2023 09:04:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W6J0PeX7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231305AbjFZPkP (ORCPT + 99 others); Mon, 26 Jun 2023 11:40:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231210AbjFZPkO (ORCPT ); Mon, 26 Jun 2023 11:40:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B19FF3 for ; Mon, 26 Jun 2023 08:40:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C730560EC2 for ; Mon, 26 Jun 2023 15:40:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88117C433C8; Mon, 26 Jun 2023 15:40:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687794012; bh=dwXCF9f2fQo97nSVcp6MB0XwLHJLjovoiu215aV3VIM=; h=From:To:Cc:Subject:Date:From; b=W6J0PeX7nYnoL6w01+rkgKirTv4OLMBI/68lgNEjJ6QrTT0+U5tJy43V9tdw/p/FZ U2Z4ez+Tej6OdPwLCrOOl9FQ1K5JE0Ccdy0fuIysYDlXH/mZMxJ5jFoWmr644S/Gio UgHgnyTrtpDXoh+g8dOS3EHJY4MXMPaVoF+H0FfZARHiKKZwVQD8QNdO97ieAMcsTT UbpzN2fWkB+xjxgFhRaxcAJ/XpEDcZcc1+0bgc0P85runCJPxLuWnkmi5LHgl4Sw9O +r/8+L+FQU0eI8iTkh7peEb5CZohWf6/NNMPyDEIYjWZSjTP9yp3GTvlUUYRXwfnDq EM5evYV8nKdyg== From: Jisheng Zhang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Simon Horman Subject: [PATCH net-next v4 0/2] net: stmmac: improve driver statistics Date: Mon, 26 Jun 2023 23:28:42 +0800 Message-Id: <20230626152844.484-1-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769781850310682877?= X-GMAIL-MSGID: =?utf-8?q?1769781850310682877?= improve the stmmac driver statistics: 1. don't clear network driver statistics in .ndo_close() and .ndo_open() cycle 2. avoid some network driver statistics overflow on 32 bit platforms 3. use per-queue statistics where necessary to remove frequent cacheline ping pongs. NOTE: v1 and v2 are back ported from an internal LTS tree, I made some mistakes when backporting and squashing. Now, net-next + v3 has been well tested with 'ethtool -s' and 'ip -s link show'. Since v3: - coding style pointed out by Simon, I.E reverse xmas tree for local variable declarations and so on. - put the counters in queue structs, I.E per-queue rather than per-cpu - use _irqsave() variant where necessary. Since v2: - fix ethtool .get_sset_count, .get_strings and per queue stats couting. - fix .ndo_get_stats64 only counts the last cpu's pcpu stats. - fix typo: s/iff/if in commit msg. - remove unnecessary if statement brackets since we have removed one LoC. Since v1: - rebase on net-next - fold two original patches into one patch - fix issues found by lkp - update commit msg Jisheng Zhang (2): net: stmmac: don't clear network statistics in .ndo_open() net: stmmac: use per-queue 64 bit statistics where necessary drivers/net/ethernet/stmicro/stmmac/common.h | 39 ++-- .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 12 +- .../ethernet/stmicro/stmmac/dwmac100_dma.c | 7 +- .../ethernet/stmicro/stmmac/dwmac4_descs.c | 16 +- .../net/ethernet/stmicro/stmmac/dwmac4_lib.c | 15 +- .../net/ethernet/stmicro/stmmac/dwmac_lib.c | 12 +- .../ethernet/stmicro/stmmac/dwxgmac2_descs.c | 6 +- .../ethernet/stmicro/stmmac/dwxgmac2_dma.c | 14 +- .../net/ethernet/stmicro/stmmac/enh_desc.c | 20 +- drivers/net/ethernet/stmicro/stmmac/hwif.h | 12 +- .../net/ethernet/stmicro/stmmac/norm_desc.c | 15 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 + .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 123 ++++++++--- .../net/ethernet/stmicro/stmmac/stmmac_main.c | 206 ++++++++++++++---- 14 files changed, 337 insertions(+), 162 deletions(-)