[0/2] Baisc devicetree support for Amlogic T7

Message ID 20230626095223.721011-1-xianwei.zhao@amlogic.com
Headers
Series Baisc devicetree support for Amlogic T7 |

Message

Xianwei Zhao June 26, 2023, 9:52 a.m. UTC
  T7 is an advanced application processor designed for smart display.

Add the new T7 SoC/board device tree bindings.

Add basic support for the T7 based Amlogic AN400 board, which describes
the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
booting up into the serial console.

Xianwei Zhao (2):
  dt-bindings: arm: amlogic: add T7 based AN400 bindings
  arm64: dts: add support for T7 based Amlogic AN400

 .../devicetree/bindings/arm/amlogic.yaml      |   6 +
 arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
 4 files changed, 193 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
 create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi


base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
  

Comments

Conor Dooley June 26, 2023, 10:02 a.m. UTC | #1
Hey,

On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
> T7 is an advanced application processor designed for smart display.
> 
> Add the new T7 SoC/board device tree bindings.
> 
> Add basic support for the T7 based Amlogic AN400 board, which describes
> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
> booting up into the serial console.

Lucas has already sent patches for the T7 SoC & is at v5:
https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/

There's been a bit of discussion there, and there serial stuff in
particular is different in his series (it doesn't use always-on for
examples).
Could you please go and take a look at his series?

Cheers,
Conor.

> 
> Xianwei Zhao (2):
>   dt-bindings: arm: amlogic: add T7 based AN400 bindings
>   arm64: dts: add support for T7 based Amlogic AN400
> 
>  .../devicetree/bindings/arm/amlogic.yaml      |   6 +
>  arch/arm64/boot/dts/amlogic/Makefile          |   1 +
>  .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
>  arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
>  4 files changed, 193 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
>  create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> 
> 
> base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
> -- 
> 2.37.1
>
  
Xianwei Zhao June 27, 2023, 6:13 a.m. UTC | #2
Hi Conor,
     Thanks for you reply.
On 2023/6/26 18:02, Conor Dooley wrote:


 > [ EXTERNAL EMAIL ]
 >
 > Hey,
 >
 > On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
 >> T7 is an advanced application processor designed for smart display.
 >>
 >> Add the new T7 SoC/board device tree bindings.
 >>
 >> Add basic support for the T7 based Amlogic AN400 board, which describes
 >> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
 >> booting up into the serial console.
 >
 > Lucas has already sent patches for the T7 SoC & is at v5:
 > 
https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/
 >
 > There's been a bit of discussion there, and there serial stuff in
 > particular is different in his series (it doesn't use always-on for
 > examples).
 > Could you please go and take a look at his series?
 >
 > Cheers,
 > Conor.
 >
AN400 is the reference board designed by Amlogic, which is different 
from Khadas VIM4.
And T7 serial is the same as S4, so I follow S4 serial.

 >>
 >> Xianwei Zhao (2):
 >>    dt-bindings: arm: amlogic: add T7 based AN400 bindings
 >>    arm64: dts: add support for T7 based Amlogic AN400
 >>
 >>   .../devicetree/bindings/arm/amlogic.yaml      |   6 +
 >>   arch/arm64/boot/dts/amlogic/Makefile          |   1 +
 >>   .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
 >>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
 >>   4 files changed, 193 insertions(+)
 >> create mode 100644 
arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
 >> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
 >>
 >>
 >> base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
 >> --
 >> 2.37.1
 >>
 >>
 >> _______________________________________________
 >> linux-amlogic mailing list
 >> linux-amlogic@lists.infradead.org
 >> http://lists.infradead.org/mailman/listinfo/linux-amlogic
  
Conor Dooley June 27, 2023, 7:23 a.m. UTC | #3
On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
> Hi Conor,
>     Thanks for you reply.
> On 2023/6/26 18:02, Conor Dooley wrote:
> 
> 
> > [ EXTERNAL EMAIL ]
> >
> > Hey,
> >
> > On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
> >> T7 is an advanced application processor designed for smart display.
> >>
> >> Add the new T7 SoC/board device tree bindings.
> >>
> >> Add basic support for the T7 based Amlogic AN400 board, which describes
> >> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
> >> booting up into the serial console.
> >
> > Lucas has already sent patches for the T7 SoC & is at v5:
> > https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/
> >
> > There's been a bit of discussion there, and there serial stuff in
> > particular is different in his series (it doesn't use always-on for
> > examples).
> > Could you please go and take a look at his series?
> >
> > Cheers,
> > Conor.
> >
> AN400 is the reference board designed by Amlogic, which is different from
> Khadas VIM4.

Yet you share the same dtsi, which he has got through several iterations
of before you arrived.

> And T7 serial is the same as S4, so I follow S4 serial.

Yeah, no. SoC specific compatible please.
  
Neil Armstrong June 27, 2023, 7:43 a.m. UTC | #4
On 27/06/2023 08:13, Xianwei Zhao wrote:
> Hi Conor,
>      Thanks for you reply.
> On 2023/6/26 18:02, Conor Dooley wrote:
> 
> 
>  > [ EXTERNAL EMAIL ]
>  >
>  > Hey,
>  >
>  > On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
>  >> T7 is an advanced application processor designed for smart display.
>  >>
>  >> Add the new T7 SoC/board device tree bindings.
>  >>
>  >> Add basic support for the T7 based Amlogic AN400 board, which describes
>  >> the following components: CPU, GIC, IRQ, Timer, UART. It's capable of
>  >> booting up into the serial console.
>  >
>  > Lucas has already sent patches for the T7 SoC & is at v5:
>  > https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-tanure@linux.com/
>  >
>  > There's been a bit of discussion there, and there serial stuff in
>  > particular is different in his series (it doesn't use always-on for
>  > examples).
>  > Could you please go and take a look at his series?
>  >
>  > Cheers,
>  > Conor.
>  >
> AN400 is the reference board designed by Amlogic, which is different from Khadas VIM4.

Please coordinate with Lucas so a single bindings & dtsi patches are submitted,
in any case only a single one will be reviewed and merged.
You can rebase your AN400 dts on top of his VIM4 initial patchset.

Thanks,
Neil

> And T7 serial is the same as S4, so I follow S4 serial.
> 
>  >>
>  >> Xianwei Zhao (2):
>  >>    dt-bindings: arm: amlogic: add T7 based AN400 bindings
>  >>    arm64: dts: add support for T7 based Amlogic AN400
>  >>
>  >>   .../devicetree/bindings/arm/amlogic.yaml      |   6 +
>  >>   arch/arm64/boot/dts/amlogic/Makefile          |   1 +
>  >>   .../dts/amlogic/amlogic-t7-a311d2-an400.dts   |  30 ++++
>  >>   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   | 156 ++++++++++++++++++
>  >>   4 files changed, 193 insertions(+)
>  >> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7-a311d2-an400.dts
>  >> create mode 100644 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
>  >>
>  >>
>  >> base-commit: 057889cb4244096ea5abcbe76ffd4d311c3078fe
>  >> --
>  >> 2.37.1
>  >>
>  >>
>  >> _______________________________________________
>  >> linux-amlogic mailing list
>  >> linux-amlogic@lists.infradead.org
>  >> http://lists.infradead.org/mailman/listinfo/linux-amlogic
  
Xianwei Zhao June 27, 2023, 7:51 a.m. UTC | #5
On 2023/6/27 15:23, Conor Dooley wrote:


 > [ EXTERNAL EMAIL ]
 >
 > On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
 >> Hi Conor,
 >>      Thanks for you reply.
 >> On 2023/6/26 18:02, Conor Dooley wrote:
 >>
 >>
 >>> [ EXTERNAL EMAIL ]
 >>>
 >>> Hey,
 >>>
 >>> On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
 >>>> T7 is an advanced application processor designed for smart display.
 >>>>
 >>>> Add the new T7 SoC/board device tree bindings.
 >>>>
 >>>> Add basic support for the T7 based Amlogic AN400 board, which
 >>>> describesthe following components: CPU, GIC, IRQ, Timer, UART. It's
 >>>> capable of booting up into the serial console.
 >>>
 >>> Lucas has already sent patches for the T7 SoC & is at v5:
 >>> https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-
 >>> tanure@linux.com/
 >>> There's been a bit of discussion there, and there serial stuff in
 >>> particular is different in his series (it doesn't use always-on for
 >>> examples).
 >>> Could you please go and take a look at his series?
 >>>
 >>> Cheers,
 >>> Conor.
 >>>
 >> AN400 is the reference board designed by Amlogic, which is different
 >> from Khadas VIM4.
 >
 > Yet you share the same dtsi, which he has got through several
 > iterations of before you arrived.
 >
Hi Lucas,
Are you going to continue with the dtsi part?

 >> And T7 serial is the same as S4, so I follow S4 serial.
 >
 > Yeah, no. SoC specific compatible please.
 >
 >
 > _______________________________________________
 > linux-amlogic mailing list
 > linux-amlogic@lists.infradead.org
 > http://lists.infradead.org/mailman/listinfo/linux-amlogic
  
Lucas Tanure June 29, 2023, 4:33 p.m. UTC | #6
On Tue, Jun 27, 2023 at 8:52 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>
>
> On 2023/6/27 15:23, Conor Dooley wrote:
>
>
>  > [ EXTERNAL EMAIL ]
>  >
>  > On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
>  >> Hi Conor,
>  >>      Thanks for you reply.
>  >> On 2023/6/26 18:02, Conor Dooley wrote:
>  >>
>  >>
>  >>> [ EXTERNAL EMAIL ]
>  >>>
>  >>> Hey,
>  >>>
>  >>> On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
>  >>>> T7 is an advanced application processor designed for smart display.
>  >>>>
>  >>>> Add the new T7 SoC/board device tree bindings.
>  >>>>
>  >>>> Add basic support for the T7 based Amlogic AN400 board, which
>  >>>> describesthe following components: CPU, GIC, IRQ, Timer, UART. It's
>  >>>> capable of booting up into the serial console.
>  >>>
>  >>> Lucas has already sent patches for the T7 SoC & is at v5:
>  >>> https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-
>  >>> tanure@linux.com/
>  >>> There's been a bit of discussion there, and there serial stuff in
>  >>> particular is different in his series (it doesn't use always-on for
>  >>> examples).
>  >>> Could you please go and take a look at his series?
>  >>>
>  >>> Cheers,
>  >>> Conor.
>  >>>
>  >> AN400 is the reference board designed by Amlogic, which is different
>  >> from Khadas VIM4.
>  >
>  > Yet you share the same dtsi, which he has got through several
>  > iterations of before you arrived.
>  >
> Hi Lucas,
> Are you going to continue with the dtsi part?
>
>  >> And T7 serial is the same as S4, so I follow S4 serial.
>  >
>  > Yeah, no. SoC specific compatible please.
>  >
>  >
>  > _______________________________________________
>  > linux-amlogic mailing list
>  > linux-amlogic@lists.infradead.org
>  > http://lists.infradead.org/mailman/listinfo/linux-amlogic

Hi Xianwei,

I am doing the basics for Amlogic T7 A311D2, but the next step ( sd
card or emmc, something to boot on) would be more difficult for me
than you.
After the first series for Vim4 gets merged, I will start to work on
how to get sd cards working.
But if you already have that working for the AN400 board, please send
it. And I will look at that work and use it for Vim4.

Or, if you don't have it ready and want to share it with me, we can
work together on these A311D2 patches.
You test on AN400, and I test on Vim4.

Thanks
Lucas
  
Xianwei Zhao June 30, 2023, 2:21 a.m. UTC | #7
On 2023/6/30 00:33, Lucas Tanure wrote:
> [ EXTERNAL EMAIL ]
> 
> On Tue, Jun 27, 2023 at 8:52 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>>
>>
>> On 2023/6/27 15:23, Conor Dooley wrote:
>>
>>
>>   > [ EXTERNAL EMAIL ]
>>   >
>>   > On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
>>   >> Hi Conor,
>>   >>      Thanks for you reply.
>>   >> On 2023/6/26 18:02, Conor Dooley wrote:
>>   >>
>>   >>
>>   >>> [ EXTERNAL EMAIL ]
>>   >>>
>>   >>> Hey,
>>   >>>
>>   >>> On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
>>   >>>> T7 is an advanced application processor designed for smart display.
>>   >>>>
>>   >>>> Add the new T7 SoC/board device tree bindings.
>>   >>>>
>>   >>>> Add basic support for the T7 based Amlogic AN400 board, which
>>   >>>> describesthe following components: CPU, GIC, IRQ, Timer, UART. It's
>>   >>>> capable of booting up into the serial console.
>>   >>>
>>   >>> Lucas has already sent patches for the T7 SoC & is at v5:
>>   >>> https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-
>>   >>> tanure@linux.com/
>>   >>> There's been a bit of discussion there, and there serial stuff in
>>   >>> particular is different in his series (it doesn't use always-on for
>>   >>> examples).
>>   >>> Could you please go and take a look at his series?
>>   >>>
>>   >>> Cheers,
>>   >>> Conor.
>>   >>>
>>   >> AN400 is the reference board designed by Amlogic, which is different
>>   >> from Khadas VIM4.
>>   >
>>   > Yet you share the same dtsi, which he has got through several
>>   > iterations of before you arrived.
>>   >
>> Hi Lucas,
>> Are you going to continue with the dtsi part?
>>
>>   >> And T7 serial is the same as S4, so I follow S4 serial.
>>   >
>>   > Yeah, no. SoC specific compatible please.
>>   >
>>   >
>>   > _______________________________________________
>>   > linux-amlogic mailing list
>>   > linux-amlogic@lists.infradead.org
>>   > http://lists.infradead.org/mailman/listinfo/linux-amlogic
> 
> Hi Xianwei,
> 
> I am doing the basics for Amlogic T7 A311D2, but the next step ( sd
> card or emmc, something to boot on) would be more difficult for me
> than you.
> After the first series for Vim4 gets merged, I will start to work on
> how to get sd cards working.
> But if you already have that working for the AN400 board, please send
> it. And I will look at that work and use it for Vim4.
> 
> Or, if you don't have it ready and want to share it with me, we can
> work together on these A311D2 patches.
> You test on AN400, and I test on Vim4.
> 
> Thanks
> Lucas

We are preparing this part. However it depends on clock. So the clock 
must ready first.
  
Lucas Tanure June 30, 2023, 4:39 a.m. UTC | #8
On Fri, Jun 30, 2023 at 3:22 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
>
>
>
> On 2023/6/30 00:33, Lucas Tanure wrote:
> > [ EXTERNAL EMAIL ]
> >
> > On Tue, Jun 27, 2023 at 8:52 AM Xianwei Zhao <xianwei.zhao@amlogic.com> wrote:
> >>
> >>
> >> On 2023/6/27 15:23, Conor Dooley wrote:
> >>
> >>
> >>   > [ EXTERNAL EMAIL ]
> >>   >
> >>   > On Tue, Jun 27, 2023 at 02:13:34PM +0800, Xianwei Zhao wrote:
> >>   >> Hi Conor,
> >>   >>      Thanks for you reply.
> >>   >> On 2023/6/26 18:02, Conor Dooley wrote:
> >>   >>
> >>   >>
> >>   >>> [ EXTERNAL EMAIL ]
> >>   >>>
> >>   >>> Hey,
> >>   >>>
> >>   >>> On Mon, Jun 26, 2023 at 05:52:21PM +0800, Xianwei Zhao wrote:
> >>   >>>> T7 is an advanced application processor designed for smart display.
> >>   >>>>
> >>   >>>> Add the new T7 SoC/board device tree bindings.
> >>   >>>>
> >>   >>>> Add basic support for the T7 based Amlogic AN400 board, which
> >>   >>>> describesthe following components: CPU, GIC, IRQ, Timer, UART. It's
> >>   >>>> capable of booting up into the serial console.
> >>   >>>
> >>   >>> Lucas has already sent patches for the T7 SoC & is at v5:
> >>   >>> https://lore.kernel.org/linux-devicetree/20230623081242.109131-1-
> >>   >>> tanure@linux.com/
> >>   >>> There's been a bit of discussion there, and there serial stuff in
> >>   >>> particular is different in his series (it doesn't use always-on for
> >>   >>> examples).
> >>   >>> Could you please go and take a look at his series?
> >>   >>>
> >>   >>> Cheers,
> >>   >>> Conor.
> >>   >>>
> >>   >> AN400 is the reference board designed by Amlogic, which is different
> >>   >> from Khadas VIM4.
> >>   >
> >>   > Yet you share the same dtsi, which he has got through several
> >>   > iterations of before you arrived.
> >>   >
> >> Hi Lucas,
> >> Are you going to continue with the dtsi part?
> >>
> >>   >> And T7 serial is the same as S4, so I follow S4 serial.
> >>   >
> >>   > Yeah, no. SoC specific compatible please.
> >>   >
> >>   >
> >>   > _______________________________________________
> >>   > linux-amlogic mailing list
> >>   > linux-amlogic@lists.infradead.org
> >>   > http://lists.infradead.org/mailman/listinfo/linux-amlogic
> >
> > Hi Xianwei,
> >
> > I am doing the basics for Amlogic T7 A311D2, but the next step ( sd
> > card or emmc, something to boot on) would be more difficult for me
> > than you.
> > After the first series for Vim4 gets merged, I will start to work on
> > how to get sd cards working.
> > But if you already have that working for the AN400 board, please send
> > it. And I will look at that work and use it for Vim4.
> >
> > Or, if you don't have it ready and want to share it with me, we can
> > work together on these A311D2 patches.
> > You test on AN400, and I test on Vim4.
> >
> > Thanks
> > Lucas
>
> We are preparing this part. However it depends on clock. So the clock
> must ready first.

Will you send clock for T7?